April 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: New test method in DBConfigUtilsTest
by yzaslavs＠redhat.com 17 Apr '13

17 Apr '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine: New test method in DBConfigUtilsTest ...................................................................... engine: New test method in DBConfigUtilsTest There seems to be a perception in the community that there is some bug in the config framework because of which the api returns a null value if there is no entry in vdc_options for a given config. This patch attempts to add a new test case that verifies that this is not the case, and if entry is missing in vdc_options, value returned is from the @DefaultValueAttribute annotation in ConfigValues enum. For this purpose, - Modified DBConfigUtilsTest to extend from BaseDAOTestCase, so that fixtures.xml can be used to insert entries in vdc_options - Modified fixtures.xml to insert two entries in vdc_options for the config NonVmNetworkSupported for version 3.0 and 3.2 - Renamed DBConfigUtils#RefreshVdcOptionCache to refreshVdcOptionCache and made it protected so that it can be called from test class passing the test dbFacade - Added new test method testGetValue() to verify that default value is returned if entry is not present in vdc_options Change-Id: Ia736419e766bc6ce2e82158f775817e885b90dfd Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtils.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtilsTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdcOptionDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 4 files changed, 30 insertions(+), 5 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia736419e766bc6ce2e82158f775817e885b90dfd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: AssignQuota button under disks refresh bug
by gchaplik＠redhat.com 17 Apr '13

17 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: AssignQuota button under disks refresh bug ...................................................................... engine: AssignQuota button under disks refresh bug In case a quota mode set to !Disabled (or vice-versa) the Assign Quota button (in various disk tabs) availability wasn't refreshed. The problem caused because we relied on the selected DC tree item quota mode, which not getting refreshed in current ui infrastructure. Instead we will fetch quota mode from disk BE itself. A bug was fixed in DB to reference data center even if there is no quota for the disk (using the storageDomain DC instead of quota table). To allow new functionality for all tabs, introduced a new interface and static public utility method to avoid code duplication. Change-Id: I21a0886cfe82d441ad93fd9b15d72f8a4e63002c Bug-Url: https://bugzilla.redhat.com/950519 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/ChangeQuotaModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateDiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java 5 files changed, 100 insertions(+), 67 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13925 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21a0886cfe82d441ad93fd9b15d72f8a4e63002c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: unlocalized properties in common general tab
by gchaplik＠redhat.com 17 Apr '13

17 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: unlocalized properties in common general tab ...................................................................... webadmin: unlocalized properties in common general tab Changes are made in vm, template and pool general subtabs: - vm priority - vm sockets count - run on 'any host in cluster' Change-Id: I24151bc17538fb7489458ac0c34e10b98726812f Bug-Url: https://bugzilla.redhat.com/950826 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 5 files changed, 49 insertions(+), 60 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13884 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24151bc17538fb7489458ac0c34e10b98726812f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Multiple consoles in WebAdmin
by tjelinek＠redhat.com 17 Apr '13

17 Apr '13

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Multiple consoles in WebAdmin ...................................................................... webadmin: Multiple consoles in WebAdmin Multiple consoles can be opened for selected VMs in WebAdmin using one command. The Console button/menu item is enabled, when at least one VM has a valid console. Tested for Spice plugin as well as MIME attachment servlet. Change-Id: I894eaeafab22614af3f219169ef73d7fbeed3a11 Signed-off-by: Libor Spevak <lspevak(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/WebAdminItemModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostVmView.java 4 files changed, 205 insertions(+), 105 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Libor Spevak: Verified -- To view, visit http://gerrit.ovirt.org/13847 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I894eaeafab22614af3f219169ef73d7fbeed3a11 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.2]: sos - refactored engine sos plugin
by knesenko＠redhat.com 17 Apr '13

17 Apr '13

Kiril Nesenko has submitted this change and it was merged. Change subject: sos - refactored engine sos plugin ...................................................................... sos - refactored engine sos plugin engine sos plugin used two flags: vdsmlogs and prefix. Both flags were implemented with behaviors not acceptable by sos developers: - vdsmlogs is not a boolean flag: it was used for specifying a path containing logs collected by sosreport runs on other hosts; if required the path should have been determined without allowing the user to specify a generic path like '/' - prefix is not a boolean flag and was used for changing the name of the report tarball. The name was changed altering the sosreport policy instead of creating a new policy. Both these 2 flag are meaningless if you run sosreport -a -o engine because -a set both the flags to True and because running sosreport you can't collect hypervisors sosreport in vdsmlogs and you want a standard sosreport. I've refactored the engine sos plugin removing both the flags. It's engine-log-collector that will take care to rename the tarball with the desired prefix and it's engine-log-collector that will take care of adding the vdsmlogs to the archive. PREVIOUS: - collect and archive postgres data in a scratch dir - collect and archive hypervisors data in a scratch dir - collect and archive engine data (including the above in /tmp) NOW: - collect engine data - collect and archive postgres data in log-collector-data - collect and archive hypervisors data in log-collector-data - archive all the above in a single tarball. (cherry picked from commit 6a09d066192507c01b775f15c16dd2d5af11778d) Change-Id: Ib226ec23b98450a03ebd2a64043a911645a62235 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py M src/sos/plugins/engine.py 2 files changed, 71 insertions(+), 50 deletions(-) Approvals: Sandro Bonazzola: Verified Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13970 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib226ec23b98450a03ebd2a64043a911645a62235 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-log-collector[master]: sos - refactored engine sos plugin
by knesenko＠redhat.com 17 Apr '13

17 Apr '13

Kiril Nesenko has submitted this change and it was merged. Change subject: sos - refactored engine sos plugin ...................................................................... sos - refactored engine sos plugin engine sos plugin used two flags: vdsmlogs and prefix. Both flags were implemented with behaviors not acceptable by sos developers: - vdsmlogs is not a boolean flag: it was used for specifying a path containing logs collected by sosreport runs on other hosts; if required the path should have been determined without allowing the user to specify a generic path like '/' - prefix is not a boolean flag and was used for changing the name of the report tarball. The name was changed altering the sosreport policy instead of creating a new policy. Both these 2 flag are meaningless if you run sosreport -a -o engine because -a set both the flags to True and because running sosreport you can't collect hypervisors sosreport in vdsmlogs and you want a standard sosreport. I've refactored the engine sos plugin removing both the flags. It's engine-log-collector that will take care to rename the tarball with the desired prefix and it's engine-log-collector that will take care of adding the vdsmlogs to the archive. PREVIOUS: - collect and archive postgres data in a scratch dir - collect and archive hypervisors data in a scratch dir - collect and archive engine data (including the above in /tmp) NOW: - collect engine data - collect and archive postgres data in log-collector-data - collect and archive hypervisors data in log-collector-data - archive all the above in a single tarball. Change-Id: Ib226ec23b98450a03ebd2a64043a911645a62235 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py M src/sos/plugins/engine.py 2 files changed, 71 insertions(+), 50 deletions(-) Approvals: Sandro Bonazzola: Verified Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13939 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib226ec23b98450a03ebd2a64043a911645a62235 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: [cleanup] extract building parameters code from execut...
by ofrenkel＠redhat.com 17 Apr '13

17 Apr '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: [cleanup] extract building parameters code from execute methods ...................................................................... core: [cleanup] extract building parameters code from execute methods Extract the sections that build parameters for internal commands from the execute methods of CreateAllSnapshotsFromVmCommand, RemoveAllVmImagesCommand and RemoveDiskCommand. that way, the execute methods are shorter and more readable. Change-Id: Iedcdcefe63c75927ed709faa9c1a64c5e983bc12 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java 3 files changed, 42 insertions(+), 35 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iedcdcefe63c75927ed709faa9c1a64c5e983bc12 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix single sign on for all guests
by ofrenkel＠redhat.com 17 Apr '13

17 Apr '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix single sign on for all guests ...................................................................... core: fix single sign on for all guests This patch fix a problem that caused single-sign-on capability not to work for some guests: vdsm sends the name of the guest agent application in the applications list. the engine expects to receive RHEV-Agent as the guest agent application name, but that's true only for guest agent running on Windows and in d/s version. This solution is: 1. set all the possible names for the guest agent application, on all operating systems, in the configuration so that the engine will look for all of them (instead of only RHEV-Agent). 2. set the relevant names of the guest agent application in u/s, in ovirt's engine configuration. Change-Id: If256ddda586eb53af0ca55d6b97dd98e10139d8a Bug-Url: https://bugzilla.redhat.com/922398 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java 3 files changed, 13 insertions(+), 12 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If256ddda586eb53af0ca55d6b97dd98e10139d8a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Fixing update of host status during restart host
by mkublin＠redhat.com 17 Apr '13

17 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Fixing update of host status during restart host ...................................................................... engine: Fixing update of host status during restart host If we failed during restart a host status should be switched to NonResponsive, the status was switched at roollback() nethod, but because of command is NonTransactive a rollback will be never called, so moving an update of status to execute Change-Id: I1d44a3ee76e2dc2490f8cf937a768c80826af46c Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsCommand.java 1 file changed, 7 insertions(+), 11 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13895 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d44a3ee76e2dc2490f8cf937a768c80826af46c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: Switching spice invoker implementation in console ...
by tjelinek＠redhat.com 17 Apr '13

17 Apr '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Switching spice invoker implementation in console dialog ...................................................................... frontend: Switching spice invoker implementation in console dialog This patch allows switching spice invoker implementation in console dialog. Change-Id: Ib9fdc00931e3b25858b792b47339b3c5ab4a954c Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ConsolePopupPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleOptionsFrontendPersisterImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleUtilsImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ConsolePopupView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ConsolePopupView.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ConsoleUtils.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java 8 files changed, 195 insertions(+), 16 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13953 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9fdc00931e3b25858b792b47339b3c5ab4a954c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0