April 2013 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: core: clarify conditional expression in checkImageValidity

by lhornyak＠redhat.com

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: clarify conditional expression in checkImageValidity ...................................................................... core: clarify conditional expression in checkImageValidity Add indentation and parenthesis to improve readability. Change-Id: Ib82b97eb4670faa8ff456028fc89d23c6c2c79c2 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9089 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib82b97eb4670faa8ff456028fc89d23c6c2c79c2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

11 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: core: prevent performing preview when the vm has illegal dis...

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: prevent performing preview when the vm has illegal disks ...................................................................... core: prevent performing preview when the vm has illegal disks When attempting to preview vm - do not allow to perform it when the vm has illegal disks contained within the filtered disk list. Change-Id: I8ee0e8070fb91bd2e0f18cf7bdb7a44aa51f70af Bug-Url: https://bugzilla.redhat.com/949624 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java 1 file changed, 10 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13896 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ee0e8070fb91bd2e0f18cf7bdb7a44aa51f70af Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

11 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: userportal, weadmin: fix root pom

by ecohen＠redhat.com

Einav Cohen has submitted this change and it was merged. Change subject: userportal, weadmin: fix root pom ...................................................................... userportal, weadmin: fix root pom - fixed backend root pom, by removed extra dependency that is not needed as commons-logging is properly included already. Change-Id: I2ca63b5346266ac0c15e385787adb881586fd029 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/root/pom.xml 1 file changed, 0 insertions(+), 11 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13932 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ca63b5346266ac0c15e385787adb881586fd029 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

11 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: core: VdsDAO.getAllWithName now returns instance

by lhornyak＠redhat.com

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: VdsDAO.getAllWithName now returns instance ...................................................................... core: VdsDAO.getAllWithName now returns instance List<VDS> VdsDAO.getAllWithName(String) has been changed to VDS VdsDAO.getByName(String) because VDS name is unique Change-Id: I1a0cb37c98f1a4373028e6210e45261cd432eed3 Bug-Url: https://bugzilla.redhat.com/894382 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsByNameQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVdsCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDAOTest.java 8 files changed, 45 insertions(+), 58 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13827 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a0cb37c98f1a4373028e6210e45261cd432eed3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

11 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: fix volume labels in ja and fr locale

by kmayilsa＠redhat.com

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: fix volume labels in ja and fr locale ...................................................................... webadmin: fix volume labels in ja and fr locale Increased the width of Gluster Volume column in events tab to avoid striping the label in ja locale. Increased the height of the create volume dialog to avoid the text overflowing in fr locale. Bug-Url: https://bugzilla.redhat.com/950302 Change-Id: I6c831be1d3339bc293e1af46b1af2ead5de8ab6c Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumePopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabEventView.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13919 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c831be1d3339bc293e1af46b1af2ead5de8ab6c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

11 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Remove unused manifest from root webapp

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: core: Remove unused manifest from root webapp ...................................................................... core: Remove unused manifest from root webapp The file src/resources/META-INF/MANIFEST.MF is not used, it is the result of a mistake. Change-Id: Ifbf46b718956b45029ab2c0479509688f82291f6 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- D backend/manager/modules/root/src/resources/META-INF/MANIFEST.MF 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13910 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbf46b718956b45029ab2c0479509688f82291f6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

11 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: move new disk logic to NewDiskModel

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: move new disk logic to NewDiskModel ...................................................................... webadmin: move new disk logic to NewDiskModel Move logic relevant only for new disk from AbstractDiskModel to NewDiskModel. Change-Id: If6bd49b1c513eb06d33a765738d5fd2587a88b13 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java 3 files changed, 21 insertions(+), 10 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6bd49b1c513eb06d33a765738d5fd2587a88b13 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

11 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: core:we are fencing a host when putting it in...

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: core:we are fencing a host when putting it in... ...................................................................... core:we are fencing a host when putting it in... we are fencing a host when putting it in maintenance after failed reinstall. There are two commands that handle Host Maintenance 1) MaintenanceVdsCommand 2) MaintenanceNumberOfVdssCommand In 1) there is handling in canDoAction that prevents the operation for InstalledFailed status while this handling is omitted from 2) I would expect that 2) will contain all validation checks done by 1) and the best will be that they will call the same validation code. but this is not the case right now. To keep my change minimal and risk-less, I will have to copy the relevant validation block from 1) code to 2) Change-Id: I1ed67cb14b31597d147cee3a64056e3486f51d26 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=906389 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java 1 file changed, 40 insertions(+), 30 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13746 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ed67cb14b31597d147cee3a64056e3486f51d26 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

11 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Use proper method to mark net changes as saved

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: engine: Use proper method to mark net changes as saved ...................................................................... engine: Use proper method to mark net changes as saved The patch reduces the need for updating the entire VdsDynamic data by using a designated method for saving the dirty-network indicator of the host. Change-Id: Ib4c54214a275a1653c46bca7c95ff847975dd7d4 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/CommitNetworkChangesCommand.java 1 file changed, 3 insertions(+), 7 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/13905 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4c54214a275a1653c46bca7c95ff847975dd7d4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

11 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Refactoring gluster hook labels

by kmayilsa＠redhat.com

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: Refactoring gluster hook labels ...................................................................... webadmin: Refactoring gluster hook labels Gluster hook command label is changed to 'Volume Event' and unused constants are removed. Change-Id: Ieed8b5176d484e49fe507bf3f1460447c5a9179e Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGlusterHookView.java 2 files changed, 3 insertions(+), 6 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13833 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieed8b5176d484e49fe507bf3f1460447c5a9179e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

11 years, 8 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits April 2013