April 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Convert TicketingTest to JUnit4 syntax
by amureini＠redhat.com 13 Apr '13

13 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Convert TicketingTest to JUnit4 syntax ...................................................................... core: Convert TicketingTest to JUnit4 syntax Change-Id: I4fcf3a2b80abe94a4357a9aa10e801212d8e6f4f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/TicketingTest.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13859 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4fcf3a2b80abe94a4357a9aa10e801212d8e6f4f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Convert FileUtilTest to JUnit4 syntax
by amureini＠redhat.com 13 Apr '13

13 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Convert FileUtilTest to JUnit4 syntax ...................................................................... core: Convert FileUtilTest to JUnit4 syntax Change-Id: I18fd9f0fa1ade26c732eaf84013427eccfdfb800 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/FileUtilTest.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18fd9f0fa1ade26c732eaf84013427eccfdfb800 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Convert ErrorTranslatorTest to JUnit4 syntax
by amureini＠redhat.com 13 Apr '13

13 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Convert ErrorTranslatorTest to JUnit4 syntax ...................................................................... core: Convert ErrorTranslatorTest to JUnit4 syntax Change-Id: I072de540ba81f6ac79edeaf5657ffdb4fc1cdf79 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ErrorTranslatorTest.java 1 file changed, 13 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13857 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I072de540ba81f6ac79edeaf5657ffdb4fc1cdf79 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix modifiers in ErrorTranslatorTest
by amureini＠redhat.com 13 Apr '13

13 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix modifiers in ErrorTranslatorTest ...................................................................... core: Fix modifiers in ErrorTranslatorTest Added missing static modifiers as pee Eclipse IDE warnings. Change-Id: Ie5ebb48b2be333b1cd85e9770a233b1bae67a1fc Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ErrorTranslatorTest.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13856 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5ebb48b2be333b1cd85e9770a233b1bae67a1fc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Convert TimeSpanTest to JUnit4 syntax
by amureini＠redhat.com 13 Apr '13

13 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Convert TimeSpanTest to JUnit4 syntax ...................................................................... core: Convert TimeSpanTest to JUnit4 syntax Change-Id: I5c8660975a1f0500fe2fc455330c0f2198d54cc5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/TimeSpanTest.java 1 file changed, 12 insertions(+), 8 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13855 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c8660975a1f0500fe2fc455330c0f2198d54cc5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: corei: Remove prints from TimeSpanTest
by amureini＠redhat.com 13 Apr '13

13 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: corei: Remove prints from TimeSpanTest ...................................................................... corei: Remove prints from TimeSpanTest Removed useless class to System.out.println() from TimeSpanTest. Change-Id: I343ae713822fffdc74708f6502f579a4eb8b3cca Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/TimeSpanTest.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13854 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I343ae713822fffdc74708f6502f579a4eb8b3cca Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: use JUnit 4 syntax in RegexTest
by amureini＠redhat.com 13 Apr '13

13 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: use JUnit 4 syntax in RegexTest ...................................................................... core: use JUnit 4 syntax in RegexTest Change-Id: I4633091a1b929af23fea333f2a1fa661b83bc575 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/RegexTest.java 1 file changed, 12 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13853 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4633091a1b929af23fea333f2a1fa661b83bc575 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove XmlRpcUtilsTest
by amureini＠redhat.com 13 Apr '13

13 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove XmlRpcUtilsTest ...................................................................... core: Remove XmlRpcUtilsTest Removed XmlRpcUtilsTest, as it had no usable code anyway - it was a component test, not a unit test, and was all commented out anyway. Change-Id: I59c21980fecdfed3bf6e98b1cbbbd3d483032512 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtilsTest.java 1 file changed, 0 insertions(+), 24 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13852 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59c21980fecdfed3bf6e98b1cbbbd3d483032512 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Cross-window communication support for UI plugins
by vszocs＠redhat.com 12 Apr '13

12 Apr '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Cross-window communication support for UI plugins ...................................................................... webadmin: Cross-window communication support for UI plugins This patch introduces support for cross-window (cross-origin) communication that can be utilized by UI plugins, i.e. custom content (contributed by UI plugin) talks back to UI plugin code via WebAdmin (parent) window. This enables custom content to pass arbitrary messages back to given UI plugin(s) which might, or might not, react to them. The implementation is based on HTML5 window.postMessage API that triggers 'message' events on the target (i.e. WebAdmin parent) window. WebAdmin takes care of intercepting such messages, doing allowed source origin checks, and passing message data to UI plugins as appropriate. Sample UI plugin code: <snip> var api = parent.pluginApi('showcase'); // New function - define custom API options api.options({ // Can be either a string (single origin) // or a string array (multiple origins) // "*" means "any origin", as per HTML5 spec allowedMessageOrigins: 'http://nicedomain:8080' }); api.register({ UiInit: function() { // Assuming dialog content sends message via: // parent.postMessage(message, targetOrigin) api.showDialog(...); }, // New event handler function MessageReceived: function(data, sourceWindow) { // Source origin check already passed here window.alert('MessageReceived: ' + data); } }); api.ready(); </snip> Aside from message processing, 'sourceWindow' can be used to establish two-way communication between custom content window and UI plugin code. This patch also includes smaller (general) improvements. Change-Id: I8a159bed88e0709b54a31f0959fb08b6cdf508cb Bug-Url: https://bugzilla.redhat.com/895103 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/SystemModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/Plugin.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginEventHandler.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginManager.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/ApiOptions.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/jsni/JsArrayHelper.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/jsni/JsObjectWithProperties.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/MessageEventData.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/MessageReceived.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/PostMessageDispatcher.java 10 files changed, 341 insertions(+), 27 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13794 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a159bed88e0709b54a31f0959fb08b6cdf508cb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Chris Morrissey <cmorriss(a)netapp.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove GetStorageServerConnectionsQuery
by amureini＠redhat.com 12 Apr '13

12 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove GetStorageServerConnectionsQuery ...................................................................... core: Remove GetStorageServerConnectionsQuery GetStorageServerConnectionsQuery is not used anywhere in the code, and hence should be removed. This patch removes the following: 1. The GetStorageServerConnectionsQuery class 2. The GetStorageServerConnections constant representing it in VdcQueryType 3. The getAll() method in StorageServerConnectionsDAO (which was only used by the query), its implementation, and its test. 4. The GetAllFromstoage_server_connections stored procedure that was only used by the said DAO function. Note that the test for StorageServerConnectionsDao.get(Guid) is slightly redone so it no longer depends on getAll()'s implementation. Change-Id: I352f819dd3a7b272ccf1b39cfcf76cca62a8ee10 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/dbscripts/storages_san_sp.sql D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetStorageServerConnectionsQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageServerConnectionDAOTest.java 6 files changed, 5 insertions(+), 62 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13228 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I352f819dd3a7b272ccf1b39cfcf76cca62a8ee10 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0