April 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Created class hierarchy for bond popups
by alkaplan＠redhat.com 11 Apr '13

11 Apr '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Created class hierarchy for bond popups ...................................................................... webadmin: Created class hierarchy for bond popups Created a class hierarchy for bond popup windows to replace the "compact mode" boolean parameter mechanism. This to enable better control over which windows enable creating new bonds from the engine in following patches. Change-Id: Ib9f4de41a5d298bf922e9ad7fee64ee2b62c3700 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostBondInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksAddBondModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksBondModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksEditBondModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/HostModule.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/host/SetupNetworksBondPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostBondPopupView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksBondPopupView.java 10 files changed, 142 insertions(+), 87 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13678 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9f4de41a5d298bf922e9ad7fee64ee2b62c3700 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: fixing edit policy button style
by ecohen＠redhat.com 11 Apr '13

11 Apr '13

Einav Cohen has submitted this change and it was merged. Change subject: webadmin: fixing edit policy button style ...................................................................... webadmin: fixing edit policy button style In other locales the button text overflow. Fixed alignment (margin) and removed button's width. Change-Id: Ibfe84279c19fb9b8824acc8fb3d082c131f5083c Bug-Url: https://bugzilla.redhat.com/921892 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterPolicyView.ui.xml 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibfe84279c19fb9b8824acc8fb3d082c131f5083c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: 'for min' label width is too short
by ecohen＠redhat.com 11 Apr '13

11 Apr '13

Einav Cohen has submitted this change and it was merged. Change subject: webadmin: 'for min' label width is too short ...................................................................... webadmin: 'for min' label width is too short In cluster policy view. Causing line to break in other locales. removed width style. Change-Id: I5cfcdf53b068859c38a4ad00135383c63ddfe303 Bug-Url: https://bugzilla.redhat.com/921901 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13193 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5cfcdf53b068859c38a4ad00135383c63ddfe303 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: display address override message
by tjelinek＠redhat.com 11 Apr '13

11 Apr '13

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: display address override message ...................................................................... webadmin: display address override message The patch 63867923f1d80fc2527cc78cb3a3dd92b0eff9a6 added possibility to configure the console address of a host but did not add a validation message to all the required places. Change-Id: I5b292c74a7b02796cc780dcebd3c2b66e643d306 Bug-Url: https://bugzilla.redhat.com/928298 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 7 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b292c74a7b02796cc780dcebd3c2b66e643d306 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove IsVdsGroupWithSameNameExist
by lhornyak＠redhat.com 11 Apr '13

11 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Remove IsVdsGroupWithSameNameExist ...................................................................... core: Remove IsVdsGroupWithSameNameExist IsVdsGroupWithSameNameExistQuery is not used anywhere in the code, and hence should be removed. This patch removes the following: 1. The IsVdsGroupWithSameNameExistQuery class 2. The IsVdsGroupWithSameNameExist constant representing it in VdcQueryType 3. The IsVdsGroupWithSameNameExistParameters class which was only used by the removed query class. Change-Id: I45467851d4f11b3f94496974cf6665c7206daeb5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsVdsGroupWithSameNameExistQuery.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IsVdsGroupWithSameNameExistParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 3 files changed, 0 insertions(+), 36 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45467851d4f11b3f94496974cf6665c7206daeb5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: update httpd conf on engine-upgrade
by juan.hernandez＠redhat.com 11 Apr '13

11 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: update httpd conf on engine-upgrade ...................................................................... packaging: update httpd conf on engine-upgrade If /etc/httpd/conf.d/ovirt-engine.conf exists, the httpd configuration will be updated creating: - /etc/httpd/conf.d/proxy_ovirt-engine.conf - /etc/httpd/conf.d/ovirt-engine-root-redirect.conf It will configure mod_deflate also on upgrade and not only on install. Change-Id: I73175ef2acc9cf88261eb7df4f17602085151b1c Bug-Url: https://bugzilla.redhat.com/948783 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/engine-upgrade.py 2 files changed, 31 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73175ef2acc9cf88261eb7df4f17602085151b1c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove IsVdsWithSameIpExistsQurey
by lhornyak＠redhat.com 11 Apr '13

11 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Remove IsVdsWithSameIpExistsQurey ...................................................................... core: Remove IsVdsWithSameIpExistsQurey This patch removes the unused IsVdsWithSameIpExistQuery. Removed in this patch: 1. The IsVdsWithSameIpExistQuery class. 2. The IsVdsWithSameIpExistParameters class only used by the aforementioned query. 3. The IsVdsWithSameIpExist constant from VdcQueryType corresponding to the aforementioned query. 4. The isVdsWithSameIpExists and isVdsWithSameIpExsitsStatic methods in VdsHandler which are no longer in use. Change-Id: Ife14c2758c8f46b244a32ac67747aecbf9d799b4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsVdsWithSameIpExistsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IsVdsWithSameIpExistsParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 4 files changed, 0 insertions(+), 44 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Michael Kublin: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife14c2758c8f46b244a32ac67747aecbf9d799b4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove IsVdsWithSameHostExistsQurey
by lhornyak＠redhat.com 11 Apr '13

11 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Remove IsVdsWithSameHostExistsQurey ...................................................................... core: Remove IsVdsWithSameHostExistsQurey This patch removes the unused IsVdsWithSameHostExistQuery. Removed in this patch: 1. The IsVdsWithSameHostExistQuery class. 2. The IsVdsWithSameHostExistParameters class only used by the aforementioned query. 3. The IsVdsWithSameHostExist constant from VdcQueryType corresponding to the aforementioned query. 4. The isVdsWithSameHostExists and isVdsWithSameHostExsitsStatic methods in VdsHandler which are no longer in use. Change-Id: If6387786899342cf1c9e242aded0ee56053604bc Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsVdsWithSameHostExistQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IsVdsWithSameHostExistParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 4 files changed, 0 insertions(+), 42 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13590 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6387786899342cf1c9e242aded0ee56053604bc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Guard against premature CommonModel nullification
by vszocs＠redhat.com 10 Apr '13

10 Apr '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Guard against premature CommonModel nullification ...................................................................... webadmin: Guard against premature CommonModel nullification This patch ensures that CommonModel instance gets nullified via deferred command, only after current UiCommon-related processing is over. In case some SyncSearch response callback still executes after that, "getModel() != null" condition in DataBoundTabModelProvider should guard against potential NullPointerExceptions. This patch also removes "CommonModel != null" assertions from UiCommonModelResolver, since it's possible for CommonModel reference to be null in some edge-case scenarios (i.e. SyncSearch response callback being executed after user signs out). Change-Id: I2bf55e75d97006d230bf503fac026722321435d0 Bug-Url: https://bugzilla.redhat.com/924670 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/CommonModelManager.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/DataBoundTabModelProvider.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/UiCommonModelResolver.java 3 files changed, 20 insertions(+), 7 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2bf55e75d97006d230bf503fac026722321435d0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: db: add missing vdc_option for 3.3
by gchaplik＠redhat.com 10 Apr '13

10 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: db: add missing vdc_option for 3.3 ...................................................................... db: add missing vdc_option for 3.3 also removed a single 2.2 property that left behind (SupportForceExtendVG) Change-Id: I12406fd340b778cb2160ec063d68c4f3c5a42518 Bug-Url: https://bugzilla.redhat.com/924201 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 28 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13748 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12406fd340b778cb2160ec063d68c4f3c5a42518 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0