April 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: less intrusive method for httpd integration
by juan.hernandez＠redhat.com 09 Apr '13

09 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: less intrusive method for httpd integration ...................................................................... packaging: less intrusive method for httpd integration CURRENT IMPLEMENTATION ovirt-engine proxy all requests, disallow any additional application to be hosted on the same web server. NEW IMPLEMENTATION proxy only ovirt-engine URI prefixes. By default ovirt-engine is at: http://host/ovirt-engine Optionally add redirect from / to /ovirt-engine during setup. SIDE EFFECTS In order to handle redirects of 404.html, we require some valid URI to redirect into, as a result the welcome page of root will not be index.html but ovirt-engine.html, same for style.css which was renamed to ovirt-engine-style.css Change-Id: I89a47a99e28de0905183dc502cb0b35c80f77e6d Signed-off-by: Alex Lourie <alourie(a)redhat.com> Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M backend/manager/modules/root/src/main/webapp/404.html M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml R backend/manager/modules/root/src/main/webapp/ovirt-engine-style.css R backend/manager/modules/root/src/main/webapp/ovirt-engine.html M frontend/webadmin/modules/userportal-gwtp/src/main/webapp/404.html M frontend/webadmin/modules/webadmin/src/main/webapp/404.html M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/engine-cleanup.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/engine_validators.py M packaging/fedora/setup/output_messages.py M packaging/fedora/setup/ovirt-engine-proxy.conf.in A packaging/fedora/setup/ovirt-engine-root-redirect.conf.in 14 files changed, 127 insertions(+), 43 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13318 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89a47a99e28de0905183dc502cb0b35c80f77e6d Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: fix of I33d8e4b4
by tjelinek＠redhat.com 09 Apr '13

09 Apr '13

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: fix of I33d8e4b4 ...................................................................... userportal: fix of I33d8e4b4 this patch fixes broken build caused by I33d8e4b4. Change-Id: I69558a8e6482b654fb87a70fec3879bcb2ac3169 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/utils/ConnectAutomaticallyManager.java 1 file changed, 2 insertions(+), 7 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/13734 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69558a8e6482b654fb87a70fec3879bcb2ac3169 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: use simplified template when handling ovirt-engin...
by juan.hernandez＠redhat.com 09 Apr '13

09 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: use simplified template when handling ovirt-engine-proxy.conf.in ...................................................................... packaging: use simplified template when handling ovirt-engine-proxy.conf.in Change-Id: I7031884c602e2bd5dfffb34b42e5925cf2f39afa Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/ovirt-engine-proxy.conf.in 3 files changed, 10 insertions(+), 21 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13313 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7031884c602e2bd5dfffb34b42e5925cf2f39afa Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-service: clean /var/tmp in upgrade and cle...
by juan.hernandez＠redhat.com 09 Apr '13

09 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-service: clean /var/tmp in upgrade and cleanup ...................................................................... packaging: engine-service: clean /var/tmp in upgrade and cleanup previous service implementation used mixed ownership of root/ovirt in /var/tmp/ovirt-engine, /var/lib/ovirt-engine/deployments. the /var/tmp/ovirt-engine was not cleared if daemon exited so likely to remain. new service implementation does not run under root account, so having root owned resources is not healthy. during upgrade setup correct setting, during setup remove leftovers, as engine-cleanup not to be trusted as it does not actually revert to initial state. Change-Id: If0efa0b8a71673140490e2c363af7d3ba6044ffe Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/engine-upgrade.py M packaging/fedora/setup/output_messages.py 4 files changed, 27 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13663 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0efa0b8a71673140490e2c363af7d3ba6044ffe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: remove unused dos2unix
by juan.hernandez＠redhat.com 09 Apr '13

09 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: remove unused dos2unix ...................................................................... packaging: remove unused dos2unix Change-Id: If6f3e9728d1b578dae1224a9b165fee13f6cc029 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/spec/ovirt-engine.spec.in 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6f3e9728d1b578dae1224a9b165fee13f6cc029 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup plugins should not be executable
by juan.hernandez＠redhat.com 09 Apr '13

09 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: setup plugins should not be executable ...................................................................... packaging: setup plugins should not be executable Change-Id: I4d92a3af2d071780a8ec9f19e4c6e7debf6074d0 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13575 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d92a3af2d071780a8ec9f19e4c6e7debf6074d0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: build: support subst more than once in line
by juan.hernandez＠redhat.com 09 Apr '13

09 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: build: support subst more than once in line ...................................................................... packaging: build: support subst more than once in line Change-Id: Ie91ea6bb2765825c022ba699ddf1d7660298265f Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile 1 file changed, 16 insertions(+), 16 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13630 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie91ea6bb2765825c022ba699ddf1d7660298265f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: renamed ImageType to ImageFileType
by ofrenkel＠redhat.com 09 Apr '13

09 Apr '13

Omer Frenkel has submitted this change and it was merged. Change subject: engine: renamed ImageType to ImageFileType ...................................................................... engine: renamed ImageType to ImageFileType Renamed, because the ImageType conflicts with the upcomning Instance Type feature, where there will be this entities: ImageType InstanceType TemplateType Change-Id: I5e72e98776631755e5c0296fa5c255118fb39a54 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetImagesListByStoragePoolIdQueryTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ImageFileType.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ImageType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/RepoFileMetaData.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetImagesListByStoragePoolIdParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetImagesListParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetImagesListParametersBase.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RepoFileMetaDataDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RepoFileMetaDataDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RepoFileMetaDataDAOTest.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendFilesResource.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java 18 files changed, 114 insertions(+), 114 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13725 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e72e98776631755e5c0296fa5c255118fb39a54 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: Auto-Connect to RDP on Win 8 and Win 2012-64bit
by tjelinek＠redhat.com 09 Apr '13

09 Apr '13

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: Auto-Connect to RDP on Win 8 and Win 2012-64bit ...................................................................... userportal: Auto-Connect to RDP on Win 8 and Win 2012-64bit Connect automatically doesn't take in effect that for Windows 8/2012 RDP is default. Steps to Reproduce: 1. Windows 8/2012 VM for user in the UP 2. Connect with auto-connect enabled from the login screen Spice console appears instead of RDP one. (As there is performance issue with unaccelerated SPICE console, RDP was agreed to be default for Windows 8/2012. So make auto-connect to check this correctly.) Fixed by utilizing ConsoleUtils and ConsoleManager classes which are used for connecting to console in regular use case. These classes take into account that spice is unsupported on the mentioned platforms. Change-Id: I33d8e4b4701f25bb64a7410512f17c266f872a86 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=918605 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/utils/ConnectAutomaticallyManager.java 3 files changed, 18 insertions(+), 6 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/13218 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33d8e4b4701f25bb64a7410512f17c266f872a86 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: English locale to en_US
by ecohen＠redhat.com 08 Apr '13

08 Apr '13

Einav Cohen has submitted this change and it was merged. Change subject: userportal, webadmin: English locale to en_US ...................................................................... userportal, webadmin: English locale to en_US - Changed the English locale to be en_US to match the location pointed to by the documentation. Change-Id: I8fb5ac34f0e587b533c09bf26c24dcba81e9b41f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=947176 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/UserPortal.gwt.xml M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/WebAdmin.gwt.xml 4 files changed, 7 insertions(+), 7 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13703 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8fb5ac34f0e587b533c09bf26c24dcba81e9b41f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0