Change in ovirt-engine[master]: core: PRD32 - RFE: Multi-Tier fencing in RHEV-M
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: PRD32 - RFE: Multi-Tier fencing in RHEV-M
......................................................................
core: PRD32 - RFE: Multi-Tier fencing in RHEV-M
1) Removing the status check in the canDoAction such that for sequential
multiple agents secondary agent will still be used even tough the
primary agent is not reachable.
Also added an Alert in case that a primary agent failed to function and
a secondary agent is used in the case of sequential multiple agents.
Change-Id: Ieb5a3a8edeb58f74f0e74d3e54911f0cdb614762
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=773108
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
5 files changed, 12 insertions(+), 14 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13698
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb5a3a8edeb58f74f0e74d3e54911f0cdb614762
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: core: clean RemoveStorageDomainCommand
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: clean RemoveStorageDomainCommand
......................................................................
core: clean RemoveStorageDomainCommand
Renamed connect/disconnect methods to start with lowercase
(java convention) and remove unused methods.
Change-Id: I2d15ce79acf17ed05108fdd7a4f00aa6470be3ad
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java
1 file changed, 4 insertions(+), 12 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13683
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2d15ce79acf17ed05108fdd7a4f00aa6470be3ad
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: webadmin: DLS in DragDropEventBase.getData
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: webadmin: DLS in DragDropEventBase.getData
......................................................................
webadmin: DLS in DragDropEventBase.getData
Removed the DLs regarding the dataTransfer in said
method.
Change-Id: I9c93490d018bf1cba5b78f096cf78e9ab2fcd346
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/com/google/gwt/event/dom/client/DragDropEventBase.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13652
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9c93490d018bf1cba5b78f096cf78e9ab2fcd346
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: tools: DLS in MangeDomains.getConfiguration()
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: tools: DLS in MangeDomains.getConfiguration()
......................................................................
tools: DLS in MangeDomains.getConfiguration()
Removed the DLs regarding the currentAuthorizationMethod in said
method.
Change-Id: If20c91e0af26154cab1b469a6240e3c79d20c400
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13651
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If20c91e0af26154cab1b469a6240e3c79d20c400
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: core: Remove LdapSeachGroupsByQuery.initFromDb
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove LdapSeachGroupsByQuery.initFromDb
......................................................................
core: Remove LdapSeachGroupsByQuery.initFromDb
Removed LdapSeachGroupByQueryCommand.initFromDb, since all it did was
query an LdapGroup and save it into a local variable that was never used
again.
Note that this patch solves a DLS_DEAD_LOCAL_STORE FindBugs warning on
this class.
Change-Id: I581fab9aa581a3a5093f98cc48edeaffc9080c44
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapSearchGroupsByQueryCommand.java
1 file changed, 0 insertions(+), 6 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13649
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I581fab9aa581a3a5093f98cc48edeaffc9080c44
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: core: Locate data source in a loop
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Locate data source in a loop
......................................................................
core: Locate data source in a loop
The deployment of the data source usually finishes before the
application is started, but in some situations, for example with slow
DNS, it can finish after the application has started, thus we can't
assume that it has already been deployed.
Change-Id: I72c99c61d05e8a1619c7d1fb70af956d1050eb3a
Bug-Url: https://bugzilla.redhat.com/879904
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacadeLocator.java
1 file changed, 141 insertions(+), 33 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10189
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I72c99c61d05e8a1619c7d1fb70af956d1050eb3a
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: core : AddVmFromSnapshot - use device information from snaps...
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core : AddVmFromSnapshot - use device information from snapshot.
......................................................................
core : AddVmFromSnapshot - use device information from snapshot.
When adding a vm from snapshot (clone of a snapshot), the device
information was taken from the vm current state and not from the
snapshot configuration - which caused the cloned vm to not be in the
desired state and possibly have missing devices.
Change-Id: I0611bbbef00fd2c2390ead5f3110e56dcaacd579
BUg-Url: https://bugzilla.redhat.com/show_bug.cgi?id=882644
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
2 files changed, 25 insertions(+), 20 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12452
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0611bbbef00fd2c2390ead5f3110e56dcaacd579
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov(a)gmail.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: packaging: move java compatiblity symlink where it can be cr...
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: move java compatiblity symlink where it can be created
......................................................................
packaging: move java compatiblity symlink where it can be created
Change-Id: I5f25123f492b78aa1f2a311c053aca12ec86c4bd
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/fedora/spec/ovirt-engine.spec.in
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13700
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5f25123f492b78aa1f2a311c053aca12ec86c4bd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years, 8 months
Change in ovirt-log-collector[ovirt-log-collector-3.2]: tools: added rpm to hypervisors sosreport
by knesenko@redhat.com
Kiril Nesenko has submitted this change and it was merged.
Change subject: tools: added rpm to hypervisors sosreport
......................................................................
tools: added rpm to hypervisors sosreport
Provides information about rpms installed on hypervisors.
(cherry picked from commit cd611d1555d206bf89ed78ea91d8145ea677fc4f)
Change-Id: I57bc036b3a13f44be14d194555a448f9005b9e78
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/__main__.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, but someone else must approve
Kiril Nesenko: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13697
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I57bc036b3a13f44be14d194555a448f9005b9e78
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-3.2
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: core: OvfReader - set IsManaged to true for managed devices
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: OvfReader - set IsManaged to true for managed devices
......................................................................
core: OvfReader - set IsManaged to true for managed devices
When reading ovf data, managed devices were added to the managed devices
map - but the isManaged flag wasn't set to true, causing that possibly
wrong data would be persisted/used.
Related to Bug-Url: https://bugzilla.redhat.com/882644
Change-Id: Ifa51f5aa6655b5b9ae6fd1a8c5e0c206fa9630e6
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Maor Lipchuk: Looks good to me, approved
Liron Ar: Verified
--
To view, visit http://gerrit.ovirt.org/13370
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa51f5aa6655b5b9ae6fd1a8c5e0c206fa9630e6
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov(a)gmail.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
11 years, 8 months