April 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin, userportal: error in custom properties sheet
by gchaplik＠redhat.com 09 Apr '13

09 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin,userportal: error in custom properties sheet ...................................................................... webadmin,userportal: error in custom properties sheet Current custom properties sheet doesn't handle cases where there are no properties stored in DB. Extracting the new duplicate code (splitting logic) into AsyncDataProvider Change-Id: Ia939952c367b6416ed90bb295f1485ce4ac63368 Bug-Url: https://bugzilla.redhat.com/924201 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueModel.java 5 files changed, 42 insertions(+), 57 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13304 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia939952c367b6416ed90bb295f1485ce4ac63368 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: cleanup: remove unused Base64 class
by gchaplik＠redhat.com 09 Apr '13

09 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: frontend: cleanup: remove unused Base64 class ...................................................................... frontend: cleanup: remove unused Base64 class Change-Id: Ie3dfa0901b3fd74e8bf35238f5734b1ce5bb61b1 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- D frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/external/Base64.java 1 file changed, 0 insertions(+), 1,043 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13648 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3dfa0901b3fd74e8bf35238f5734b1ce5bb61b1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine : ovirt-node enter installing status when the install...
by mkublin＠redhat.com 09 Apr '13

09 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine : ovirt-node enter installing status when the install fails ...................................................................... engine : ovirt-node enter installing status when the install fails When ovirt-node installation fails because of missing iso file the status of the host is left as Installing. This patch adds VdsDynamic data to compensation context if can do action of InstalllVdsCommand fails. The status is reverted back to the previous status in compensation logic. The error messages are added to the return values CanDoActionMessages so the message can be displayed in cli Change-Id: I2d74e946cb68d2b9dbc11fc5c6bed9f63ba35fe2 Bug-Url: https://bugzilla.redhat.com/947982 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13622 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d74e946cb68d2b9dbc11fc5c6bed9f63ba35fe2 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-image-uploader[ovirt-image-uploader-3.2]: Added logging of insufficient local space
by knesenko＠redhat.com 09 Apr '13

09 Apr '13

Kiril Nesenko has submitted this change and it was merged. Change subject: Added logging of insufficient local space ...................................................................... Added logging of insufficient local space When checking for space availability for decompressing the ovf file in a temporary directory, notify the user and log an error if there isn't enough space. Also fixed the return value of space_test_ovf when tarfile raises an exception and made space_test_ovf a static method. (cherry picked from commit 9d2aae87f00a699391f9290edf15e0b0cb7ce6d4) Change-Id: Id9742144ed5f28399908d2dde116d34d86b3f119 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 16 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13743 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9742144ed5f28399908d2dde116d34d86b3f119 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: ovirt-image-uploader-3.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Java7 Engine build
by amureini＠redhat.com 09 Apr '13

09 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Java7 Engine build ...................................................................... core: Java7 Engine build Since Java 6 is reaching its EOL, it is clear that we should start phasing it out, and move to Java 7 where possible. Note that the current GWT version we're using does NOT support Java 7, so the frontend code and the code it depends on remained in Java 6. This patch introduces the following: 1. Upgrading the maven-compiler-plugin setting to 1.7. 2. Upgrading animal-sniffer to 1.9, and using the official artifact from codehaus, in order to support Java 7 JDK validations. 3. Added a whitelist of com.sun classes used by existing code that would be picked up by the newly updated version of animal-sniffer, which is slightly stricter than the previous one. Note that these are unsupported internal classes of the JDK which should probably not be used externally anyway, and it would be a pretty good idea to remove these usages in future patches. Change-Id: I9ea655ab589b9907184b033ea08cc98d7ee57e63 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/searchbackend/pom.xml M frontend/webadmin/modules/pom.xml M pom.xml 5 files changed, 34 insertions(+), 7 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ea655ab589b9907184b033ea08cc98d7ee57e63 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: AddVmCommand - add all SDs to permList
by derez＠redhat.com 09 Apr '13

09 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: core: AddVmCommand - add all SDs to permList ...................................................................... core: AddVmCommand - add all SDs to permList Adding all target storage domains specified in the parameters to permList (instead of getStorageDomainId() which returns an empty guid since MSD). Change-Id: I7b942af8b5093848922f060c6be44e8a69374634 Bug-Url: https://bugzilla.redhat.com/928399 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b942af8b5093848922f060c6be44e8a69374634 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: UnitVmModel - subscribe GetHostsByClusterId
by derez＠redhat.com 09 Apr '13

09 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: userportal: UnitVmModel - subscribe GetHostsByClusterId ...................................................................... userportal: UnitVmModel - subscribe GetHostsByClusterId Adding VdcQueryType.GetHostsByClusterId to subscribed query types in Frontend (for preventing progress 'blink' on new/edit VM dialog). Change-Id: If500f79ee46638dc2a94a73cf673d8bdbd1d8880 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13676 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If500f79ee46638dc2a94a73cf673d8bdbd1d8880 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: missing call to ProceedProxyReturnValue
by derez＠redhat.com 09 Apr '13

09 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: core: missing call to ProceedProxyReturnValue ...................................................................... core: missing call to ProceedProxyReturnValue Added missing call to ProceedProxyReturnValue in VmReplicateDiskStartVDSCommand and VmReplicateDiskFinishVDSCommand. Change-Id: I4ed1b66173cd7a644fc1b412c4c28010f92f0fa8 Bug-Url: https://bugzilla.redhat.com/923194 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmReplicateDiskFinishVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmReplicateDiskStartVDSCommand.java 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ed1b66173cd7a644fc1b412c4c28010f92f0fa8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: IrsServerWrapper formatting
by amureini＠redhat.com 09 Apr '13

09 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: IrsServerWrapper formatting ...................................................................... core: IrsServerWrapper formatting Used Eclipse's auto-formatting to apply @Override annotations to all the methods of IrsServerWrapper. Change-Id: I92219c5a1a1901951524f7a7666822bb8b8f6f27 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerWrapper.java 1 file changed, 34 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13732 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92219c5a1a1901951524f7a7666822bb8b8f6f27 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Speed up RemoveSnapshotCommandTest
by amureini＠redhat.com 09 Apr '13

09 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Speed up RemoveSnapshotCommandTest ...................................................................... core: Speed up RemoveSnapshotCommandTest Increased the performance of RemoveSnapshotCommandTest by eliminating the use of Mockito Matchers. Change-Id: I4c007059237e0dc4f8631f7e33feff9f41ef2368 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandTest.java 1 file changed, 8 insertions(+), 12 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c007059237e0dc4f8631f7e33feff9f41ef2368 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0