April 2013 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: pki: cleanup: Format string should use %n rather than \n

by yzaslavs＠redhat.com

Yair Zaslavsky has submitted this change and it was merged. Change subject: pki: cleanup: Format string should use %n rather than \n ...................................................................... pki: cleanup: Format string should use %n rather than \n Workaround to quiet findbugs... we do need \n... Change-Id: I82a2346dca472245e6e28ed6f2a76b465685bf98 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/root/src/main/java/org/ovirt/engine/core/pki/PKIResourceServlet.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13513 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82a2346dca472245e6e28ed6f2a76b465685bf98 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

11 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Fixes in non plugin console invocation

by tjelinek＠redhat.com

Tomas Jelinek has submitted this change and it was merged. Change subject: engine: Fixes in non plugin console invocation ...................................................................... engine: Fixes in non plugin console invocation This patch introduces minor fixes in non plugin console invocation mainly related to internet explorer. Changes in backend: - mapping of attachment servlet changed to "console.vv", since IE ignores Attachment header - the filename parameter was removed as it has no effect in IE - no-cache header changed to max-age=0 header. With no-cache header IE fails to download the file if https is used - assume UTF-8 as the encoding of the incoming request in the attachment servlet Changes in frontend: - added spice plugin detection for IE Change-Id: I7fe6fbf274a9ac215e8f6593cc000f778a431928 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M backend/manager/modules/root/src/main/java/org/ovirt/engine/core/GetAttachmentServlet.java M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpicePluginImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ISpicePlugin.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VncConsoleModel.java 8 files changed, 69 insertions(+), 54 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13332 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7fe6fbf274a9ac215e8f6593cc000f778a431928 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

11 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: packaging: engine-service: set default service mode to foreg...

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-service: set default service mode to foreground ...................................................................... packaging: engine-service: set default service mode to foreground this will ease developer when executing the service. Change-Id: Ib7e5ffe4e104d2c3a0c931f3f344f7c3c12eb57f Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/engine-service.py.in M packaging/fedora/engine-service.systemd.in M packaging/fedora/engine-service.sysv.in 3 files changed, 6 insertions(+), 6 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13497 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7e5ffe4e104d2c3a0c931f3f344f7c3c12eb57f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

11 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: packaging: engine-service: remove dead code

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-service: remove dead code ...................................................................... packaging: engine-service: remove dead code Change-Id: Id520a0ff33e797b2995fb217754605c219f6a922 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/engine-service.py.in M packaging/fedora/engine-service.systemd.in M packaging/fedora/engine-service.sysv.in 3 files changed, 10 insertions(+), 173 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13496 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id520a0ff33e797b2995fb217754605c219f6a922 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

11 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: packaging: engine-service: downstream infrastructure usage

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-service: downstream infrastructure usage ...................................................................... packaging: engine-service: downstream infrastructure usage Use features of downstream instead our own implementation. systemd 1. detach from controlling terminal. 2. Change user/group. 3. stop service using signal. 4. set rlimit. sysv 1. Change user/group. 2. stop service by pidfile. 3. set rlimit systemd note: As jboss return non zero error code when receiving SIGTERM, and systemd expect processes to terminate with zero error code, we create a wrapper over the java. Change-Id: Ie02f0d44bbba7d1a7af6bcf6b808610e85b907c6 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M .gitignore M Makefile M backend/manager/conf/engine.conf.defaults.in M packaging/fedora/engine-service.py.in D packaging/fedora/engine-service.systemd A packaging/fedora/engine-service.systemd.in A packaging/fedora/engine-service.sysv.in M packaging/fedora/spec/ovirt-engine.spec.in 8 files changed, 141 insertions(+), 60 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie02f0d44bbba7d1a7af6bcf6b808610e85b907c6 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

11 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: packaging: engine-service: rework start pid file handling

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-service: rework start pid file handling ...................................................................... packaging: engine-service: rework start pid file handling There is no reason to force user to explicit stop and start the service in case pid file contains non running process. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=838527 Change-Id: I8d8a7f8f8b7f5941f447df3d279686b973b5c393 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/engine-service.py.in 1 file changed, 6 insertions(+), 16 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13415 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d8a7f8f8b7f5941f447df3d279686b973b5c393 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

11 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: packaging: engine-service: add options for wrappers

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-service: add options for wrappers ...................................................................... packaging: engine-service: add options for wrappers In order to be used at other environments, with their own init.d layout, Add: --quiet --pidfile --foreground Change-Id: I00d868fc51ec73800cae2eb24002feb933744851 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/engine-service.py.in 1 file changed, 75 insertions(+), 25 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13418 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00d868fc51ec73800cae2eb24002feb933744851 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

11 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: packaging: engine-service: use python daemon instead of own ...

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-service: use python daemon instead of own implementation ...................................................................... packaging: engine-service: use python daemon instead of own implementation Change-Id: I6b533fbdbde47d8fdb62964d60aa22e98c1e57c3 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/engine-service.py.in M packaging/fedora/spec/ovirt-engine.spec.in 2 files changed, 41 insertions(+), 35 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13435 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b533fbdbde47d8fdb62964d60aa22e98c1e57c3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

11 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: packaging: engine-service: allow service user customization

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-service: allow service user customization ...................................................................... packaging: engine-service: allow service user customization Change-Id: Ie71a3a56c77e29aea87b955dc82cd194e88c3582 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M backend/manager/conf/engine.conf.defaults.in M packaging/fedora/spec/ovirt-engine.spec.in 3 files changed, 8 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13485 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie71a3a56c77e29aea87b955dc82cd194e88c3582 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

11 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: packaging: engine-service: remove limits.d file

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-service: remove limits.d file ...................................................................... packaging: engine-service: remove limits.d file the limits.d file is not used as service applies rlimit on its own. Change-Id: I35e00bb4756e590e3c7e463b5d758bbb00de4a43 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile D packaging/fedora/engine-service.limits M packaging/fedora/spec/ovirt-engine.spec.in 3 files changed, 0 insertions(+), 7 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13495 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35e00bb4756e590e3c7e463b5d758bbb00de4a43 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

11 years, 8 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits April 2013