May 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[engine_3.2]: restapi: Added usages option to CLI add cluster network
by mpastern＠redhat.com 23 May '13

23 May '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Added usages option to CLI add cluster network ...................................................................... restapi: Added usages option to CLI add cluster network When adding a network via CLI, in cluster context, added the ability to pass the usages option - same as when updating a network. Change-Id: Id4573674ddd1015eba33a05b95d687f685f707c4 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=949884 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14859 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4573674ddd1015eba33a05b95d687f685f707c4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: gluster: Sync gluster service statuses
by sanjal＠redhat.com 23 May '13

23 May '13

Shireesh Anjal has submitted this change and it was merged. Change subject: gluster: Sync gluster service statuses ...................................................................... gluster: Sync gluster service statuses Periodically fetches the status of gluster related services, and updates the database with new statuses. The existing refresh interval defined in the option GlusterRefreshRateLight is used for scheduling the job. Change-Id: I312cacf698cb3420e30d96c42a92959b257c4abd Signed-off-by: Shireesh Anjal <anjalshireesh(a)gmail.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterJob.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterJobsManager.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterServiceSyncJob.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterServiceSyncJobTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterServiceStatus.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/gluster/GlusterConstants.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/gluster/GlusterFeatureSupported.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/gluster/GlusterAuditLogUtil.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 13 files changed, 844 insertions(+), 2 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14644 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I312cacf698cb3420e30d96c42a92959b257c4abd Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: Non serializable field in serializable class
by shavivi＠redhat.com 23 May '13

23 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: Non serializable field in serializable class ...................................................................... findbugs: Non serializable field in serializable class findbugs: Se: Non-transient non-serializable instance field in serializable class (SE_BAD_FIELD) Change-Id: Idec371438a72574f9a2e74efe8fc67a74bc74efc Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/AsyncTaskCreationInfo.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14968 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idec371438a72574f9a2e74efe8fc67a74bc74efc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: class overrides equals, but does not override hash...
by shavivi＠redhat.com 23 May '13

23 May '13

Hello ovirt-engine-commits, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/14965 to review the following change. Change subject: findbugs: class overrides equals, but does not override hashCode ...................................................................... findbugs: class overrides equals, but does not override hashCode findbugs reason: HE: Class defines equals() and uses Object.hashCode() (HE_EQUALS_USE_HASHCODE) Change-Id: I3e276cc87bdfd68e657a8217207dc2518ab96f34 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java 1 file changed, 51 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/65/14965/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java index 877867c..dc29d81 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java @@ -1214,6 +1214,57 @@ return false; } + @Override + public int hashCode() { + final int prime = 31; + int result = 1; + long temp; + temp = Double.doubleToLongBits(_actualDiskWithSnapthotsSize); + result = prime * result + (int) (temp ^ (temp >>> 32)); + result = prime * result + (balloonEnabled ? 1231 : 1237); + result = prime * result + ((cdPath == null) ? 0 : cdPath.hashCode()); + result = prime * result + ((configured == null) ? 0 : configured.hashCode()); + result = prime * result + ((diskMap == null) ? 0 : diskMap.hashCode()); + temp = Double.doubleToLongBits(diskSize); + result = prime * result + (int) (temp ^ (temp >>> 32)); + result = prime * result + ((floppyPath == null) ? 0 : floppyPath.hashCode()); + result = prime * result + migreatingFromPort; + result = prime * result + migreatingToPort; + result = prime * result + ((privateGuestAgentVersion == null) ? 0 : privateGuestAgentVersion.hashCode()); + result = prime * result + ((runOnVdsName == null) ? 0 : runOnVdsName.hashCode()); + result = prime * result + (runOnce ? 1231 : 1237); + result = prime * result + ((selectionAlgorithm == null) ? 0 : selectionAlgorithm.hashCode()); + result = prime * result + ((snapshots == null) ? 0 : snapshots.hashCode()); + result = prime * result + ((spiceDriverVersion == null) ? 0 : spiceDriverVersion.hashCode()); + result = prime * result + ((storagePoolId == null) ? 0 : storagePoolId.hashCode()); + result = prime * result + ((storagePoolName == null) ? 0 : storagePoolName.hashCode()); + result = prime * result + (transparentHugePages ? 1231 : 1237); + result = prime * result + (useSysPrep ? 1231 : 1237); + result = + prime * result + ((vdsGroupCompatibilityVersion == null) ? 0 : vdsGroupCompatibilityVersion.hashCode()); + result = prime * result + ((vdsGroupCpuFlagsData == null) ? 0 : vdsGroupCpuFlagsData.hashCode()); + result = prime * result + ((vdsGroupCpuName == null) ? 0 : vdsGroupCpuName.hashCode()); + result = prime * result + ((vdsGroupDescription == null) ? 0 : vdsGroupDescription.hashCode()); + result = prime * result + ((vdsGroupName == null) ? 0 : vdsGroupName.hashCode()); + result = prime * result + ((vmDynamic == null) ? 0 : vmDynamic.hashCode()); + result = prime * result + ((vmPayload == null) ? 0 : vmPayload.hashCode()); + result = prime * result + ((vmPoolId == null) ? 0 : vmPoolId.hashCode()); + result = prime * result + ((vmPoolName == null) ? 0 : vmPoolName.hashCode()); + result = prime * result + ((vmStatic == null) ? 0 : vmStatic.hashCode()); + result = prime * result + ((vmStatistics == null) ? 0 : vmStatistics.hashCode()); + result = prime * result + vmtCpuPerSocket; + result = prime * result + ((vmtCreationDate == null) ? 0 : vmtCreationDate.hashCode()); + result = prime * result + ((vmtDescription == null) ? 0 : vmtDescription.hashCode()); + result = prime * result + vmtMemSizeMb; + result = prime * result + ((vmtName == null) ? 0 : vmtName.hashCode()); + result = prime * result + vmtNumOfCpus; + result = prime * result + vmtNumOfSockets; + result = prime * result + ((vmtOs == null) ? 0 : vmtOs.hashCode()); + result = prime * result + ((vmtTimeZone == null) ? 0 : vmtTimeZone.hashCode()); + result = prime * result + vmtchildCount; + return result; + } + public String getVmPoolName() { return vmPoolName; } -- To view, visit http://gerrit.ovirt.org/14965 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3e276cc87bdfd68e657a8217207dc2518ab96f34 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: ovirt-engine-commits <engine-commits(a)ovirt.org>

1 1

Change in ovirt-engine[master]: gluster: Refactored gluster hook command tests
by sanjal＠redhat.com 23 May '13

23 May '13

Shireesh Anjal has submitted this change and it was merged. Change subject: gluster: Refactored gluster hook command tests ...................................................................... gluster: Refactored gluster hook command tests Refactored tests so that it can be reused by all hook related commands. Change-Id: I5fbcdd1858b5910b03dd8e710f4368b7b4d4ceb9 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookStatusChangeCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/DisableGlusterHookCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/EnableGlusterHookCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterHookCommandTest.java 5 files changed, 32 insertions(+), 24 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14921 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5fbcdd1858b5910b03dd8e710f4368b7b4d4ceb9 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Add, remove gluster hooks VDS commands
by sanjal＠redhat.com 23 May '13

23 May '13

Shireesh Anjal has submitted this change and it was merged. Change subject: engine: Add, remove gluster hooks VDS commands ...................................................................... engine: Add, remove gluster hooks VDS commands VDS commands to add and remove gluster hooks. When adding gluster hooks, an argument can be passed whether to enable/disable the hook. Change-Id: I716c1ca642f37e039ab9ea11c1f6dea1741522c0 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterHookVDSParameters.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AddGlusterHookVDSCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/RemoveGlusterHookVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties 12 files changed, 132 insertions(+), 1 deletion(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14738 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I716c1ca642f37e039ab9ea11c1f6dea1741522c0 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <shireesh(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: remove SearchReturnValue
by lhornyak＠redhat.com 23 May '13

23 May '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: remove SearchReturnValue ...................................................................... core: remove SearchReturnValue SearchReturnValue extends VdcQueryReturnValue and adds the boolean isSearchValid. However, this boolean is only set in various flows, and never read, meaning this entire class is useless. This patch does the following: 1. Removes SearchReturnValue 2. Removes QueriesCommandBase.createReturnValue() and replaces it with an inline call to new VdsQueryReturnValue(), since now there is no reason to override it. 3. Removes QueriesCommandBase.proceedOnFail(), since now no class implements it. Change-Id: I39fd1f1fb4bf66e594ea3157bd36959736faa6dc Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/LdapSearchQueryTestBase.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/SearchReturnValue.java 4 files changed, 7 insertions(+), 58 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39fd1f1fb4bf66e594ea3157bd36959736faa6dc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix L literals in VdsUpdateRunTimeInfoTest
by amureini＠redhat.com 23 May '13

23 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix L literals in VdsUpdateRunTimeInfoTest ...................................................................... core: Fix L literals in VdsUpdateRunTimeInfoTest Fixed long literals in VdsUpdateRunTimeInfoTest from using a lower case l to an upper case L to reconcile the checkstyle violation. Change-Id: I2d25beba91b3d1a6c68511a6d46be7236deea61f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfoTest.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Laszlo Hornyak: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/15012 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d25beba91b3d1a6c68511a6d46be7236deea61f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: watchdog - frontend
by dfediuck＠redhat.com 23 May '13

23 May '13

Doron Fediuck has submitted this change and it was merged. Change subject: engine: watchdog - frontend ...................................................................... engine: watchdog - frontend - added watchdog to the high availability tab in the new/edit vm Change-Id: Ie3f72fabf35d32a05a75652ced362c5bee32b8d7 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDesktopNewPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 13 files changed, 234 insertions(+), 12 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13059 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3f72fabf35d32a05a75652ced362c5bee32b8d7 Gerrit-PatchSet: 29 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: watchdog - DB and logic changes
by dfediuck＠redhat.com 23 May '13

23 May '13

Doron Fediuck has submitted this change and it was merged. Change subject: engine: watchdog - DB and logic changes ...................................................................... engine: watchdog - DB and logic changes - DB scripts to add records to the vm record - last_watchdog_event the unix time from the host when the watchdog was triggered - last_watchdog_action the last action taken by the watchdog - Vm and VmDynamic changes - changes in commands - vdsbroker changes Change-Id: I813a6f97e23008d15446285998a4e9b50b456040 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql A backend/manager/dbscripts/upgrade/03_03_0170_watchdog.sql M backend/manager/dbscripts/vms_sp.sql A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractVmWatchdogCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddWatchdogCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetWatchdogQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveWatchdogCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateWatchdogCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetWatchdogQueryTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateWatchdogCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmTemplateParametersBase.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/WatchdogParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmWatchdog.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmWatchdogAction.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmWatchdogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDAODbFacade.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmOldInfoBuilder.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfoTest.java 42 files changed, 851 insertions(+), 16 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13057 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I813a6f97e23008d15446285998a4e9b50b456040 Gerrit-PatchSet: 24 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0