May 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: cleanup RedirectServlet (5/N)
by lhornyak＠redhat.com 22 May '13

22 May '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: cleanup RedirectServlet (5/N) ...................................................................... engine: cleanup RedirectServlet (5/N) - removed declaration of variables before they are used Change-Id: I2a9193e02ac219f1a281e017aa2b69d57211b53e Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/root/src/main/java/org/ovirt/engine/core/redirect/RedirectServlet.java 1 file changed, 4 insertions(+), 6 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14554 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a9193e02ac219f1a281e017aa2b69d57211b53e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: cleanup RedirectServlet (3/N)
by lhornyak＠redhat.com 22 May '13

22 May '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: cleanup RedirectServlet (3/N) ...................................................................... engine: cleanup RedirectServlet (3/N) - use commons-lang StringUtil to check returned value Change-Id: Ib51ed8abbbbca374a75ad94c79ef4aad31fac9f7 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/root/src/main/java/org/ovirt/engine/core/redirect/RedirectServlet.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib51ed8abbbbca374a75ad94c79ef4aad31fac9f7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: cleanup RedirectServlet (2/N)
by lhornyak＠redhat.com 22 May '13

22 May '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: cleanup RedirectServlet (2/N) ...................................................................... engine: cleanup RedirectServlet (2/N) - typo fixed Change-Id: Ife2aea13fcd0f1d2c88caf7b5f68d3439e155535 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/root/src/main/java/org/ovirt/engine/core/redirect/RedirectServlet.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14551 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife2aea13fcd0f1d2c88caf7b5f68d3439e155535 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: cleanup RedirectServlet (1/N)
by lhornyak＠redhat.com 22 May '13

22 May '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: cleanup RedirectServlet (1/N) ...................................................................... engine: cleanup RedirectServlet (1/N) - catch identation fix Change-Id: I4f82a0adb6980fa06a0480cb132db0f2e4a34ba2 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/root/src/main/java/org/ovirt/engine/core/redirect/RedirectServlet.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14550 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f82a0adb6980fa06a0480cb132db0f2e4a34ba2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: packaging: prepare rpm build env
by mpastern＠redhat.com 22 May '13

22 May '13

Michael Pasternak has submitted this change and it was merged. Change subject: packaging: prepare rpm build env ...................................................................... packaging: prepare rpm build env Initial add of the packaging, including Makefile and .spec file Change-Id: Ie50e8eb82866832efe80da1e72339c9e0ad6bf27 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- A ovirt-engine-sdk-java/Makefile A ovirt-engine-sdk-java/ovirt-engine-sdk-java.spec.in M ovirt-engine-sdk-java/pom.xml 3 files changed, 178 insertions(+), 14 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14969 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie50e8eb82866832efe80da1e72339c9e0ad6bf27 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add space in log before printing the word 'Task'.
by mlipchuk＠redhat.com 22 May '13

22 May '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add space in log before printing the word 'Task'. ...................................................................... core: Add space in log before printing the word 'Task'. Avoiding printing the command name with the word 'Task' at the end of the name. Change-Id: I4ce801fc9889f8c2f8d3a74f67b1a061bddcef6e Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14432 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ce801fc9889f8c2f8d3a74f67b1a061bddcef6e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: private method is never called
by shavivi＠redhat.com 22 May '13

22 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: private method is never called ...................................................................... findbugs: private method is never called findbugs reason: UPM: Private method is never called (UPM_UNCALLED_PRIVATE_METHOD) Change-Id: I064bb1795a41ae11adaa1871ec9aca4f937a275a Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterClustersResourceTest.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14904 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I064bb1795a41ae11adaa1871ec9aca4f937a275a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: reference comparison of const value instead of lon...
by shavivi＠redhat.com 22 May '13

22 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: reference comparison of const value instead of long value ...................................................................... findbugs: reference comparison of const value instead of long value findbugs reason: RC: Suspicious reference comparison to constant (RC_REF_COMPARISON_BAD_PRACTICE) Change-Id: I3d1fbe7507f01dbeac13413ff7ed3d957e5380a4 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/QuotaUtilizationStatusColumn.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14903 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d1fbe7507f01dbeac13413ff7ed3d957e5380a4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: ignore: added ignore missing break in switch-case
by shavivi＠redhat.com 22 May '13

22 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: ignore: added ignore missing break in switch-case ...................................................................... findbugs: ignore: added ignore missing break in switch-case findbugs reason: SF: Switch statement found where one case falls through to the next case (SF_SWITCH_FALLTHROUGH) Change-Id: I33b157dee88622359643991d360cb3d3356736c8 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/bll/exclude-filters.xml A backend/manager/modules/compat/exclude-filters.xml M backend/manager/modules/compat/pom.xml A backend/manager/modules/restapi/jaxrs/exclude-filters.xml M backend/manager/modules/restapi/jaxrs/pom.xml A backend/manager/modules/restapi/types/exclude-filters.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java 8 files changed, 118 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14865 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33b157dee88622359643991d360cb3d3356736c8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix unauthorized move-disk
by gchaplik＠redhat.com 21 May '13

21 May '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: Fix unauthorized move-disk ...................................................................... core: Fix unauthorized move-disk When quota was set to 'Enforcing' user could move a disk to a storage domain which he had no permissions to use. For some reason, an 'if' statement was used in order to add the storage-domain to the permission subject list only when quota was set to 'Disabled' or 'Audit'. 'If' statement was canceled. The storage-domain is added to the list when disk is about to be moved to the storage-domain. Change-Id: I32713cbcf3206ab449ddca9b0ebd382bf77a7582 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java 4 files changed, 7 insertions(+), 41 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14769 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32713cbcf3206ab449ddca9b0ebd382bf77a7582 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0