May 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: SyntaxChecker cleanup
by lhornyak＠redhat.com 21 May '13

21 May '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: SyntaxChecker cleanup ...................................................................... engine: SyntaxChecker cleanup - sqlinjectionchecker is frequently reassigned in constructor, it is better if it is not static Change-Id: Ifa4e0e5fbda8ce16bf39db636a0088600523cc0e Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14559 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa4e0e5fbda8ce16bf39db636a0088600523cc0e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Disallow moving SD to maintanance if there are async t...
by tnisan＠redhat.com 21 May '13

21 May '13

Tal Nisan has submitted this change and it was merged. Change subject: core: Disallow moving SD to maintanance if there are async tasks ...................................................................... core: Disallow moving SD to maintanance if there are async tasks Added a check whether there are running tasks on the storage domain to the canDo section of the decativate storage domain command, before this patch the test would have occur only for domains of type master/import and not data domain Change-Id: Iffb08a180be66ce74d70761ce75db96f72fe93e6 Bug-Url: https://bugzilla.redhat.com/953455 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java 2 files changed, 7 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14893 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffb08a180be66ce74d70761ce75db96f72fe93e6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: gluster services - NFS and SHD only
by kmayilsa＠redhat.com 21 May '13

21 May '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: gluster services - NFS and SHD only ...................................................................... webadmin: gluster services - NFS and SHD only As there are some new service types are added to the enum, which are not yet implemented in the UI. So adding only NFS and SHD to the service type drop down. Change-Id: Icf86977d542e9a31996b94ea8a85c708a6de14e1 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterServiceModel.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shubhendu Tripathi: Looks good to me, but someone else must approve Kanagaraj M: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14918 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf86977d542e9a31996b94ea8a85c708a6de14e1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Gluster hooks - view content popup
by kmayilsa＠redhat.com 21 May '13

21 May '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: Gluster hooks - view content popup ...................................................................... webadmin: Gluster hooks - view content popup A new action 'View Content' added to Gluster Hooks sub tab in cluster. This will open a popup which will show the content of the hook. If the hook is a binary file, 'View Content' action will be disabled. Change-Id: Ic304b8155d5bf769813197a9796bf6d86fd10bfe Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGlusterHookListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/GlusterHookContentModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/ClusterModule.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/cluster/GlusterHookContentPopupPresenterWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/GlusterHookContentPopupView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/GlusterHookContentPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGlusterHookView.java 11 files changed, 297 insertions(+), 4 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic304b8155d5bf769813197a9796bf6d86fd10bfe Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: gluster: Change sp name for hook content read
by yzaslavs＠redhat.com 21 May '13

21 May '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: gluster: Change sp name for hook content read ...................................................................... gluster: Change sp name for hook content read There's an issue with using same procedure with different row mappers. The procedure name - row mapper is cached and causes exception. So changed code to use different procedure for getting hook content Change-Id: Icd3c74bea322edf636fd166eb93785eceec0ed57 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/dbscripts/gluster_hooks_sp.sql M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterHooksDaoDbFacadeImpl.java 2 files changed, 13 insertions(+), 4 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14832 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd3c74bea322edf636fd166eb93785eceec0ed57 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: domain validation changes
by oschreib＠redhat.com 21 May '13

21 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: domain validation changes ...................................................................... packaging: setup: domain validation changes 1. perform reverse lookup only if AIO plugin is installed, as it is not required unless libvirt is trying to perform migration. 2. allow names without suffix, warn in this case. 3. split out hostname logic from protocols. Change-Id: I7276d3e9088fd370458846bfdcee7166331935e4 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/all-in-one/core.py M packaging/setup/plugins/ovirt-engine-setup/config/__init__.py A packaging/setup/plugins/ovirt-engine-setup/config/hostname.py M packaging/setup/plugins/ovirt-engine-setup/config/protocols.py 5 files changed, 362 insertions(+), 294 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14889 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7276d3e9088fd370458846bfdcee7166331935e4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: cleanup warnings
by oschreib＠redhat.com 21 May '13

21 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: cleanup warnings ...................................................................... packaging: setup: cleanup warnings Change-Id: Ib042324c006b874c4e6a376dceffb87e500de6a3 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/releasepreview/misc.py 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14887 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib042324c006b874c4e6a376dceffb87e500de6a3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Removed obsolete add_fn_db_get_async_tasks_functi...
by oschreib＠redhat.com 21 May '13

21 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Removed obsolete add_fn_db_get_async_tasks_function.sql ...................................................................... packaging: Removed obsolete add_fn_db_get_async_tasks_function.sql This patch removes an obsolete code loading into the DB during upgrade flows. Change-Id: Ic0ca20ff2da1bdf8f6037e877b3697b7af8443c2 Bug-Url: https://bugzilla.redhat.com/951092 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M Makefile M ovirt-engine.spec.in D packaging/fedora/setup/add_fn_db_get_async_tasks_function.sql M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/engine-upgrade.py 5 files changed, 0 insertions(+), 82 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0ca20ff2da1bdf8f6037e877b3697b7af8443c2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: Change remove message
by ecohen＠redhat.com 20 May '13

20 May '13

Einav Cohen has submitted this change and it was merged. Change subject: userportal,webadmin: Change remove message ...................................................................... userportal,webadmin: Change remove message - Change the 'Are you sure you want to remove the following {0}?' with 'Are you sure you want to remove the following items?' Change-Id: Ia934e33d1a975e0235e1a1ffae0c8a4a7af66f10 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/RemoveConfirmationPopupView.java 3 files changed, 3 insertions(+), 6 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14621 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia934e33d1a975e0235e1a1ffae0c8a4a7af66f10 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: import vm - fix SD selection
by derez＠redhat.com 20 May '13

20 May '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: import vm - fix SD selection ...................................................................... webadmin: import vm - fix SD selection Fix storage domain selection on import VM dialog. Change-Id: I82edae9beaecbcba67bcd4aedeb1e47e1916c9f4 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmPopupView.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82edae9beaecbcba67bcd4aedeb1e47e1916c9f4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0