May 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: import dialog doesnt open
by derez＠redhat.com 20 May '13

20 May '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: import dialog doesnt open ...................................................................... webadmin: import dialog doesnt open Moving 'initSubTabLayoutPanel' call from the ctr to 'edit' method to make sure the model is already initialized (importModel initialization is done on 'edit'). Change-Id: I1cbce0ba41b17d449d910c301e9cd8fd4193dc5d Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmPopupView.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14896 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1cbce0ba41b17d449d910c301e9cd8fd4193dc5d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: doc: document dao tests
by yzaslavs＠redhat.com 20 May '13

20 May '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: packaging: doc: document dao tests ...................................................................... packaging: doc: document dao tests Change-Id: Ifc5280b2d202f2efa55c8db67bc8a769207ff576 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M README.developer 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14901 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc5280b2d202f2efa55c8db67bc8a769207ff576 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: use valueOf instead of number constructor
by shavivi＠redhat.com 20 May '13

20 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: use valueOf instead of number constructor ...................................................................... findbugs: use valueOf instead of number constructor findbugs code: Bx: Method invokes inefficient Number constructor; use static valueOf instead Change-Id: If77d88f1862d2e75871b28695f7d8631eb30cc91 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ObjectUtilsTest.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If77d88f1862d2e75871b28695f7d8631eb30cc91 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: use platform specific line separator for String.Fo...
by shavivi＠redhat.com 20 May '13

20 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: use platform specific line separator for String.Format ...................................................................... findbugs: use platform specific line separator for String.Format findbugs code: FS: Format string should use %n rather than \n Change-Id: I38b80e67df8c1618cbca3f0de722aef412e50664 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetupNetworksVdsCommandParameters.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/sender/mail/EventSenderMailImpl.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/sender/mail/MessageHelper.java 4 files changed, 10 insertions(+), 10 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14781 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38b80e67df8c1618cbca3f0de722aef412e50664 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: Random object should be used more then once for be...
by shavivi＠redhat.com 20 May '13

20 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: Random object should be used more then once for better random ...................................................................... findbugs: Random object should be used more then once for better random findbugs code: DMI: Random object created and used only once Change-Id: I6e8c345507542829b6b31a7be5f482ec00f71397 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/AdGroupsSearchParametersTest.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/AdUsersSearchParametersTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/CustomMapSqlParameterSourceTest.java 3 files changed, 24 insertions(+), 4 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14777 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e8c345507542829b6b31a7be5f482ec00f71397 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: returning local variable that is not written
by shavivi＠redhat.com 20 May '13

20 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: returning local variable that is not written ...................................................................... findbugs: returning local variable that is not written findbugs code: UwF: Unwritten field Change-Id: I33cf80871e5c0567ccb47d307342fbcf36911d4c Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/UiCommandButtonDefinition.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14776 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33cf80871e5c0567ccb47d307342fbcf36911d4c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: dal: tests: remove the redundant escaped connection url
by yzaslavs＠redhat.com 20 May '13

20 May '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: dal: tests: remove the redundant escaped connection url ...................................................................... dal: tests: remove the redundant escaped connection url Change-Id: Id2f6f5979795f34e2fd495140e38b18bdd4f8d4a Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/dal/src/test/filters/pgsql.properties M backend/manager/modules/dal/src/test/resources/test-database.properties 2 files changed, 1 insertion(+), 2 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14900 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2f6f5979795f34e2fd495140e38b18bdd4f8d4a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: fix typo in variable name
by tnisan＠redhat.com 20 May '13

20 May '13

Tal Nisan has submitted this change and it was merged. Change subject: restapi: fix typo in variable name ...................................................................... restapi: fix typo in variable name Fix variable name from storageForamt to storageFormat in StorageDomainMapper. Change-Id: I5d22a30eeec06b6bdfc71c1de0fdd158ecb0f250 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageDomainMapper.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14892 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d22a30eeec06b6bdfc71c1de0fdd158ecb0f250 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: support for PrepareForHibernation status
by ofrenkel＠redhat.com 20 May '13

20 May '13

Omer Frenkel has submitted this change and it was merged. Change subject: frontend: support for PrepareForHibernation status ...................................................................... frontend: support for PrepareForHibernation status Show the newly added VM status PrepareForHibernation exactly as SavingState in the webadmin and user portal. Change-Id: I841c75f309bfa8983a84d354632327a3996922fa Bug-Url: https://bugzilla.redhat.com/949281 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/table/column/VmStatusColumn.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java 2 files changed, 5 insertions(+), 1 deletion(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14512 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I841c75f309bfa8983a84d354632327a3996922fa Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: lock the vds manager while calling hibernate verb
by ofrenkel＠redhat.com 20 May '13

20 May '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: lock the vds manager while calling hibernate verb ...................................................................... core: lock the vds manager while calling hibernate verb It is needed to lock the vds manager so that no statuses will be updated while calling the hibernate verb in vdsm and setting the status of the VM to SavingState afterwards. The previous HibernateVDSCommand is changed to HibernateBrokerVDSCommand, and a new HibernateVDSCommand that calls it after the vds manager is locked, is added. Change-Id: I2537fffccd15cb5fa30f99793c803373886c633f Bug-Url: https://bugzilla.redhat.com/949281 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HibernateVDSCommand.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HibernateBrokerVDSCommand.java 3 files changed, 62 insertions(+), 3 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/14520 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2537fffccd15cb5fa30f99793c803373886c633f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0