May 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: align Path field in NfsStorage dialog
by derez＠redhat.com 20 May '13

20 May '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: align Path field in NfsStorage dialog ...................................................................... webadmin: align Path field in NfsStorage dialog Align the export path field and it's hint label in nfs storage domain dialog so it will be left aligned with the rest of the fields in the dialog. Change-Id: I1187a720c1365c10194a416aa0bd364abe650774 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.ui.xml 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14817 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1187a720c1365c10194a416aa0bd364abe650774 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: VmReplicateDiskFinish on SyncImageData failure
by derez＠redhat.com 20 May '13

20 May '13

Daniel Erez has submitted this change and it was merged. Change subject: core: VmReplicateDiskFinish on SyncImageData failure ...................................................................... core: VmReplicateDiskFinish on SyncImageData failure Requirements: * VmReplicateDiskFinish should be sent on SyncImageData failure. * Further rollback should be prevented on VmReplicateDiskFinish failure. * Disk should always be unlocked after failure. Implementation details: * Added 'preventRollback' method to TaskHandlerCommand interface. * Implemented 'preventRollback' on LiveMigrateDiskCommand. * Called 'revertTask' on 'endWithFailure' to ensure revert on task failure. Change-Id: I6c25b02cb0c2bd78b012dd3e3654caa43f5141d6 Bug-Url: https://bugzilla.redhat.com/961423 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskFinishTaskHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskStartTaskHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/TaskHandlerCommand.java 5 files changed, 65 insertions(+), 21 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14722 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c25b02cb0c2bd78b012dd3e3654caa43f5141d6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: pki: solve ibm/openjdk incompatibility
by oschreib＠redhat.com 19 May '13

19 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: pki: solve ibm/openjdk incompatibility ...................................................................... pki: solve ibm/openjdk incompatibility synthesis PKCS#12 using openssl to remove the friendly name causing the openjdk to fail reading its content. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=961081 Change-Id: Ib54e1a6dc5608ca7697c06b72ded988ded75d13f Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/engine-upgrade.py 1 file changed, 47 insertions(+), 19 deletions(-) Approvals: Alon Bar-Lev: Verified Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14864 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib54e1a6dc5608ca7697c06b72ded988ded75d13f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: added FQDN validation to engine-setup-2
by oschreib＠redhat.com 19 May '13

19 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: added FQDN validation to engine-setup-2 ...................................................................... packaging: setup: added FQDN validation to engine-setup-2 - Added missing FQDN falidation to engine-setup-2 - Reverse lookup validation is done only if AIO is used. Change-Id: Ie9764f32ba5e30062532bf11c67756677333c44f Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/all-in-one/core.py M packaging/setup/plugins/ovirt-engine-setup/config/protocols.py 3 files changed, 286 insertions(+), 13 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9764f32ba5e30062532bf11c67756677333c44f Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: rename methods in DiskImage
by amureini＠redhat.com 19 May '13

19 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: rename methods in DiskImage ...................................................................... core: rename methods in DiskImage Rename get/setActualSizeFromDiskImage to get/setActualSizeInBytes to reflect better what the method returns, and rename the corresponding class member as well. Change-Id: Iaf26bda8e00c1ae2f12b1decf6e1b4a8d12bed31 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskFinishTaskHandler.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmTemplateCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/TestHelperImportVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAODbFacadeImpl.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskMapper.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImageInfoVDSCommand.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotInfoPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/template/DisksTree.java 20 files changed, 45 insertions(+), 45 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14768 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf26bda8e00c1ae2f12b1decf6e1b4a8d12bed31 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: backup database before clearing
by oschreib＠redhat.com 19 May '13

19 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: backup database before clearing ...................................................................... packaging: setup: backup database before clearing move backup restore into utilities, to allow reuse. move pgpass creation into common. Change-Id: I89635b7bf6e86fb3bf3657717a903b1efb127b9a Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/database.py M packaging/setup/plugins/ovirt-engine-common/db/__init__.py M packaging/setup/plugins/ovirt-engine-common/db/connection.py A packaging/setup/plugins/ovirt-engine-common/db/pgpass.py M packaging/setup/plugins/ovirt-engine-remove/db/clear.py M packaging/setup/plugins/ovirt-engine-setup/db/connection.py M packaging/setup/plugins/ovirt-engine-setup/db/schema.py M packaging/setup/plugins/ovirt-engine-setup/provisioning/postgres.py 8 files changed, 189 insertions(+), 125 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14703 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89635b7bf6e86fb3bf3657717a903b1efb127b9a Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: edit inactive when VM is running
by derez＠redhat.com 19 May '13

19 May '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: edit inactive when VM is running ...................................................................... webadmin: edit inactive when VM is running Edit button shouldn't be grayed out for inactive disks when the VM is running. Change-Id: I844c97b10dda22181f3f827970ae7aef837ea5c6 Bug-Url: https://bugzilla.redhat.com/963545 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14764 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I844c97b10dda22181f3f827970ae7aef837ea5c6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: added summary to engine-cleanup-2
by oschreib＠redhat.com 19 May '13

19 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: added summary to engine-cleanup-2 ...................................................................... packaging: setup: added summary to engine-cleanup-2 moved dialog summary from ovirt-engine-setup to ovirt-engine-common allowing engine-cleanup-2 to have a summary. Change-Id: I894abbd6aab0e2840b164f7a361ed471a9edd961 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A packaging/setup/plugins/ovirt-engine-common/dialog/__init__.py A packaging/setup/plugins/ovirt-engine-common/dialog/titles.py M packaging/setup/plugins/ovirt-engine-remove/core/misc.py M packaging/setup/plugins/ovirt-engine-setup/dialog/titles.py 4 files changed, 115 insertions(+), 21 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14701 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I894abbd6aab0e2840b164f7a361ed471a9edd961 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: fix gluster hook mapping
by yzaslavs＠redhat.com 19 May '13

19 May '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine: fix gluster hook mapping ...................................................................... engine: fix gluster hook mapping Fixes gluster hook mapping. Change-Id: Ia79d7c52aeb6d496d6966d8759b6e35a87d2ac18 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterHooksDaoDbFacadeImpl.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14862 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia79d7c52aeb6d496d6966d8759b6e35a87d2ac18 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix RunOnce from a CD-ROM
by ofrenkel＠redhat.com 19 May '13

19 May '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: Fix RunOnce from a CD-ROM ...................................................................... core: Fix RunOnce from a CD-ROM Change-Id I2c10427764fa58faee54afaa89c4e5e62f5bad82 introduced a regression that did not allow booting from an ISO, as it misused the VM's storage pool ID as an ISO domain's ID. This patch recreates the original behaviour by finding the active ISO domain in the pool, and passing that on to validation. Change-Id: I8298cdbfd9ba3b629cd72c0cb6267cdb5469ab61 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14818 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8298cdbfd9ba3b629cd72c0cb6267cdb5469ab61 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0