May 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Refactoring AddVdsCommand#canDoAction()
by sanjal＠redhat.com 10 May '13

10 May '13

Shireesh Anjal has submitted this change and it was merged. Change subject: engine: Refactoring AddVdsCommand#canDoAction() ...................................................................... engine: Refactoring AddVdsCommand#canDoAction() to use failCanDoAction(), saving few lines of code. Also made sure that the gluster specific validation happens only if all previous validation was successful. Change-Id: Id2525aa9ce72654fea18eb60948a87d95a636602 Signed-off-by: Shireesh Anjal <anjalshireesh(a)gmail.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java 1 file changed, 10 insertions(+), 17 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14401 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2525aa9ce72654fea18eb60948a87d95a636602 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core : power management types are not updated
by mpastern＠redhat.com 09 May '13

09 May '13

Michael Pasternak has submitted this change and it was merged. Change subject: core : power management types are not updated ...................................................................... core : power management types are not updated Power management types from rest api and admin portal dont match. The rest api does not values from database. Change-Id: Ibd1f82f1508ff1c2f1148692b49b47c535dbbaa1 Bug-Url: https://bugzilla.redhat.com/955573 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 9 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd1f82f1508ff1c2f1148692b49b47c535dbbaa1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi : if "filter: ..." header is set, use query instead ...
by mpastern＠redhat.com 09 May '13

09 May '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : if "filter: ..." header is set, use query instead of search to list items ...................................................................... restapi : if "filter: ..." header is set, use query instead of search to list items When the filter option is specified the api query should not throw a insufficient permissions exception. Instead the query should return a list of objects that the user has permissions for. This patch fixes /events/{id} Change-Id: Ia2ab0e1e62b9cc67fad51da5e5e0b2c1163087a6 Bug-Url: https://bugzilla.redhat.com/869334 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendEventsResource.java 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14274 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2ab0e1e62b9cc67fad51da5e5e0b2c1163087a6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Reverting the execution of encodingvalidator
by juan.hernandez＠redhat.com 09 May '13

09 May '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Reverting the execution of encodingvalidator ...................................................................... packaging: Reverting the execution of encodingvalidator This patch removes execution of the encodingvalidator utility on upgrade and restores running validators with SERVER_ADMIN permissions. Change-Id: Iabb320fd8d4df8b2a3f943a98dd3309469c730b7 Bug-Url: https://bugzilla.redhat.com/893459 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M Makefile M backend/manager/tools/dbutils/validatedb.sh M packaging/fedora/setup/engine-upgrade.py 3 files changed, 3 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iabb320fd8d4df8b2a3f943a98dd3309469c730b7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: Comparing integer by its reference value
by shavivi＠redhat.com 09 May '13

09 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: Comparing integer by its reference value ...................................................................... findbugs: Comparing integer by its reference value Change-Id: If780c1f44b1750dba343831e58f866359eded941 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendCapabilityResourceTest.java 2 files changed, 10 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14570 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If780c1f44b1750dba343831e58f866359eded941 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: String comparison is not using equals method
by shavivi＠redhat.com 09 May '13

09 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: String comparison is not using equals method ...................................................................... findbugs: String comparison is not using equals method Change-Id: I740261ed3383e147928505ea53edc19e2996ce69 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/template/TemplateGeneralModelForm.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmGeneralModelForm.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddClusterRM.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddDataCenterRM.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaClusterView.java 8 files changed, 11 insertions(+), 11 deletions(-) Approvals: Shahar Havivi: Verified Alona Kaplan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14199 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I740261ed3383e147928505ea53edc19e2996ce69 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: Null check of value previously dereferenced
by shavivi＠redhat.com 09 May '13

09 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: Null check of value previously dereferenced ...................................................................... findbugs: Null check of value previously dereferenced Change-Id: Ic5a1e4ea6f2338c53db028033297c48397354ef6 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java 4 files changed, 8 insertions(+), 5 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14579 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5a1e4ea6f2338c53db028033297c48397354ef6 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-iso-uploader[master]: Renamed engine-iso-uploader in ovirt-iso-uploader
by sbonazzo＠redhat.com 09 May '13

09 May '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: Renamed engine-iso-uploader in ovirt-iso-uploader ...................................................................... Renamed engine-iso-uploader in ovirt-iso-uploader The package should have the same name of the application. In this case, the package name seems better than the application name, so I've renamed the application instead of the package. engine-iso-uploader and a placeholder for its man page are kept for backward compatibility until all the documentation will be updated. Change-Id: I5f6cc47a3e068a62d6e8bdcd20f360e1d2a53c1c Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-iso-uploader.spec.in M src/Makefile.am M src/__main__.py M src/engine-iso-uploader.8 A src/ovirt-iso-uploader.8 6 files changed, 144 insertions(+), 138 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Verified; Looks good to me, approved Kiril Nesenko: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14133 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f6cc47a3e068a62d6e8bdcd20f360e1d2a53c1c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: adding gluster_server table and dao operations
by sanjal＠redhat.com 09 May '13

09 May '13

Shireesh Anjal has submitted this change and it was merged. Change subject: engine: adding gluster_server table and dao operations ...................................................................... engine: adding gluster_server table and dao operations A new table 'gluster_server' is added. Currently this will store the gluster UUID of the server and the table has a reference field(vds_id) to vds_static table. All the operations on this table like insert, update and remover are implemented Change-Id: I04ba0a7bf1eaa964db731cdfa24ab6875e0b1513 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- A backend/manager/dbscripts/gluster_server_sp.sql A backend/manager/dbscripts/upgrade/03_03_0140_add_gluster_server_table.sql A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterServer.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterServerDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterServerDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/jdbc-resources/engine-daos.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterServerDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 10 files changed, 337 insertions(+), 0 deletions(-) Approvals: Shireesh Anjal: Looks good to me, approved Kanagaraj M: Verified -- To view, visit http://gerrit.ovirt.org/14063 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04ba0a7bf1eaa964db731cdfa24ab6875e0b1513 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: vm->change cd, "Eject" is not localized
by alkaplan＠redhat.com 09 May '13

09 May '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: vm->change cd, "Eject" is not localized ...................................................................... webadmin: vm->change cd, "Eject" is not localized The default value "[Eject]" and "No CDs" in the drop down menu is not localized. Change-Id: I23516d20f2b1aeb8a57651671388cba701646b22 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/VmItemBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 5 files changed, 20 insertions(+), 11 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14509 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I23516d20f2b1aeb8a57651671388cba701646b22 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0