May 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[engine_3.2]: packaging: modified validation of fqdn input during setup
by oschreib＠redhat.com 08 May '13

08 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: modified validation of fqdn input during setup ...................................................................... packaging: modified validation of fqdn input during setup validateFQDN now explicitly states that an IP address is not supported instead of just saying "<ip address here> did not resolve to an ip address. User input failed validation..." Change-Id: I99d3727f0e2205f6cd90ff5c2a003fb6f0643eab Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=843623 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/fedora/setup/engine_validators.py M packaging/fedora/setup/output_messages.py 2 files changed, 8 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Verified Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99d3727f0e2205f6cd90ff5c2a003fb6f0643eab Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: packaging: fixing fqdn validation
by oschreib＠redhat.com 08 May '13

08 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: fixing fqdn validation ...................................................................... packaging: fixing fqdn validation if _getPatternFromNslookup returns an empty set, the validation will have caused a traceback. Change-Id: I4bf1385fbb1770c990c4b31c59d829ce91e4ed00 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/fedora/setup/engine_validators.py 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Verified Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14527 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4bf1385fbb1770c990c4b31c59d829ce91e4ed00 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: packaging: make validateFQDN case insensitive
by oschreib＠redhat.com 08 May '13

08 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: make validateFQDN case insensitive ...................................................................... packaging: make validateFQDN case insensitive If the specified FQDN to rhevm-setup is a different case to that returned by the DNS PTR record, then validateFQDN reports that the reverse-resolved name doesn't match the supplied name and fails the validation and hence rhevm-setup fails. This patch makes validateFQDN case insensitive so it doesn't matter if the supplied FQDN differs in case to that retured by the DNS PTR record, because DNS itself is case insensitive. Change-Id: I7619971956c1eba8b6d3f2a345b8fc85a778384e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=928165 Signed-off-by: Mark Huth <mhuth(a)redhat.com> --- M packaging/fedora/setup/engine_validators.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Mark Huth: Verified; Looks good to me, but someone else must approve Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Verified Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14526 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7619971956c1eba8b6d3f2a345b8fc85a778384e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Mark Huth <mhuth(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine-cli[cli_3.2]: cli: release 3.2.0.12-1
by mpastern＠redhat.com 08 May '13

08 May '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: release 3.2.0.12-1 ...................................................................... cli: release 3.2.0.12-1 Change-Id: Ie89303dbabf2346e274e9445c2d8e20d9bf01de6 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M Makefile M ovirt-engine-cli.spec.in M setup.py 3 files changed, 16 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14578 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie89303dbabf2346e274e9445c2d8e20d9bf01de6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk[sdk_3.2]: sdk: release 3.2.0.11-1
by mpastern＠redhat.com 08 May '13

08 May '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: release 3.2.0.11-1 ...................................................................... sdk: release 3.2.0.11-1 Change-Id: Icf7bf6d703304364bd93a11d44ddb537c01130fe Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M Makefile M ovirt-engine-sdk.spec.in M setup.py 3 files changed, 11 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14577 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf7bf6d703304364bd93a11d44ddb537c01130fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk[sdk_3.2]: sdk: sdk expose datetime elements as strings #960747
by mpastern＠redhat.com 08 May '13

08 May '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: sdk expose datetime elements as strings #960747 ...................................................................... sdk: sdk expose datetime elements as strings #960747 https://bugzilla.redhat.com/show_bug.cgi?id=960747 Change-Id: I8ea645dcf2903d2ecbeb516c673a340eab59f824 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M src/ovirtsdk/xml/params.py 1 file changed, 7,133 insertions(+), 4,987 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14576 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ea645dcf2903d2ecbeb516c673a340eab59f824 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk[sdk_3.2]: sdk: regenerate against the latest api
by mpastern＠redhat.com 08 May '13

08 May '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: regenerate against the latest api ...................................................................... sdk: regenerate against the latest api - fixed brics.add() params docs - fixed assigning tag to parent param docs Change-Id: Ia0fde5be2064127aade4df08bfee07a1be2f92df Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M src/ovirtsdk/infrastructure/brokers.py M src/ovirtsdk/xml/params.py 2 files changed, 9 insertions(+), 11 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14575 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0fde5be2064127aade4df08bfee07a1be2f92df Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix build break
by derez＠redhat.com 08 May '13

08 May '13

Daniel Erez has submitted this change and it was merged. Change subject: core: Fix build break ...................................................................... core: Fix build break Fixed the build break introduced by 4d77dd453e011796542cc64c2c391171631b2e7e Change-Id: Ic90b9f909c47301a3dea464e8a46cb887ad8c114 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/14574 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic90b9f909c47301a3dea464e8a46cb887ad8c114 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: root: use %{x} notation instead of ${x} in web.xml
by yzaslavs＠redhat.com 08 May '13

08 May '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: root: use %{x} notation instead of ${x} in web.xml ...................................................................... root: use %{x} notation instead of ${x} in web.xml rhel jboss, at least 7.1.3-4, perform unconditional properties ${x} substitutions in web.xml, while fedora jboss at least 7.1.1-9.3, does not. a solution for rhel jboss is to use $${x}, while this solution is not working for fedora jboss. to allow common processing and future migration to other application server the notation was changed to %{x}. Related-Change-Id: I94f845d36bb075c238e50606187bc22316713cdd Change-Id: I115118e6f46ac74bc882949e101bbe3d04e29684 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/root/src/main/java/org/ovirt/engine/core/FileServlet.java M backend/manager/modules/root/src/main/java/org/ovirt/engine/core/pki/PKIResourceServlet.java M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml 3 files changed, 12 insertions(+), 10 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14547 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I115118e6f46ac74bc882949e101bbe3d04e29684 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removed AddVmFromSnapshot.canLockSnapshot()
by amureini＠redhat.com 08 May '13

08 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Removed AddVmFromSnapshot.canLockSnapshot() ...................................................................... core: Removed AddVmFromSnapshot.canLockSnapshot() Removed the method and inlined the check together with the other snapshot validations. Change-Id: Ic0baad35bfaf24ae534676a24a6abc63d7853c23 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java 2 files changed, 7 insertions(+), 9 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/14571 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0baad35bfaf24ae534676a24a6abc63d7853c23 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0