May 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: live migrate - log error on failure
by derez＠redhat.com 06 May '13

06 May '13

Daniel Erez has submitted this change and it was merged. Change subject: core: live migrate - log error on failure ...................................................................... core: live migrate - log error on failure In case of shutting down the vm during snapshot creation part of live migrate, an appropriate failure AuditLog should be displayed (in addition, the error should be logged). Change-Id: Icae61b1c156e2bbb542a8790b310686028cc7a82 Bug-Url: https://bugzilla.redhat.com/957498 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDisksTaskHandler.java 2 files changed, 13 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14440 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icae61b1c156e2bbb542a8790b310686028cc7a82 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: notifier: move to the new service infrastructure
by yzaslavs＠redhat.com 06 May '13

06 May '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: notifier: move to the new service infrastructure ...................................................................... notifier: move to the new service infrastructure rename service to ovirt-engine-notifier to match other services. remove redundant parameter validations in shell script as there is duplicate java logic. Change-Id: I2aadeca8b3017dad4107939c7c624ef020347b94 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M .gitignore M Makefile M ovirt-engine.spec.in D packaging/bin/engine-notifier-service.sh D packaging/bin/engine-notifier.sh M packaging/conf/notifier.conf.defaults.in M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-cleanup.py M packaging/fedora/setup/engine-upgrade.py M packaging/services/config.py.in A packaging/services/ovirt-engine-notifier.py A packaging/services/ovirt-engine-notifier.systemd.in A packaging/services/ovirt-engine-notifier.sysv.in 14 files changed, 424 insertions(+), 426 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14378 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2aadeca8b3017dad4107939c7c624ef020347b94 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:unlock_entity is not locating locked snapshots
by yzaslavs＠redhat.com 06 May '13

06 May '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core:unlock_entity is not locating locked snapshots ...................................................................... core:unlock_entity is not locating locked snapshots Adding handling of 1) -t snapshot flag to display locked snapshots where -q is used 2) -t snapshot to remove a specific snapshot 3) -r if run with -t vm then all vm snapshots are removed as well Change-Id: I415be6fbe99a97740c9d4e9c55c1ad63bc689531 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=958370 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/common_sp.sql M backend/manager/dbscripts/dbfunctions.sh M backend/manager/dbscripts/unlock_entity.sh 3 files changed, 33 insertions(+), 2 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14494 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I415be6fbe99a97740c9d4e9c55c1ad63bc689531 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: notifier: use LocalConfig as configuration file
by Gerrit Code Review 06 May '13

06 May '13

Anonymous Coward has submitted this change and it was merged. Change subject: notifier: use LocalConfig as configuration file ...................................................................... notifier: use LocalConfig as configuration file gives the advantage of defaults and conf.d structure. Change-Id: Iea3d8a9887d76920c51d26467c634912e64242dd Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/LocalConfig.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/Notifier.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationConfigurator.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/sender/mail/JavaMailSender.java M backend/manager/tools/src/test/java/org/ovirt/engine/core/notifier/EngineMonitorServiceTest.java M backend/manager/tools/src/test/java/org/ovirt/engine/core/notifier/NotificationServiceTest.java M backend/manager/tools/src/test/java/org/ovirt/engine/core/notifier/utils/NotificationConfiguratorTest.java M ovirt-engine.spec.in M packaging/bin/engine-notifier.sh R packaging/conf/notifier.conf.defaults 12 files changed, 100 insertions(+), 144 deletions(-) -- To view, visit http://gerrit.ovirt.org/14376 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea3d8a9887d76920c51d26467c634912e64242dd Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: notifier: handle port correctly
by yzaslavs＠redhat.com 06 May '13

06 May '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: notifier: handle port correctly ...................................................................... notifier: handle port correctly 1. separate between plain and ssl ports. 2. actually set plain port. Change-Id: Ibcfa79849856dc3c2b3aaa9d0dd8652be04c788b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/sender/mail/JavaMailSender.java M packaging/etc/notifier/notifier.conf 3 files changed, 11 insertions(+), 5 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibcfa79849856dc3c2b3aaa9d0dd8652be04c788b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: notifier: switch to log4j
by yzaslavs＠redhat.com 06 May '13

06 May '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: notifier: switch to log4j ...................................................................... notifier: switch to log4j for some reason no logs using current logger. also fix log4j.xml as it complains about format. Change-Id: I35de5d5a97ccd4f7bb80739fdb328de2e0ce6bd9 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/EngineMonitorService.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/Notifier.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationConfigurator.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/sender/mail/EventSenderMailImpl.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/sender/mail/JavaMailSender.java M packaging/etc/notifier/log4j.xml.in 8 files changed, 15 insertions(+), 26 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14377 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35de5d5a97ccd4f7bb80739fdb328de2e0ce6bd9 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: config: split LocalConfig to allow code reuse
by yzaslavs＠redhat.com 06 May '13

06 May '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: config: split LocalConfig to allow code reuse ...................................................................... core: config: split LocalConfig to allow code reuse EngineLocalConfig - for engine. NotifierLocalConfig - [future] for notifier. Change-Id: I711d045b50b172e00455125363d870a61d2d6fa9 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacadeLocator.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/EngineLocalConfig.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/LocalConfig.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/EngineMonitorService.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/tools/common/db/StandaloneDataSource.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/plugin/PluginDataManager.java 7 files changed, 159 insertions(+), 137 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I711d045b50b172e00455125363d870a61d2d6fa9 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: config: support optional properties
by yzaslavs＠redhat.com 06 May '13

06 May '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: config: support optional properties ...................................................................... core: config: support optional properties Change-Id: I61975ab2c6c5b72c7eb0fe85b1ccef9eb2ef8fd9 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/LocalConfig.java 1 file changed, 135 insertions(+), 26 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14446 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61975ab2c6c5b72c7eb0fe85b1ccef9eb2ef8fd9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: config: support sensitive keys
by yzaslavs＠redhat.com 06 May '13

06 May '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: config: support sensitive keys ...................................................................... core: config: support sensitive keys do not print sensitive keys' value to log. Change-Id: I8dc10fb3eeb1cc97a03cc160133a84d6b2a23d87 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/LocalConfig.java M packaging/conf/engine.conf.defaults.in 2 files changed, 19 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14353 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8dc10fb3eeb1cc97a03cc160133a84d6b2a23d87 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: config: provide expand string for configuration
by yzaslavs＠redhat.com 06 May '13

06 May '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: config: provide expand string for configuration ...................................................................... core: config: provide expand string for configuration allow to expand strings such as "${ENGINE_ETC}/config" to proper value. handy for various of configuration locations. Change-Id: Ic54791d7ab6faa385a153158f21555a3d8ca49da Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/LocalConfig.java 1 file changed, 25 insertions(+), 13 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14447 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic54791d7ab6faa385a153158f21555a3d8ca49da Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0