May 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Fix for BZ#967890 - enhance logging of JndiAction le...
by yzaslavs＠redhat.com 30 May '13

30 May '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine: Fix for BZ#967890 - enhance logging of JndiAction level in dEBUG mode ...................................................................... engine: Fix for BZ#967890 - enhance logging of JndiAction level in dEBUG mode Enhanced logging possibility for JndiAction class in debug mode. This enables user to view more detailed info on what query path, URI and user was used to perform the authentication and ticket creation. Change-Id: Ia6c2504ba7d6f77492862e6ccf6c0770fdab0fd7 Bug-Url: https://bugzilla.redhat.com/967890 Signed-off-by: Tomas Dosek <tdosek(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/JndiAction.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15139 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6c2504ba7d6f77492862e6ccf6c0770fdab0fd7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomáš Došek <tdosek(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com> Gerrit-Reviewer: Tomáš Došek <tdosek(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: restapi : Cookies are being set even when not using persiste...
by mpastern＠redhat.com 29 May '13

29 May '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : Cookies are being set even when not using persistent authentication ...................................................................... restapi : Cookies are being set even when not using persistent authentication API sets jsession id when not using persistent authentication. This patch creates a session only when persistent authentication header is passed in the request. Change-Id: Ieb004fefbd9a276efacb2ce6fa8b7a48a9516c6e Bug-Url: https://bugzilla.redhat.com/962730 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/Challenger.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb004fefbd9a276efacb2ce6fa8b7a48a9516c6e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: SEAT compensate - prevent IndexOutOfBounds
by derez＠redhat.com 29 May '13

29 May '13

Daniel Erez has submitted this change and it was merged. Change subject: core: SEAT compensate - prevent IndexOutOfBounds ...................................................................... core: SEAT compensate - prevent IndexOutOfBounds CommandBase -> hasTaskHandlers: * compensate: setExecutionReason to ROLLBACK_FLOW for ensuring internalEndWithFailure flow as in revertPreviousHandlers. * internalEndWithFailure: verifying executionIndex >= 0 to prevent index underflow. * revertPreviousHandlers: when executionIndex < 0 set command as succeeded (to ensure tasks clean up). Change-Id: I7af9f3ab3bfce91b114d82145957909ba1ee7819 Bug-Url: https://bugzilla.redhat.com/966153 Bug-Url: https://bugzilla.redhat.com/966618 Bug-Url: https://bugzilla.redhat.com/965676 Bug-Url: https://bugzilla.redhat.com/962497 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 13 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15133 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7af9f3ab3bfce91b114d82145957909ba1ee7819 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: fix localstate plugin directories
by oschreib＠redhat.com 29 May '13

29 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: fix localstate plugin directories ...................................................................... packaging: setup: fix localstate plugin directories Change-Id: I9ce025ec2d975fb41ee53e77740917d8a0c945fd Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/config.py.in M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/system/localstate.py 3 files changed, 10 insertions(+), 15 deletions(-) Approvals: Alon Bar-Lev: Verified Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15167 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ce025ec2d975fb41ee53e77740917d8a0c945fd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-reports[master]: report: updated fr localization (#960940)
by ydary＠redhat.com 29 May '13

29 May '13

Yaniv Dary has submitted this change and it was merged. Change subject: report: updated fr localization (#960940) ...................................................................... report: updated fr localization (#960940) Bug-Url: https://bugzilla.redhat.com/960940 Change-Id: I9d416cf57be397b1f481c3bb5f353d6b2676df00 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/reports_resources/localization/ovirt_reports_bundle_fr.properties.data 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15163 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d416cf57be397b1f481c3bb5f353d6b2676df00 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix typos in method and variable names
by amureini＠redhat.com 29 May '13

29 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: fix typos in method and variable names ...................................................................... core: fix typos in method and variable names Fix typos in method and variable names in several classes. Change-Id: I16f6b8714715d83f7d73b955e26cc3caea21c24b Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DetachStorageDomainFromPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java 3 files changed, 5 insertions(+), 5 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15131 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16f6b8714715d83f7d73b955e26cc3caea21c24b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: ApplicationMode - fix system tree filtering
by kmayilsa＠redhat.com 29 May '13

29 May '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: ApplicationMode - fix system tree filtering ...................................................................... webadmin: ApplicationMode - fix system tree filtering - DataCenters, Providers and Provider type nodes will be visible in system tree only if the ApplicationMode supports Virt. - Modified the system tree filtering to add the grand child items if all immediate child items are not visible. Change-Id: I7969eab70929d8206f217a226b519b1fd14619b7 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ApplicationModeHelper.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java 2 files changed, 12 insertions(+), 7 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15158 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7969eab70929d8206f217a226b519b1fd14619b7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: cleanup: remove ununsed variable
by oschreib＠redhat.com 29 May '13

29 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: cleanup: remove ununsed variable ...................................................................... packaging: setup: cleanup: remove ununsed variable Change-Id: Ia93f3309c63f638945e91c2687fd0eed4589dcf4 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/network/firewalld.py 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15071 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia93f3309c63f638945e91c2687fd0eed4589dcf4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: set ovirt-engine-remove prefix for remove ...
by oschreib＠redhat.com 29 May '13

29 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: set ovirt-engine-remove prefix for remove log ...................................................................... packaging: setup: set ovirt-engine-remove prefix for remove log Change-Id: I7f337f0912acc7e13552628edf50e150c7ec3227 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-common/core/misc.py M packaging/setup/plugins/ovirt-engine-remove/core/misc.py M packaging/setup/plugins/ovirt-engine-setup/core/misc.py 4 files changed, 27 insertions(+), 5 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15067 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f337f0912acc7e13552628edf50e150c7ec3227 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: fix typo
by oschreib＠redhat.com 29 May '13

29 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: fix typo ...................................................................... packaging: setup: fix typo Change-Id: Ie901d7e35c1961d977aee4b1ac0c6ca6f2886464 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/db/schema.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15066 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie901d7e35c1961d977aee4b1ac0c6ca6f2886464 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0