Change in ovirt-engine[master]: packaging: cleanup spec file
by oschreib＠redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: cleanup spec file
......................................................................
packaging: cleanup spec file
1. use %{_initddir}
2. be more consistent with service name, use explict name always
Change-Id: Ib30fc665069d90b7cdb6855c92ee27d8ef143615
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/fedora/spec/ovirt-engine.spec.in
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14373
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib30fc665069d90b7cdb6855c92ee27d8ef143615
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years
Change in ovirt-engine[master]: userportal: prevent an error dialog in login page
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: userportal: prevent an error dialog in login page
......................................................................
userportal: prevent an error dialog in login page
Frontend -> handleActionResult:
* Removed the redundant call to
getEventsHandler().runActionFailed(failed) which invokes an error
dialog without verifying 'isRaiseErrorModalPanel' flag first.
* Removed the method as well since it's not used anymore.
* Now, the error dialog will be invoked only after flag verification
by raising frontendFailureEvent.
* This issue of duplicate dialog invocation was hidden by now
in UserPortal's login page by simply ignoring any error
dialog (removed in Ibd2718649ab4031e6ff2b0d0e6c449f53164ff9f).
Change-Id: Ib240214df319a0122ebcac82bf2b96d608997432
Bug-Url: https://bugzilla.redhat.com/957793
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/IFrontendEventsHandler.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendEventsHandlerImpl.java
3 files changed, 0 insertions(+), 9 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14392
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib240214df319a0122ebcac82bf2b96d608997432
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years
Change in ovirt-engine[master]: core: Remove SearchQueryFormatter.main(String[])
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove SearchQueryFormatter.main(String[])
......................................................................
core: Remove SearchQueryFormatter.main(String[])
SearchQueryFormatter seems to have an old main(String[]) function used
for a visual sanity check.
This method has not real use, and no place in production code.
Change-Id: I4e36f0fe4dd51d96725090a5ece6f736f298a4e7
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/SearchQueryFotmatter.java
1 file changed, 0 insertions(+), 13 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14420
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4e36f0fe4dd51d96725090a5ece6f736f298a4e7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years
Change in ovirt-engine[master]: core: LexoNumericComparator to comparators pkg
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: LexoNumericComparator to comparators pkg
......................................................................
core: LexoNumericComparator to comparators pkg
Moved LexoNumericComparator to the comparators package, like all the
other comparators.
Change-Id: Ic23f6efefb8f83a791cab38f3da43a78c5f885bb
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/LexoNumericComparator.java
R backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/comparators/LexoNumericComparatorTest.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostBondInterfaceModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksBondModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkItemModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java
9 files changed, 10 insertions(+), 10 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified
--
To view, visit http://gerrit.ovirt.org/14412
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic23f6efefb8f83a791cab38f3da43a78c5f885bb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
11 years
Change in ovirt-engine[master]: core: Removed comparators' Compare methods
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Removed comparators' Compare methods
......................................................................
core: Removed comparators' Compare methods
This is probably a leftover from the C# days.
In java, comparators have a compare(T, T) method.
Change-Id: I0fa2e830a9560dc4db9929053bd7ceced48a135d
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVMActionRunner.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmTemplateComparerByDiskSize.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmsComparer.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmsComparerByDiskSize.java
4 files changed, 3 insertions(+), 15 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified
--
To view, visit http://gerrit.ovirt.org/14413
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0fa2e830a9560dc4db9929053bd7ceced48a135d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
11 years
Change in ovirt-engine[master]: core: Replace FQCNs with imports for comparators
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Replace FQCNs with imports for comparators
......................................................................
core: Replace FQCNs with imports for comparators
Replaced FQCN references with imports throughout the comparators
package.
Change-Id: I80a1f040a395a5681dedd891ba5e6ddeb601ec15
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/InterfaceComparerByMAC.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmTemplateComparerByDiskSize.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmsComparer.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmsComparerByDiskSize.java
4 files changed, 8 insertions(+), 5 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified
--
To view, visit http://gerrit.ovirt.org/14414
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I80a1f040a395a5681dedd891ba5e6ddeb601ec15
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
11 years
Change in ovirt-engine[master]: core: Remove comparators' empty default ctors
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove comparators' empty default ctors
......................................................................
core: Remove comparators' empty default ctors
Removed empty implementation of the default constructor throughout the
comparators package.
These constructors have no added value, and just clatter up the code.
Change-Id: Id8477d87cd992ceba047a4f07a75337b8ed7d30d
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/InterfaceComparerByMAC.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmTemplateComparerByDiskSize.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmsComparer.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmsComparerByDiskSize.java
4 files changed, 0 insertions(+), 12 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified
--
To view, visit http://gerrit.ovirt.org/14415
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id8477d87cd992ceba047a4f07a75337b8ed7d30d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
11 years
Change in ovirt-engine[master]: core: Remove FieldsInVDCConfigXmlToSQL
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove FieldsInVDCConfigXmlToSQL
......................................................................
core: Remove FieldsInVDCConfigXmlToSQL
The FieldsInVDCConfigXmlToSQL is no longer in use, and should be
removed.
Change-Id: I950bbe7e04fd2f90df23e70d0749c8fa8210235f
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
D backend/manager/dbscripts/FieldsInVDCConfigXmlToSQL.java
1 file changed, 0 insertions(+), 263 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14191
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I950bbe7e04fd2f90df23e70d0749c8fa8210235f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years
Change in ovirt-engine[master]: core: Fix redundant space in DB upgrade output
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Fix redundant space in DB upgrade output
......................................................................
core: Fix redundant space in DB upgrade output
The run_file function only receives one argument, so $2 is always
evaluated as an empty string.
This cause the database upgrade/creation scripts to print
"Running upgrade sql script" and "Running upgrade shell script", with
two whitespaces after "Running" instead of just one.
Removing the call to $2 resolves this issue.
Change-Id: I3cb5f8778e570df1f2f76f3a16d32530b9a24b52
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/dbscripts/dbfunctions.sh
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14195
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3cb5f8778e570df1f2f76f3a16d32530b9a24b52
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years
Change in ovirt-engine[master]: core: update splash page locales
by ecohen＠redhat.com
Einav Cohen has submitted this change and it was merged.
Change subject: core: update splash page locales
......................................................................
core: update splash page locales
After merging patch http://gerrit.ovirt.org/#/c/14356/, adjusting the
splash page to conform to the updated list of available locales.
Change-Id: I2f853c6e2d6526d1ca1665f934941f18f05946a0
Signed-off-by: Einav Cohen <ecohen(a)redhat.com>
---
M backend/manager/modules/root/src/main/resources/org/ovirt/engine/core/languages.properties
M backend/manager/modules/root/src/test/java/org/ovirt/engine/core/SplashServletTest.java
2 files changed, 8 insertions(+), 8 deletions(-)
Approvals:
Einav Cohen: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14409
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f853c6e2d6526d1ca1665f934941f18f05946a0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
11 years