June 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: setup: Updated the nfs service name usage
by oschreib＠redhat.com 27 Jun '13

27 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: Updated the nfs service name usage ...................................................................... packaging: setup: Updated the nfs service name usage This patch updates the usage of the nfs service name for different distributions allowing overriding with additional config loading. Change-Id: I17f4b564517c180e0fe14a0a4ed3d0e0b97a5e19 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/system/nfs.py 2 files changed, 29 insertions(+), 10 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15954 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17f4b564517c180e0fe14a0a4ed3d0e0b97a5e19 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: build: simplify plain files installation
by oschreib＠redhat.com 27 Jun '13

27 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: build: simplify plain files installation ...................................................................... packaging: build: simplify plain files installation copy packaging directory recursive excluded generated and other files. no need to explicitly specify each file at makefile. this should ease maintenance and reduce future commit size and conflicts. Change-Id: I294a14f7e954ec05ef497e870f9937e68b2a2bbc Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile 1 file changed, 84 insertions(+), 175 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15745 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I294a14f7e954ec05ef497e870f9937e68b2a2bbc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: make ovirt-engine-log-setup-event.sh execu...
by oschreib＠redhat.com 27 Jun '13

27 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: make ovirt-engine-log-setup-event.sh executable ...................................................................... packaging: setup: make ovirt-engine-log-setup-event.sh executable Change-Id: I67cb06d4c0815b133e22244fc02e337bdb0fe692 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16114 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67cb06d4c0815b133e22244fc02e337bdb0fe692 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: build: do not use maven deploy
by oschreib＠redhat.com 27 Jun '13

27 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: build: do not use maven deploy ...................................................................... packaging: build: do not use maven deploy maven deploy requires maven to be online, while fedora's maven is set into offline mode. using maven deploy into temp repository directory does not allow partial build of project. after the jboss module changes, we only fetch poms from the temp repository, so there is no actual need for it, as we do have these poms within tree. add maven target to allow execution of maven without condition. Change-Id: Iebcce8209c8a50c12a25816520233ce98af3cc32 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M README.developer 2 files changed, 38 insertions(+), 52 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16039 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iebcce8209c8a50c12a25816520233ce98af3cc32 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: spec: keep version at base package to avoid versi...
by oschreib＠redhat.com 27 Jun '13

27 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: spec: keep version at base package to avoid versionlock conflict ...................................................................... packaging: spec: keep version at base package to avoid versionlock conflict Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=976754 Change-Id: I76f517bf5e13f4ddd937ecf60e204b1a9359eeb0 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15989 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76f517bf5e13f4ddd937ecf60e204b1a9359eeb0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: build: fix make rpm target
by oschreib＠redhat.com 27 Jun '13

27 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: build: fix make rpm target ...................................................................... packaging: build: fix make rpm target was broken by the quote all patch, as srpm had wildcards. remove the variable that is used one time and quote correctly. Change-Id: I4632c1dd2007d2b513f59e08846da7d8030b8865 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4632c1dd2007d2b513f59e08846da7d8030b8865 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Adds config of SSH Soft Fencing command
by yzaslavs＠redhat.com 27 Jun '13

27 Jun '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Adds config of SSH Soft Fencing command ...................................................................... core: Adds config of SSH Soft Fencing command Adds SshSoftFencingCommand configuration value, that contains command to execute on host using SSH when host VDSM doesn't respond. By default it contains command to restart VDSM. Change-Id: I9f96cbe0c5fdc33f8f512c36d1cd85349852f2da Bug-Url: https://bugzilla.redhat.com/967328 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 3 files changed, 11 insertions(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15797 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f96cbe0c5fdc33f8f512c36d1cd85349852f2da Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: extract parameters initialization to seperate method
by ofrenkel＠redhat.com 27 Jun '13

27 Jun '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: extract parameters initialization to seperate method ...................................................................... core: extract parameters initialization to seperate method Extract long blocks of code that initialize command parameters from MoveOrCopyTemplateCommand#moveOrCopyAllImageGroups and AddVmFromTemplateCommand#addVmImages methods to separate methods in order to make the code more concise and readable Change-Id: I7328e84274fd9ba9f109608600da66c6308ec0b9 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java 2 files changed, 32 insertions(+), 26 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15873 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7328e84274fd9ba9f109608600da66c6308ec0b9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: organize AddVmCommand#canDoAction
by ofrenkel＠redhat.com 27 Jun '13

27 Jun '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: organize AddVmCommand#canDoAction ...................................................................... core: organize AddVmCommand#canDoAction Refactoring AddVmCommand#canDoAction method, such that it won't use the local variable returnValue to store the result - instead, we return false as soon as we detect a required condition that is false. those changes make the code more readable and compact. Change-Id: Ie4eda8868b50fd4a99462c0a649bba58e52f9bc0 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 42 insertions(+), 38 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15841 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4eda8868b50fd4a99462c0a649bba58e52f9bc0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: [RFE] More informative message in event when a VM star...
by ofrenkel＠redhat.com 27 Jun '13

27 Jun '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: [RFE] More informative message in event when a VM started in Paused Mode ...................................................................... core: [RFE] More informative message in event when a VM started in Paused Mode When starting a VM in a pause mode we want to write to the event log: Starting in paused mode ${VM_NAME} was initiated by ${USER_NAME}. Instead of the regular message: Starting VM ${VM_NAME} was initiated by ${USER_NAME}. Change-Id: I323636994ff74948b3f9039e990b1cae5e79d3cb Bug-Id: https://bugzilla.redhat.com/885135 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 4 files changed, 10 insertions(+), 4 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16093 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I323636994ff74948b3f9039e990b1cae5e79d3cb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0