June 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: userportal, webadmin: BrandingManager fails with missing etcd...
by derez＠redhat.com 25 Jun '13

25 Jun '13

Daniel Erez has submitted this change and it was merged. Change subject: userportal,webadmin: BrandingManager fails with missing etcdir ...................................................................... userportal,webadmin: BrandingManager fails with missing etcdir - BrandingManager.getInstance() would fail when you have a missing etcDir configuration which is often the case in unit tests. This patch stops the failure and instead returns no branding information. Change-Id: Ifc34286323c1eda114f6a8b5570274faf53b566c Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/branding/BrandingManager.java 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16046 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc34286323c1eda114f6a8b5570274faf53b566c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: a potential NPE when a user invokes actions
by derez＠redhat.com 25 Jun '13

25 Jun '13

Daniel Erez has submitted this change and it was merged. Change subject: restapi: a potential NPE when a user invokes actions ...................................................................... restapi: a potential NPE when a user invokes actions When a user invokes an action without sending filter=true property, the action may throw a NPE on command creation flow. The underlining issue is in AbstractBackendCollectionResource -> resolveCreated method. If an exception is thrown (e.g. due to lack of permissions to execute query), the method returns null. Instead of tolerating the exception, call handleError method (to output a proper error message). Change-Id: I55f5ae906d6c0d2023783e7b61abe3bf9d01f28f Bug-Url: https://bugzilla.redhat.com/915106 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResource.java 1 file changed, 2 insertions(+), 5 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15394 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55f5ae906d6c0d2023783e7b61abe3bf9d01f28f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Adding batch procedure call test to excludes part
by rgolan＠redhat.com 25 Jun '13

25 Jun '13

Roy Golan has submitted this change and it was merged. Change subject: core: Adding batch procedure call test to excludes part ...................................................................... core: Adding batch procedure call test to excludes part This makes sure that it won't be run during unit-tests Change-Id: I75333a557917d449c27836697773f1bbfe3b83b7 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/dal/pom.xml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Roy Golan: Looks good to me, approved Yair Zaslavsky: Verified -- To view, visit http://gerrit.ovirt.org/16056 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75333a557917d449c27836697773f1bbfe3b83b7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: Remove Java 7 construct in Frontend
by amureini＠redhat.com 25 Jun '13

25 Jun '13

Allon Mureinik has submitted this change and it was merged. Change subject: userportal,webadmin: Remove Java 7 construct in Frontend ...................................................................... userportal,webadmin: Remove Java 7 construct in Frontend - Frontend does not allow Java 7 constructs, so replaced it with a standard java 6 version. Change-Id: I79d7a8cff2cfbc8ea424b3f67266d34dbeb24b9a Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/BrandingServlet.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79d7a8cff2cfbc8ea424b3f67266d34dbeb24b9a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-node-plugin-vdsm[master]: pep8: over indented line fix
by mburns＠redhat.com 25 Jun '13

25 Jun '13

Michael Burns has submitted this change and it was merged. Change subject: pep8: over indented line fix ...................................................................... pep8: over indented line fix Change-Id: I00bc1f8532fcab4541aac982130acdba2b957150 Signed-off-by: Mike Burns <mburns(a)redhat.com> --- M src/engine_page.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Burns: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15171 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00bc1f8532fcab4541aac982130acdba2b957150 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Michael Burns <mburns(a)redhat.com> Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com>

1 0

Change in ovirt-node-plugin-vdsm[master]: move vdsm plugin code into dedicated directory
by mburns＠redhat.com 25 Jun '13

25 Jun '13

Michael Burns has submitted this change and it was merged. Change subject: move vdsm plugin code into dedicated directory ...................................................................... move vdsm plugin code into dedicated directory Change-Id: I8cb260d91c12629846b5f0fdd6bc30433c50ba4d Signed-off-by: Mike Burns <mburns(a)redhat.com> --- M ovirt-node-plugin-vdsm.spec.in M src/Makefile.am A src/__init__.py 3 files changed, 29 insertions(+), 3 deletions(-) Approvals: Douglas Schilling Landgraf: Looks good to me, but someone else must approve Michael Burns: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15140 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8cb260d91c12629846b5f0fdd6bc30433c50ba4d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Michael Burns <mburns(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: hide gluster-swift tab for non-gluster hosts
by kmayilsa＠redhat.com 24 Jun '13

24 Jun '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: hide gluster-swift tab for non-gluster hosts ...................................................................... webadmin: hide gluster-swift tab for non-gluster hosts 'Gluster Swift' sub-tab under 'Hosts' will be visible only if the select host belongs to gluster supported cluster. Also made following version checks - 'Cluster General-> Gluster Swift' visible if cluster version is >=3.3 - 'Gluster Hooks' sub-tab will be visible if cluster version is >=3.3 - 'Services' sub-tab will be visible if cluster version is >=3.2 Change-Id: Ied1cc8dc29bb62fa7fbd9378214a652d22627560 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterFeaturesUtil.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGeneralView.java 4 files changed, 51 insertions(+), 7 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied1cc8dc29bb62fa7fbd9378214a652d22627560 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: hide PM alert for gluster host
by kmayilsa＠redhat.com 24 Jun '13

24 Jun '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: hide PM alert for gluster host ...................................................................... webadmin: hide PM alert for gluster host PM not enabled warning('!' mark) will not be shown for the hosts which belongs to gluster-only cluster. Change-Id: I4af11175ee27cdbed2e11f242af936945c8e486c Bug-Url: https://bugzilla.redhat.com/955491 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/HostStatusCell.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4af11175ee27cdbed2e11f242af936945c8e486c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: remove unused constants and variables
by lhornyak＠redhat.com 24 Jun '13

24 Jun '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: remove unused constants and variables ...................................................................... engine: remove unused constants and variables removed a pair of unused constants and variables Change-Id: Ic478afb639389c887c6636f1007a684eb344a20e Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/Notifier.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15722 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic478afb639389c887c6636f1007a684eb344a20e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: remove single default constructor
by lhornyak＠redhat.com 24 Jun '13

24 Jun '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: remove single default constructor ...................................................................... engine: remove single default constructor removed single default constructor from CustomPropertiesValueHelper Change-Id: I733a1404a7fedd32e896d86690526ad817801c45 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/CustomPropertiesValueHelper.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15721 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I733a1404a7fedd32e896d86690526ad817801c45 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0