Change in ovirt-engine[master]: engine: simplify AppConfig
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: engine: simplify AppConfig
......................................................................
engine: simplify AppConfig
Since AppConfig does not have any subclasses, it's type parameter can be
removed.
Change-Id: If47b802876ec0b6021f2c3fdb73ba147749f3993
Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com>
---
M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/AppConfig.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java
2 files changed, 4 insertions(+), 8 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15720
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If47b802876ec0b6021f2c3fdb73ba147749f3993
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 10 months
Change in ovirt-engine[master]: engine: checkstyle enabled in tools project
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: engine: checkstyle enabled in tools project
......................................................................
engine: checkstyle enabled in tools project
- fixes all current checkstyle violations
- enables checkstyle plugin in tools project
Change-Id: Ifb2c95a9ee9777eebbd8a1e38d087cf48751a27c
Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com>
---
M backend/manager/tools/pom.xml
M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigMap.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/PasswordValueHelper.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/validation/ConfigActionType.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/validation/EngineConfigValidatorFactory.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/validation/SetValidator.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/EngineMonitorService.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/Notifier.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/methods/NotificationMethodMapBuilder.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/sender/mail/JavaMailSender.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/tools/common/db/StandaloneDataSource.java
M backend/manager/tools/src/test/java/org/ovirt/engine/core/config/EngineConfigLogicTest.java
M backend/manager/tools/src/test/java/org/ovirt/engine/core/config/EngineConfigValidatorTest.java
M backend/manager/tools/src/test/java/org/ovirt/engine/core/notifier/utils/NotificationPropertiesTest.java
M backend/manager/tools/src/test/java/org/ovirt/engine/core/notifier/utils/mail/MailSenderTest.java
18 files changed, 11 insertions(+), 33 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15719
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb2c95a9ee9777eebbd8a1e38d087cf48751a27c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 10 months
Change in ovirt-engine[master]: core: RemoveDiskParameters - don't use Entity ID
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: RemoveDiskParameters - don't use Entity ID
......................................................................
core: RemoveDiskParameters - don't use Entity ID
Changed RemoveDiskParameters to stop using Entity ID (which should only
be used by Async Tasks related classes) and instead added a diskId
member.
All current usages were fixed to use the new member.
Change-Id: I70dabec5d542c343cbaf71b1a4fdb58b4ec970ff
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveDiskParameters.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDisksResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResourceTest.java
4 files changed, 21 insertions(+), 12 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15956
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I70dabec5d542c343cbaf71b1a4fdb58b4ec970ff
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 10 months
Change in ovirt-reports[master]: packaging: fixed war removal on package removal (#977360)
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: fixed war removal on package removal (#977360)
......................................................................
packaging: fixed war removal on package removal (#977360)
Bug-Url: https://bugzilla.redhat.com/977360
Change-Id: I3c2112f146aa2d6974dbc68d7aae16b325374062
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
---
M packaging/ovirt-engine-reports.spec.in
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Alex Lourie: Looks good to me, but someone else must approve
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16042
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3c2112f146aa2d6974dbc68d7aae16b325374062
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: findbugs - check for null on a already dereferenced variable
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: findbugs - check for null on a already dereferenced variable
......................................................................
findbugs - check for null on a already dereferenced variable
No need to check for null, as it cannot be null.
Change-Id: I86f454d2cff51b249745fb508ff547528538a21c
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Roy Golan: Looks good to me, approved
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16034
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I86f454d2cff51b249745fb508ff547528538a21c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: Introducing Batch updates to DAOs
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Introducing Batch updates to DAOs
......................................................................
core: Introducing Batch updates to DAOs
The following patch introduces the ability to perform a batch update
Due to the fact spring-jdbc does not "natively" support postgresql we had
to query the stored procedures meta-data on our own.
Change-Id: If5ee0aa90bca3b5c257beb7b0eaa236f02f0206f
Signed-off-by: Liran Zelkha <liran.zelkha(a)gmail.com>
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/BatchProcedureExecutionConnectionCallback.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbEngineDialect.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/PostgresDbEngineDialect.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/SimpleJdbcCallsHandler.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/SqlCallParameter.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/StoredProcToTypeMapping.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/StoredProcedureMetaData.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoDbFacadeImpl.java
A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BatchProcedureCallTest.java
9 files changed, 452 insertions(+), 13 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15039
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If5ee0aa90bca3b5c257beb7b0eaa236f02f0206f
Gerrit-PatchSet: 21
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <liran.zelkha(a)gmail.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 10 months
Change in ovirt-engine[master]: packaging: setup: add "action" to otopi environment
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: setup: add "action" to otopi environment
......................................................................
packaging: setup: add "action" to otopi environment
Added "action" - currently setup or cleanup - to otopi environment,
to allow common code know what action is being done.
Change-Id: Ic34515956e7a374a8c255d6526f47603adda0bb5
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/constants.py
M packaging/setup/plugins/ovirt-engine-remove/core/misc.py
M packaging/setup/plugins/ovirt-engine-setup/core/misc.py
3 files changed, 10 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15915
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic34515956e7a374a8c255d6526f47603adda0bb5
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: refactoring VdsSelector API
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: refactoring VdsSelector API
......................................................................
core: refactoring VdsSelector API
Host selection should become stateless, therefore moving failed host
list out of this class (vdsBlackList), and pass it as a parameter.
In addition, each vdsSelector call should supply a list of hosts
that the selector should 'work' on.
new VdsSelector API:
// for Validation purposes
canFindVdsToRunOn(List<VDS> vdsList,
List<Guid> vdsBlackList,
List<String> messages,
boolean isMigrate)
// for selecting a host to run on
Guid getVdsToRunOn(List<VDS> vdsList,
List<Guid> vdsBlackList,
boolean isMigrate)
Gerrit-cntr: 1
Change-Id: I6d936e1b96628e426e944d77730e3ca08a1357ee
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/VdsSelector.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java
7 files changed, 109 insertions(+), 76 deletions(-)
Approvals:
Laszlo Hornyak: Looks good to me, approved
Gilad Chaplik: Verified
--
To view, visit http://gerrit.ovirt.org/16030
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d936e1b96628e426e944d77730e3ca08a1357ee
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: fix method names
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: fix method names
......................................................................
core: fix method names
Change-Id: I4612e4392400b0951423192756649c31d5eec1e3
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceQueryBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsFenceStatusQuery.java
2 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16028
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4612e4392400b0951423192756649c31d5eec1e3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: engine: include VdsGroup virt, gluster flags in VDS entity
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: engine: include VdsGroup virt, gluster flags in VDS entity
......................................................................
engine: include VdsGroup virt, gluster flags in VDS entity
Added virt_service and gluster_service flags to VDS entity.
VDS view is modified accordingly to read these flags from
vds_groups table.
Change-Id: I961a37312425213fdbce446001fd2874f7661cd1
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M backend/manager/dbscripts/create_views.sql
M backend/manager/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
5 files changed, 37 insertions(+), 2 deletions(-)
Approvals:
Kanagaraj M: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15636
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I961a37312425213fdbce446001fd2874f7661cd1
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 10 months