June 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: history: added vm's client ip to dwh views (#873790)
by yzaslavs＠redhat.com 24 Jun '13

24 Jun '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: history: added vm's client ip to dwh views (#873790) ...................................................................... history: added vm's client ip to dwh views (#873790) Bug-Url: https://bugzilla.redhat.com/873790 Change-Id: Ibb75a526070214ff6f909692d5f099367fb4eda3 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M backend/manager/dbscripts/create_dwh_views.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16008 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb75a526070214ff6f909692d5f099367fb4eda3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-dwh[master]: packaging: Added backup DB functionality to setup
by ydary＠redhat.com 24 Jun '13

24 Jun '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: Added backup DB functionality to setup ...................................................................... packaging: Added backup DB functionality to setup This patch adds user interaction asking to perform the backup of the DB before performing an upgrade. Prior to that it checks the available space and the size of the DB and prompts the user with option to perform the backup. Change-Id: I8ccf8938099207b4e73bb947d1bb5fd673605071 Bug-Url: https://bugzilla.redhat.com/910070 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/common_utils.py M packaging/ovirt-engine-dwh-setup.py 2 files changed, 233 insertions(+), 5 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15772 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ccf8938099207b4e73bb947d1bb5fd673605071 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: refactored host/cluster general tab mode checks
by kmayilsa＠redhat.com 24 Jun '13

24 Jun '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: refactored host/cluster general tab mode checks ...................................................................... webadmin: refactored host/cluster general tab mode checks With the recent enhancements to form related tabs, an empty line is shown for the form items which are not added to the formpanel. For example "libvirt version" form item won't be added to formpanel if the application is not running in virt supported mode. This leaves an empty line between the previous and next row's form items. The code is refactored to make use of the setIsAvailable() method of FormItem instead leaving out the formitem itself. Change-Id: I1e57336b819ee12b66d5f22589b4b85470e1be5c Bug-Url: https://bugzilla.redhat.com/973607 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/FormItem.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/ClusterGeneralModelForm.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralView.java 3 files changed, 56 insertions(+), 75 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15947 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e57336b819ee12b66d5f22589b4b85470e1be5c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: dos2unix VdsmErrors.properties
by rgolan＠redhat.com 24 Jun '13

24 Jun '13

Roy Golan has submitted this change and it was merged. Change subject: core: dos2unix VdsmErrors.properties ...................................................................... core: dos2unix VdsmErrors.properties Run dos2unix on VdsmErrors.properties to remove the pesky \rs. Change-Id: I4d56640e68e6e13f250669323b7216883f3f90a7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties 1 file changed, 367 insertions(+), 367 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16020 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d56640e68e6e13f250669323b7216883f3f90a7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: adding OvfHelper
by rgolan＠redhat.com 24 Jun '13

24 Jun '13

Roy Golan has submitted this change and it was merged. Change subject: core: adding OvfHelper ...................................................................... core: adding OvfHelper OvfHelper is a helper class that encapsulates the bll logic that needs to be done on the ovf read data before using it in the bll project. Change-Id: I3bfc4094178d90e7b0583db4e427fc2b195a367d Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetVmsFromExportDomainQuery.java 2 files changed, 60 insertions(+), 26 deletions(-) Approvals: Roy Golan: Looks good to me, approved Liron Ar: Verified -- To view, visit http://gerrit.ovirt.org/15626 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3bfc4094178d90e7b0583db4e427fc2b195a367d Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: adjustments of the VM based dialogs
by tjelinek＠redhat.com 24 Jun '13

24 Jun '13

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal,webadmin: adjustments of the VM based dialogs ...................................................................... userportal,webadmin: adjustments of the VM based dialogs - moved the advanced button to left side - changed the tab indexes Change-Id: I45ab39f4663930f92492e147bb21294c0506fe14 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractModelBoundPopupView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractVmPopupView.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/LeftAlignedUiCommandButton.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmBasedWidgetSwitchModeCommand.java 6 files changed, 43 insertions(+), 5 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15199 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45ab39f4663930f92492e147bb21294c0506fe14 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: NPE on PoolListModel
by tjelinek＠redhat.com 24 Jun '13

24 Jun '13

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: NPE on PoolListModel ...................................................................... webadmin: NPE on PoolListModel The 1cf05c520c3e30f68ac12b5772a251aa78d46bbd did bring a regression because it expected that the disks can not be null, but they actually can be. Added a null check. Change-Id: I9f26ef2ab847cfec13bf13852e7c0647889183cb Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15974 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f26ef2ab847cfec13bf13852e7c0647889183cb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Add OpenStack Net support to vNIC hotplug
by mkolesni＠redhat.com 24 Jun '13

24 Jun '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Add OpenStack Net support to vNIC hotplug ...................................................................... engine: Add OpenStack Net support to vNIC hotplug Now it should be possible to hot-plug a vNIC that is attached to an OpenStack provided network. Change-Id: I0a893f4a1818fef1926d0a29df191fec2c4379b9 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugNicVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 3 files changed, 46 insertions(+), 9 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16005 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a893f4a1818fef1926d0a29df191fec2c4379b9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Allow non auth provider to add network
by mkolesni＠redhat.com 24 Jun '13

24 Jun '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Allow non auth provider to add network ...................................................................... engine: Allow non auth provider to add network Non authenticated providers require that a tenant ID is sent for the new network. Currently sending the DEVICE_OWNER value, might change in the future. Change-Id: I7c325429adc845f1bcd4e99a4179202852a222e8 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/OpenstackNetworkProviderProxy.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c325429adc845f1bcd4e99a4179202852a222e8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Add keystone support in Openstack Network
by mkolesni＠redhat.com 24 Jun '13

24 Jun '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Add keystone support in Openstack Network ...................................................................... engine: Add keystone support in Openstack Network Openstack network provider can now authenticate via Keystone. Change-Id: I4a7c455f8e5063c9e5fb1ac993b3c521961489b8 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/OpenstackNetworkProviderProxy.java 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15372 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a7c455f8e5063c9e5fb1ac993b3c521961489b8 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0