June 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: OvfReader- setPlugged for disks
by amureini＠redhat.com 18 Jun '13

18 Jun '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: OvfReader- setPlugged for disks ...................................................................... core: OvfReader- setPlugged for disks When reading disks data of vm from an ovf file, set "plugged" to have the correct value from the ovf. Change-Id: I0a2223533530e84ebe007f64d4e571ca6213d29c Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveImageCommandTest.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java 3 files changed, 6 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15767 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a2223533530e84ebe007f64d4e571ca6213d29c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: avoid unneeded lock when moving a disk
by amureini＠redhat.com 18 Jun '13

18 Jun '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: avoid unneeded lock when moving a disk ...................................................................... core: avoid unneeded lock when moving a disk When moving a disk, as the copy operation ends the engine attempts to delete the source/target images (depending on whether the copy operation has failed or succeeded) - while performing the remove operation the disk shouldn't be locked (in the database) as it's already locked by the parent command. Change-Id: I0fed4563bdb0c245f485e64bcad61f8980e17ebe Signed-off-by: Liron Aravot <laravot(a)redhat.com> Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveImageGroupCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15814 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0fed4563bdb0c245f485e64bcad61f8980e17ebe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi : call to show files on iso domain no longer shows a...
by mpastern＠redhat.com 18 Jun '13

18 Jun '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : call to show files on iso domain no longer shows all files ...................................................................... restapi : call to show files on iso domain no longer shows all files /api/storagedomain/xxx/files does not show all files, only shows iso files. Change-Id: I31d305baaa28e5c0f0b918e497197dbd7b0e496e Bug-Url: https://bugzilla.redhat.com/949261 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendFilesResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendFilesResourceTest.java 2 files changed, 13 insertions(+), 13 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13730 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31d305baaa28e5c0f0b918e497197dbd7b0e496e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: change path of console descriptors
by tjelinek＠redhat.com 18 Jun '13

18 Jun '13

Tomas Jelinek has submitted this change and it was merged. Change subject: engine: change path of console descriptors ...................................................................... engine: change path of console descriptors This patch changes the path from which console descriptors are served (from console/console.* to ovirt-engine-attachment/console.*). The configuration of apache proxy is modified accordingly. Change-Id: Ib35c02a8edb1dd638d4062e4e33854b4df139547 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java M packaging/conf/ovirt-engine-proxy.conf.in 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/15727 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib35c02a8edb1dd638d4062e4e33854b4df139547 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: hide DC in Clusters tab in gluster-only mode
by kmayilsa＠redhat.com 18 Jun '13

18 Jun '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: hide DC in Clusters tab in gluster-only mode ...................................................................... webadmin: hide DC in Clusters tab in gluster-only mode 'Data Center' column of 'Clusters' main tab will be hidden if application is running in GlusterOnly mode . Change-Id: I5a771714304727fb133b3dd4dbe5311de4f6a283 Bug-Url: https://bugzilla.redhat.com/955464 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabClusterView.java 1 file changed, 9 insertions(+), 7 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15793 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a771714304727fb133b3dd4dbe5311de4f6a283 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: Correct event log message for sync job
by kmayilsa＠redhat.com 18 Jun '13

18 Jun '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Correct event log message for sync job ...................................................................... gluster: Correct event log message for sync job Corrected the event log message to show volume option value as well during setting of options from CLI. Change-Id: I1f431f9c748dfde9516514a15b209b99b7740ee6 Bug-Url: https://bugzilla.redhat.com/956000 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15159 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f431f9c748dfde9516514a15b209b99b7740ee6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Save VDSM information about HBA devices
by lhornyak＠redhat.com 18 Jun '13

18 Jun '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: Save VDSM information about HBA devices ...................................................................... engine: Save VDSM information about HBA devices This patch adds the necessary infrastructure for getting and saving the list of HBA (iSCSI, FC) devices in the engine. Change-Id: I8512f30c795690edc46838c0eb422013871b35f9 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql A backend/manager/dbscripts/upgrade/03_03_0210_add_hbas_col.sql M backend/manager/dbscripts/vds_sp.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializationEntitiesTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java 10 files changed, 72 insertions(+), 16 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14141 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8512f30c795690edc46838c0eb422013871b35f9 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: handle a yum error when no groups
by juan.hernandez＠redhat.com 17 Jun '13

17 Jun '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: setup: handle a yum error when no groups ...................................................................... packaging: setup: handle a yum error when no groups apparently, when querying yum for group, if no groups at all it raises an exception instead of return empty set. this is unexpected behavior of an api. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=973383 Change-Id: Ifb1f196006662d6571c7ca80554e0a9a17aaec2a Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/miniyum.py 1 file changed, 7 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15665 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb1f196006662d6571c7ca80554e0a9a17aaec2a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: Suspicious reference comparison of Boolean values
by shavivi＠redhat.com 17 Jun '13

17 Jun '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: Suspicious reference comparison of Boolean values ...................................................................... findbugs: Suspicious reference comparison of Boolean values commit dcc771b2ad21bea0caecaef79cf26daaa8ecc229 fix reference comparison of Boolean values. I GWT debugging we are getting NPE because the new comparison of consoleAddressPartiallyOverridden null value to false, hence not setting it to false. This patch add default value to false and change the isConsoleAddressPartiallyOverridden() to return false instead of null Change-Id: I81405b5484dcfcaa4e7f90279e076cad5f085581 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGeneralModel.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81405b5484dcfcaa4e7f90279e076cad5f085581 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi : during deleting disk an error in log “Could not fi...
by mpastern＠redhat.com 17 Jun '13

17 Jun '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : during deleting disk an error in log “Could not find sub-resource in the collection resource" ...................................................................... restapi : during deleting disk an error in log “Could not find sub-resource in the collection resource" During deleting disk there is an error logged into engine.log “Could not find sub-resource in the collection resource" The operation succeeds but there is an error message in log Change-Id: I1be9c02b2aadd7e59371e1cca1ed531964039e7a Bug-Url: https://bugzilla.redhat.com/973751 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDisksResource.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15632 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1be9c02b2aadd7e59371e1cca1ed531964039e7a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0