Change in ovirt-engine[master]: core: Power Management failed if no proxy ...
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Power Management failed if no proxy ...
......................................................................
core: Power Management failed if no proxy ...
core: Power Management failed if no proxy preferences is defined for the host
Power Management failed if no pm_proxy preferences is defined for the
host.
The pm_proxy_preferences is a per-host field in vds_static that defines
how to look for a proxy host. (cluster then DC or vice versa)
In case that pm_proxy preference is not defined , it should be taken
from the FenceProxyDefaultPreferences configuration value which is
defaulted to "cluster,dc"
However, the code that checks for existence of pm_proxy preferences
checks for null only and if it is an empty string , it is used
The error on the log is :
2013-06-02 13:04:25,013 ERROR [org.ovirt.engine.core.bll.FenceExecutor]
Illegal value in PM Proxy Preferences string , skipped
Change-Id: Id1b96b115dc586e6ebbdacd44e0a034e91609841
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=969778
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15274
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id1b96b115dc586e6ebbdacd44e0a034e91609841
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-host-deploy[master]: core: modify copyright of base po
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: modify copyright of base po
......................................................................
core: modify copyright of base po
Change-Id: I07d755cd498084d9ec1f8d48c2e4297ded8d2ee2
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M po/Makevars
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15291
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I07d755cd498084d9ec1f8d48c2e4297ded8d2ee2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
10 years, 10 months
Change in otopi[master]: core: modify copyright of base po
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: modify copyright of base po
......................................................................
core: modify copyright of base po
Change-Id: I5b2d97d18b2fac3a15920da1bb5f6fc547f336aa
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M po/Makevars
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15292
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5b2d97d18b2fac3a15920da1bb5f6fc547f336aa
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
10 years, 10 months
Change in ovirt-engine[master]: core: Fix quota count for Template with multiple SD
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: core: Fix quota count for Template with multiple SD
......................................................................
core: Fix quota count for Template with multiple SD
When deleting a template which have a multiple domain disk, the disk
size was only released from the quota once.
RemoveVmTemplateCommand was changed to support multiple storage domain
disks when removing templates.
Change-Id: Id2f5051218405753dc86b997aaa47f488f159350
Bug-Url: https://bugzilla.redhat.com/963587
Signed-off-by: Ofri Masad <omasad(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java
1 file changed, 8 insertions(+), 6 deletions(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15278
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id2f5051218405753dc86b997aaa47f488f159350
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
10 years, 11 months
Change in ovirt-engine-cli[master]: cli: rhevm-shell should contain the hostname of the system #...
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: rhevm-shell should contain the hostname of the system #866319
......................................................................
cli: rhevm-shell should contain the hostname of the system #866319
Change-Id: Iea827ff9a5180ac8049bbcb3c639707f841b5901
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=866319
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
---
M src/ovirtcli/context.py
M src/ovirtcli/options.py
M src/ovirtcli/settings.py
M src/ovirtcli/shell/engineshell.py
4 files changed, 23 insertions(+), 7 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15275
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iea827ff9a5180ac8049bbcb3c639707f841b5901
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
10 years, 11 months
Change in ovirt-engine[master]: findbugs: inefficient use of String constructor
by shavivi＠redhat.com
Shahar Havivi has submitted this change and it was merged.
Change subject: findbugs: inefficient use of String constructor
......................................................................
findbugs: inefficient use of String constructor
Using the java.lang.String(String) constructor wastes
memory because the object so constructed will be functionally
indistinguishable from the String passed as a parameter.
Use the argument String directly.
findbugs reason:
Dm: Method invokes inefficient new String(String) constructor (DM_STRING_CTOR)
Change-Id: I96b98c508f2ca60daed60be6ec29db35c2016bb3
Signed-off-by: Shahar Havivi <shavivi(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Uri.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/UriAuthority.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/UrlValidation.java
3 files changed, 9 insertions(+), 9 deletions(-)
Approvals:
Shahar Havivi: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15277
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I96b98c508f2ca60daed60be6ec29db35c2016bb3
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
10 years, 11 months
Change in ovirt-engine[master]: core: ticket utils: use SecureRandom
by shavivi＠redhat.com
Shahar Havivi has submitted this change and it was merged.
Change subject: core: ticket utils: use SecureRandom
......................................................................
core: ticket utils: use SecureRandom
I had a glance at java implementation of basic Random, and it is bad for
us to generate the salt. So I suggest to use SecureRandom instead.
Change-Id: Idaaf8b9cc4c4afeb62d5ad5ba86fcb4878de09a8
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/TicketUtils.java
1 file changed, 3 insertions(+), 4 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Shahar Havivi: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15280
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idaaf8b9cc4c4afeb62d5ad5ba86fcb4878de09a8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
10 years, 11 months
Change in ovirt-engine[master]: webadmin: Gluster Hooks - conflict resolution popup
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: webadmin: Gluster Hooks - conflict resolution popup
......................................................................
webadmin: Gluster Hooks - conflict resolution popup
New Action 'Resolve Conflicts' is added to gluster hooks tab.
This action will be enabled if the hook is not in sync in the
hosts of the cluster and engine. Engine copy of the hook will
be considered as a Master copy.
On clicking 'Resolve Conflicts', a popup will be shown explaining
the reason for the conflict. The conflict could be any one/mutiple of
the following
1.MISMATCH IN CONTENT - hook content is different across hosts
2.MISMATCH IN STATUS - hook status is different across hosts
3.MISSING HOOK - hook is not present in some hosts
The user will be able to view the content and status of the hook from different
sources (hosts and Engine).
Finally the user can select the resole actions which will resolve the conflicts.
Change-Id: I10bc9c7dba7cb1be320bb0e12f3b7bf7a8beb485
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGlusterHookListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/GlusterHookContentModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/GlusterHookResolveConflictsModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/ClusterModule.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/cluster/GlusterHookResolveConflictsPopupPresenterWidget.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/GlusterHookResolveConflictsPopupView.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/GlusterHookResolveConflictsPopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGlusterHookView.java
12 files changed, 1,055 insertions(+), 6 deletions(-)
Approvals:
Kanagaraj M: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11839
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I10bc9c7dba7cb1be320bb0e12f3b7bf7a8beb485
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
10 years, 11 months
Change in ovirt-engine[master]: findbugs: ignore: use Sytesm.exit only in appropriate places
by shavivi＠redhat.com
Shahar Havivi has submitted this change and it was merged.
Change subject: findbugs: ignore: use Sytesm.exit only in appropriate places
......................................................................
findbugs: ignore: use Sytesm.exit only in appropriate places
findbugs warns about using System.exit() only in appropriate places.
in this case we do need to use exit().
look at exclude-filters.xml for more details
Change-Id: Ia3bd1a72e5f7b78cbea10066d9e6490bee2ade86
Signed-off-by: Shahar Havivi <shavivi(a)redhat.com>
---
M backend/manager/modules/utils/exclude-filters.xml
M backend/manager/tools/exclude-filters.xml
2 files changed, 27 insertions(+), 0 deletions(-)
Approvals:
Shahar Havivi: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15273
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3bd1a72e5f7b78cbea10066d9e6490bee2ade86
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
10 years, 11 months
Change in ovirt-engine[master]: findbugs: ignore: generate GWT class get findbugs Boolean co...
by shavivi＠redhat.com
Shahar Havivi has submitted this change and it was merged.
Change subject: findbugs: ignore: generate GWT class get findbugs Boolean constructor warning
......................................................................
findbugs: ignore: generate GWT class get findbugs Boolean constructor warning
findbugs complain of using Boolean constructor instead of Boolean.valueOf
This calss is GWT generated code
findbugs reason:
Dm: Method invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead (DM_BOOLEAN_CTOR)
Change-Id: I006a4465cf236858c17f6be5cc27e9d811c084f9
Signed-off-by: Shahar Havivi <shavivi(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/exclude-filters.xml
M frontend/webadmin/modules/webadmin/exclude-filters.xml
2 files changed, 39 insertions(+), 0 deletions(-)
Approvals:
Shahar Havivi: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15272
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I006a4465cf236858c17f6be5cc27e9d811c084f9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
10 years, 11 months
