Change in ovirt-engine[master]: userportal, webadmin: Frontend refactor
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: userportal,webadmin: Frontend refactor
......................................................................
userportal,webadmin: Frontend refactor
- Minor refactor to allow unit testing.
- Added unit tests for all major public methods.
Change-Id: I3dae5a455ad16660b97cddafba53b53d3b4196f1
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/IFrontendEventsHandler.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java
A frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/FrontendActionTest.java
A frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/FrontendTest.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendEventsHandlerImpl.java
6 files changed, 1,588 insertions(+), 142 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15399
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3dae5a455ad16660b97cddafba53b53d3b4196f1
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 9 months
Change in ovirt-engine[master]: core: i18n welcome page with branding
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: core: i18n welcome page with branding
......................................................................
core: i18n welcome page with branding
- Updated welcome page to take branding into account.
- Added ability to add multiple sections with links.
- Updated styles to take branding into account.
- Created new resource bundle for welcome page based on
branding manager.
- Added new application type to BrandingTheme, 'welcome'
- Added ability to put header text at top of welcome page.
Change-Id: I9987ed58c2e0ead9b25c5f46fb974a96bfd46d30
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=838456
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M README.branding
M backend/manager/modules/root/pom.xml
D backend/manager/modules/root/src/main/java/org/ovirt/engine/core/SplashServlet.java
A backend/manager/modules/root/src/main/java/org/ovirt/engine/core/WelcomeServlet.java
D backend/manager/modules/root/src/main/resources/org/ovirt/engine/core/messages.properties
M backend/manager/modules/root/src/main/webapp/WEB-INF/ovirt-engine.jsp
M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml
R backend/manager/modules/root/src/test/java/org/ovirt/engine/core/WelcomeServletTest.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/branding/BrandingManager.java
R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/branding/BrandingServlet.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/branding/BrandingTheme.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/branding/BrandingWelcomeResourceBundle.java
R backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/branding/BrandingServletTest.java
M frontend/webadmin/modules/frontend/src/main/resources/META-INF/web-fragment.xml
M packaging/branding/ovirt.brand/branding.properties
R packaging/branding/ovirt.brand/images/triangle_down_gray.gif
R packaging/branding/ovirt.brand/images/welcome/bg_head.gif
R packaging/branding/ovirt.brand/images/welcome/bg_main.gif
R packaging/branding/ovirt.brand/images/welcome/logo.png
M packaging/branding/ovirt.brand/messages.properties
A packaging/branding/ovirt.brand/welcome_page.template
R packaging/branding/ovirt.brand/welcome_style.css
22 files changed, 411 insertions(+), 112 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16359
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9987ed58c2e0ead9b25c5f46fb974a96bfd46d30
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 9 months
Change in ovirt-node-plugin-vdsm[master]: bump release to -4
by mburns＠redhat.com
Michael Burns has submitted this change and it was merged.
Change subject: bump release to -4
......................................................................
bump release to -4
Change-Id: If1296a78b69bfdb5a2c5fe3b61d0f78734e8df23
Signed-off-by: Mike Burns <mburns(a)redhat.com>
---
M ovirt-node-plugin-vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Michael Burns: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17355
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If1296a78b69bfdb5a2c5fe3b61d0f78734e8df23
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: master
Gerrit-Owner: Michael Burns <mburns(a)redhat.com>
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com>
10 years, 9 months
Change in ovirt-node-plugin-vdsm[master]: ensure NetworkManager is disabled in F19
by mburns＠redhat.com
Michael Burns has submitted this change and it was merged.
Change subject: ensure NetworkManager is disabled in F19
......................................................................
ensure NetworkManager is disabled in F19
Change-Id: I865fb014104aef16510daf3a535e705a72d78709
Signed-off-by: Mike Burns <mburns(a)redhat.com>
---
M ovirt-node-plugin-vdsm.spec.in
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Michael Burns: Verified; Looks good to me, approved
Antoni Segura Puimedon: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/17351
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I865fb014104aef16510daf3a535e705a72d78709
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: master
Gerrit-Owner: Michael Burns <mburns(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com>
10 years, 9 months
Change in ovirt-node-plugin-vdsm[master]: update some of the kickstart/recipes
by mburns＠redhat.com
Michael Burns has submitted this change and it was merged.
Change subject: update some of the kickstart/recipes
......................................................................
update some of the kickstart/recipes
it was not including the plugin rpm, so no vdsm
Change-Id: I01208cb1d19fbabd2f6dd11d9bfc5e7c0f2a840c
Signed-off-by: Mike Burns <mburns(a)redhat.com>
---
M ovirt-node-plugin-vdsm.spec.in
M recipe/vdsm-plugin-iso.ks
2 files changed, 5 insertions(+), 1 deletion(-)
Approvals:
Michael Burns: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17281
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I01208cb1d19fbabd2f6dd11d9bfc5e7c0f2a840c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: master
Gerrit-Owner: Michael Burns <mburns(a)redhat.com>
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 9 months
Change in ovirt-engine[master]: host-deploy: rephrase authentication error text
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: host-deploy: rephrase authentication error text
......................................................................
host-deploy: rephrase authentication error text
Change-Id: If26f7e7aafeed6ec1dc1ba13f038415fe4f2e40b
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHClient.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17283
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If26f7e7aafeed6ec1dc1ba13f038415fe4f2e40b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 9 months
Change in ovirt-engine[master]: frontend: Add custom field serializer for RepoImage
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: frontend: Add custom field serializer for RepoImage
......................................................................
frontend: Add custom field serializer for RepoImage
This is a workaround to resolve some current issues with GWT RPC
serialization.
Change-Id: I137d47dee58dce90a66a3c4accfe75e146223749
Bug-Url: https://bugzilla.redhat.com/988021
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
A frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/common/businessentities/RepoImage_CustomFieldSerializer.java
1 file changed, 51 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17330
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I137d47dee58dce90a66a3c4accfe75e146223749
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 9 months
Change in ovirt-engine[master]: fix tiny typo
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: fix tiny typo
......................................................................
fix tiny typo
Change-Id: Ib1a6698279a6fe799be3ffee1f0c59fc1add9646
Bug-Url: https://bugzilla.redhat.com/988017
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sergey Gotliv: Looks good to me, but someone else must approve
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17325
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1a6698279a6fe799be3ffee1f0c59fc1add9646
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 9 months
Change in otopi[master]: packagers: yum: do not use yum state strings
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packagers: yum: do not use yum state strings
......................................................................
packagers: yum: do not use yum state strings
the yum.i18n produces non standard string encoding, encoded using ansi
codec but has unicode string, while the locale environment is set to
unicode, and python does enforce proper unicode in string.format().
the solution is to provide our own translation table for transaction
status, as no [simple] way was found to convert the non standard format
into unicode.
Change-Id: If230a17799263e705f194f180af04bf2904a5d90
Reported-By: Jakub Bittner <j.bittner(a)nbu.cz>
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M ChangeLog
M src/otopi/miniyum.py
2 files changed, 27 insertions(+), 13 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17326
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If230a17799263e705f194f180af04bf2904a5d90
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
10 years, 9 months
Change in mom[master]: Fix a typo in a variable name unuused -> unused
by agl＠us.ibm.com
Adam Litke has submitted this change and it was merged.
Change subject: Fix a typo in a variable name unuused -> unused
......................................................................
Fix a typo in a variable name unuused -> unused
Change-Id: I09cd74173642bcaeb94fb3528485f912e6f56434
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/17217
Reviewed-by: Doron Fediuck <dfediuck(a)redhat.com>
Reviewed-by: Adam Litke <agl(a)us.ibm.com>
Tested-by: Adam Litke <agl(a)us.ibm.com>
---
M mom/Collectors/HostMemory.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Adam Litke: Verified; Looks good to me, approved
Doron Fediuck: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/17217
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I09cd74173642bcaeb94fb3528485f912e6f56434
Gerrit-PatchSet: 5
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
10 years, 9 months