July 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: fix the hierarchy of memory images removers
by ofrenkel＠redhat.com 25 Jul '13

25 Jul '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix the hierarchy of memory images removers ...................................................................... core: fix the hierarchy of memory images removers The "RAM Snapshots" feature introduced the MemoryImageRemover and MemoryImageRemoverFromExportDomain classes. The second inherits the first, taking advantage of common code and making small adjustments that are required when it comes to operating on the export domain. We end up with a wrong relationship between the two classes as there is no relation of "kind of" between them, thus the inheritence is wrong. This patch fix the hierarchy between them: 1. MemoryImageRemover become an abstract class, containing the common code for subclasses that remove memory states 2. introduce MemoryImageRemoverOnDataDomain class which extends MemoryImageRemover and implements the code that is relevant for removing memory states from data domains 3. The MemoryImageRemoverFromExportDomain now extends MemoryImageRemover and implements the code which is relevant for removing memory states from export domains ImportVmCommand is changed to use MemoryImageRemoverOnDataDomain instead of using MemoryImageRemover. Change-Id: Id7cada7b6f9a3356afcac0dd2856d6a02cf1f9fd Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemover.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemoverFromExportDomain.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemoverOnDataDomain.java 4 files changed, 82 insertions(+), 44 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16826 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7cada7b6f9a3356afcac0dd2856d6a02cf1f9fd Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in mom[master]: Make sure the balloon info uses numbers when provided by VDS...
by agl＠us.ibm.com 25 Jul '13

25 Jul '13

Adam Litke has submitted this change and it was merged. Change subject: Make sure the balloon info uses numbers when provided by VDSM ...................................................................... Make sure the balloon info uses numbers when provided by VDSM VDSM needs to strings for transporting large numeric values over xml-rpc. Make sure MoM can properly process those. The GuestBalloon collector has to filter the fields as well to only export the required numbers to the Monitor. VDSM added balloon_target that we do not need here. Change-Id: I74b227a5d945397a69702fc0758d864b33014fc6 Signed-off-by: Martin Sivak <msivak(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/17207 Reviewed-by: Adam Litke <agl(a)us.ibm.com> --- M mom/Collectors/GuestBalloon.py M mom/HypervisorInterfaces/vdsmInterface.py 2 files changed, 14 insertions(+), 0 deletions(-) Approvals: Adam Litke: Looks good to me, approved Martin Sivák: Verified -- To view, visit http://gerrit.ovirt.org/17207 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74b227a5d945397a69702fc0758d864b33014fc6 Gerrit-PatchSet: 5 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: vdsm: packages: do not re-start network service
by Alon Bar-Lev 25 Jul '13

25 Jul '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: packages: do not re-start network service ...................................................................... vdsm: packages: do not re-start network service rhel does not like re-start (second start) of network service. it fails on various of errors. Change-Id: I98853de084666d689f5a3d214bf4626d4a4149dc Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/plugins/ovirt-host-deploy/vdsm/packages.py 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, approved Antoni Segura Puimedon: Looks good to me, but someone else must approve David Caro: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/17321 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98853de084666d689f5a3d214bf4626d4a4149dc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Allow editing unplugged disk in UI
by derez＠redhat.com 25 Jul '13

25 Jul '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Allow editing unplugged disk in UI ...................................................................... webadmin: Allow editing unplugged disk in UI "Edit" button under VM => Disks is disabled after disk was unplugged from VM. It should be enabled as it was before 3.3. Change-Id: Ia128fe1dbe74be608d27737146d575c52e131c56 Bug-Url: https://bugzilla.redhat.com/988061 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java 3 files changed, 27 insertions(+), 11 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17292 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia128fe1dbe74be608d27737146d575c52e131c56 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-node-plugin-vdsm[master]: switch to ovirt-host-deploy-offline
by mburns＠redhat.com 25 Jul '13

25 Jul '13

Michael Burns has submitted this change and it was merged. Change subject: switch to ovirt-host-deploy-offline ...................................................................... switch to ovirt-host-deploy-offline instead of ovirt-host-deploy Change-Id: I48a809429b1cb02c320a910fda539290eab5af1d Signed-off-by: Mike Burns <mburns(a)redhat.com> --- M ovirt-node-plugin-vdsm.spec.in 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Michael Burns: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17293 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48a809429b1cb02c320a910fda539290eab5af1d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Michael Burns <mburns(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: bin: add --check-liveliness support
by sbonazzo＠redhat.com 25 Jul '13

25 Jul '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: bin: add --check-liveliness support ...................................................................... bin: add --check-liveliness support Refactored the healt checking plugin creating a shared module for checking the engine liveliness. Adedd --check-liveliness support calling the new module. Change-Id: If146459d62815dcf030fcd151b61faddb6af8be9 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/bin/hosted-engine.in M src/ovirt_hosted_engine_setup/Makefile.am A src/ovirt_hosted_engine_setup/check_liveliness.py M src/plugins/ovirt-hosted-engine-setup/engine/health.py 4 files changed, 112 insertions(+), 29 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Alex Lourie: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/16953 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If146459d62815dcf030fcd151b61faddb6af8be9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: ovirt-hosted-engine-setup in sbin
by sbonazzo＠redhat.com 25 Jul '13

25 Jul '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: ovirt-hosted-engine-setup in sbin ...................................................................... packaging: ovirt-hosted-engine-setup in sbin Added ovirt-hosted-engine-setup in sbin directory. Change-Id: I2a2347abe5f7deb4e976abbbe48e7fd9eb7c78f7 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-hosted-engine-setup.spec.in M src/bin/Makefile.am 2 files changed, 8 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Alex Lourie: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/16942 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a2347abe5f7deb4e976abbbe48e7fd9eb7c78f7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: restart libvirt earlier
by sbonazzo＠redhat.com 25 Jul '13

25 Jul '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: restart libvirt earlier ...................................................................... packaging: setup: restart libvirt earlier moved libvirt restart to misc stage allowing the daemon to reload the configuration before restarting vdsmd. Change-Id: I75065419dac10f8992039a5b2e49c9fe783b839b Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/libvirt/configureqemu.py 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Alex Lourie: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/16912 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75065419dac10f8992039a5b2e49c9fe783b839b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: moved vm run at closeup
by sbonazzo＠redhat.com 25 Jul '13

25 Jul '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: moved vm run at closeup ...................................................................... packaging: setup: moved vm run at closeup Moved VM execution at closeup stage with low priority for having the firewall configured and ports opened. Change-Id: I079ab041acfe28f9376bfbb052be9307842c2a36 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py M src/plugins/ovirt-hosted-engine-setup/engine/health.py M src/plugins/ovirt-hosted-engine-setup/engine/os_install.py M src/plugins/ovirt-hosted-engine-setup/vm/runvm.py 4 files changed, 10 insertions(+), 13 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Alex Lourie: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/16878 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I079ab041acfe28f9376bfbb052be9307842c2a36 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: vdsm: packages: disable NetworkManager service by default
by Alon Bar-Lev 25 Jul '13

25 Jul '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: packages: disable NetworkManager service by default ...................................................................... vdsm: packages: disable NetworkManager service by default NetworkManager causes timing issues with network service and vdsm. See rhbz#879180. Antoni Segura Puimedon: > I was confirming the state of affairs with NM guys. > They said that: > "no, it [the fix in https://bugzilla.redhat.com/show_bug.cgi?id=879180 ] > is not in F19. But there are changes in master (will go to F20, RHEL7), > one of them being the thing that NM won't monitor ifcfg file changes > (but will read the changed files only on explicit request)" > > So this change is necessary until then. Change-Id: Ie309c2939f44b3bc2f44eb9e892cbd118651a41a Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/ovirt_host_deploy/constants.py M src/plugins/ovirt-host-deploy/vdsm/packages.py 2 files changed, 17 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17306 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie309c2939f44b3bc2f44eb9e892cbd118651a41a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>

1 0