Change in ovirt-guest-agent[master]: agent: Reworking the data filtering for the guest agent
by bazulay@redhat.com
Barak Azulay has submitted this change and it was merged.
Change subject: agent: Reworking the data filtering for the guest agent
......................................................................
agent: Reworking the data filtering for the guest agent
This patchset is oriented on http://gerrit.ovirt.org/#/c/16652
We're now filtering properly invalid unicode characters and invalid
characters. Which would cause VDSM to build invalid XML data.
Change-Id: I3a4347350d791f4df0b26b1cf81d0ca4f9656981
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M ovirt-guest-agent/VirtIoChannel.py
1 file changed, 33 insertions(+), 18 deletions(-)
Approvals:
Vinzenz Feenstra: Verified; Looks good to me, but someone else must approve
Barak Azulay: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16880
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3a4347350d791f4df0b26b1cf81d0ca4f9656981
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
11 years, 5 months
Change in ovirt-guest-agent[master]: agent: Support reboot as optional shutdown parameter
by bazulay@redhat.com
Barak Azulay has submitted this change and it was merged.
Change subject: agent: Support reboot as optional shutdown parameter
......................................................................
agent: Support reboot as optional shutdown parameter
Added optional boolean parameter determining whether to pass the '-r'
parameter to the appropriate shutdown script.
Change-Id: I94929ff49677ee79569117158c53bdaf086b3ae8
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M ovirt-guest-agent/GuestAgentLinux2.py
M ovirt-guest-agent/GuestAgentWin32.py
M ovirt-guest-agent/OVirtAgentLogic.py
3 files changed, 22 insertions(+), 10 deletions(-)
Approvals:
Vinzenz Feenstra: Verified; Looks good to me, but someone else must approve
Barak Azulay: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15855
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I94929ff49677ee79569117158c53bdaf086b3ae8
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
11 years, 5 months
Change in ovirt-guest-agent[master]: agent: condrestart should check also for pidfile size
by bazulay@redhat.com
Barak Azulay has submitted this change and it was merged.
Change subject: agent: condrestart should check also for pidfile size
......................................................................
agent: condrestart should check also for pidfile size
Change-Id: Ia2dff34095430147116491337ea528594cb6ab04
Bug-Url: https://bugzilla.redhat.com/977943
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M ovirt-guest-agent/ovirt-guest-agent.in
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Vinzenz Feenstra: Verified; Looks good to me, but someone else must approve
Barak Azulay: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16565
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia2dff34095430147116491337ea528594cb6ab04
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
11 years, 5 months
Change in ovirt-guest-agent[master]: agent: Use python 2.4 syntax in GuestAgentLinux2
by bazulay@redhat.com
Barak Azulay has submitted this change and it was merged.
Change subject: agent: Use python 2.4 syntax in GuestAgentLinux2
......................................................................
agent: Use python 2.4 syntax in GuestAgentLinux2
Change-Id: I37c570c2cca4a71f15173601aaed27522e01e895
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M ovirt-guest-agent/GuestAgentLinux2.py
1 file changed, 15 insertions(+), 5 deletions(-)
Approvals:
Vinzenz Feenstra: Verified; Looks good to me, but someone else must approve
Barak Azulay: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14545
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I37c570c2cca4a71f15173601aaed27522e01e895
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
11 years, 5 months
Change in ovirt-engine[master]: engine: fix null pointer in VdsUpdateRunTimeInfo
by gchaplik@redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: engine: fix null pointer in VdsUpdateRunTimeInfo
......................................................................
engine: fix null pointer in VdsUpdateRunTimeInfo
In case a VM was in the host but not in the DB a null pointer exception
would occur, added a fix.
Change-Id: I07ba7082196441ad6bd5b66436e3c944c4abec21
Signed-off-by: Noam Slomianko <nslomian(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17297
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I07ba7082196441ad6bd5b66436e3c944c4abec21
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
Change in ovirt-engine[master]: webadmin: disks - update ScanAlignment availability
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: disks - update ScanAlignment availability
......................................................................
webadmin: disks - update ScanAlignment availability
Update ScanAlignment command availability on EntityChanged
(i.e. only when selecting a VM).
Change-Id: I2eb0a8c94b77eee0f8299384bed5a569d1ea6fb7
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java
1 file changed, 45 insertions(+), 18 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17235
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2eb0a8c94b77eee0f8299384bed5a569d1ea6fb7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
Change in ovirt-engine[master]: webadmin: storage-general sub-tab use StorageSizeLabel
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: storage-general sub-tab use StorageSizeLabel
......................................................................
webadmin: storage-general sub-tab use StorageSizeLabel
Storage main-tab -> General sub-tab:
Use StorageSizeLabel instead of DiskSizeLabel since 'N/A' should be
displayed when size is '0' (only in general sub-tab).
Change-Id: I1c1722a1a745d3a91bb87fc5c28dd8a6fb1106ab
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/StorageSizeLabel.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/DiskSizeRenderer.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageGeneralView.java
3 files changed, 28 insertions(+), 6 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17234
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1c1722a1a745d3a91bb87fc5c28dd8a6fb1106ab
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
Change in ovirt-engine[master]: core: Fix legacy log at CommandAsyncTask
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Fix legacy log at CommandAsyncTask
......................................................................
core: Fix legacy log at CommandAsyncTask
Change-Id: Icde10cc9ea1c147a41d23c947ee57b9ac71790e6
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandAsyncTask.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17062
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icde10cc9ea1c147a41d23c947ee57b9ac71790e6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
Change in ovirt-engine[master]: core: Fix typo at SPMAsyncTask
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Fix typo at SPMAsyncTask
......................................................................
core: Fix typo at SPMAsyncTask
Change-Id: Id1142747ef30aa8db5c636e19440e0c3a8bd8e2a
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SPMAsyncTask.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17061
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id1142747ef30aa8db5c636e19440e0c3a8bd8e2a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
Change in ovirt-engine[master]: webadmin: refresh data on templates-disks sub-tab
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: refresh data on templates-disks sub-tab
......................................................................
webadmin: refresh data on templates-disks sub-tab
Templates main-tab -> Disks sub-tab:
ensure storage domains data refresh.
Change-Id: Iea5004501dbdb1a3818e479633db5d6ba0249086
Bug-Url: https://bugzilla.redhat.com/972669
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateDiskListModel.java
1 file changed, 13 insertions(+), 12 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17200
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iea5004501dbdb1a3818e479633db5d6ba0249086
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months