Change in ovirt-engine[master]: history: fixed vm configuration dwh view
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: history: fixed vm configuration dwh view
......................................................................
history: fixed vm configuration dwh view
Change-Id: Ia55a029aa776639b69a911a4ee826be77c8f0e89
Bug-Url: https://bugzilla.redhat.com/987517
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
---
M packaging/dbscripts/create_dwh_views.sql
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
Yaniv Dary: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/17277
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia55a029aa776639b69a911a4ee826be77c8f0e89
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
11 years, 5 months
Change in ovirt-engine[master]: webadmin: QoS - check Peak not under Average
by gchaplik@redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: QoS - check Peak not under Average
......................................................................
webadmin: QoS - check Peak not under Average
Add check to canDoAction of QoS commands to make sure that Peak value is
not lower then Average value.
Change-Id: I3e0c184cfb3e2deb0f39615800a2958b340ad724
Signed-off-by: Ofri Masad <omasad(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/NetworkQoSCommandBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
5 files changed, 17 insertions(+), 0 deletions(-)
Approvals:
ofri masad: Verified
Gilad Chaplik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17202
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3e0c184cfb3e2deb0f39615800a2958b340ad724
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
11 years, 5 months
Change in ovirt-engine[master]: core: create_schema.sh do not support space in path
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: create_schema.sh do not support space in path
......................................................................
core: create_schema.sh do not support space in path
Wrapping MD5DIR value with "" to enable directory name that contains
spaces.
Change-Id: Iad69e7a596aee50682ee0669cc8a5ffff7462e0a
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M packaging/dbscripts/dbfunctions.sh
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16608
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iad69e7a596aee50682ee0669cc8a5ffff7462e0a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 5 months
Change in ovirt-engine[master]: core: After enable concurrent option under host...
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: After enable concurrent option under host...
......................................................................
core: After enable concurrent option under host...
After enable concurrent option under host power management fencing begin failed
This bug was probably caused by a race:
>From the logs its seems that a NULL proxy host is attempt to be used.
There is a check for a valid proxy in canDoAction but not all the
execution paths checks for proxy
Checking for proxy should be also in execute for
single/dual[sequential,concurrent] and the flag that indicates if the
operation succeeded should be set accordingly
Change-Id: I139a7de9a4bb24a56523073b800b929a31fcdc6a
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=977689
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
1 file changed, 72 insertions(+), 58 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17206
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I139a7de9a4bb24a56523073b800b929a31fcdc6a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
Change in ovirt-engine[master]: core: Unable to restore from 3.1 LogCollector...
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Unable to restore from 3.1 LogCollector...
......................................................................
core: Unable to restore from 3.1 LogCollector...
Unable to restore from 3.1 LogCollector DB backup file
In the case that restore is done from a TAR file we should try to
install the plpgsql language as well.
Change-Id: I543679f87bc9fd0f26909db3889dee482dfada77
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=960760
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M packaging/dbscripts/restore.sh
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16904
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I543679f87bc9fd0f26909db3889dee482dfada77
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 5 months
Change in ovirt-engine[master]: core:Unable to restore DB when selinux is disabled.
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core:Unable to restore DB when selinux is disabled.
......................................................................
core:Unable to restore DB when selinux is disabled.
Change script to manipulate files by chcon only when SELinux is not in
the Disabled mode.
Change-Id: I76ca818acf53759eae2576302e4ca19ab3988103
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=980042
---
M packaging/dbscripts/restore.sh
1 file changed, 9 insertions(+), 5 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16322
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I76ca818acf53759eae2576302e4ca19ab3988103
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 5 months
Change in ovirt-engine[master]: core:[upgrade] Upgrade 3.2 => 3.3 failed...
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core:[upgrade] Upgrade 3.2 => 3.3 failed...
......................................................................
core:[upgrade] Upgrade 3.2 => 3.3 failed...
[upgrade] Upgrade 3.2 => 3.3 failed - column
vm_templates.vnc_keyboard_layout does not exist
After moving 3.3 upgrade scripts that were pushed as 3.2
(http://gerrit.ovirt.org/#/c/16639/) , I had to rearrange the 03_02
patches to fit the max 10 gap allowed between scripts.
The right way to do that is to insert dummy scripts with the numbers of
those that were moved from 3.2 to 3.3 and not changing the original
numbering
Change-Id: I9383340cd00ec9126536c88eb3a630f55f678f04
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=986230
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
A packaging/dbscripts/upgrade/03_02_0430_dummy.sql
A packaging/dbscripts/upgrade/03_02_0440_dummy.sql
R packaging/dbscripts/upgrade/03_02_0450_add_vm_vnc_keyboard_layout.sql
R packaging/dbscripts/upgrade/03_02_0460_add_async_task_task_parameters.sql
R packaging/dbscripts/upgrade/03_02_0470_lsm_version_support.sql
R packaging/dbscripts/upgrade/03_02_0480_fix_stateless_snapshot.sql
R packaging/dbscripts/upgrade/03_02_0490_add_update_column_to_statistics_tables.sql
R packaging/dbscripts/upgrade/03_02_0500_add_gluster_hooks_table.sql
8 files changed, 2 insertions(+), 0 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17137
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9383340cd00ec9126536c88eb3a630f55f678f04
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 5 months
Change in ovirt-engine[master]: userportal, webadmin: Don't bundle gwt-dev.jar
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: userportal, webadmin: Don't bundle gwt-dev.jar
......................................................................
userportal, webadmin: Don't bundle gwt-dev.jar
The GWT RPC mechanism that we currently use needs some classes that are
part of the gwt-dev.jar file since version 2.5.1. This means that we
need to add that gwt-dev.jar file to the WEB-INF/lib directories of the
applications, and that causes class loading problems because gwt-dev.jar
bundles many third party libraries, including its own copy of the Xerces
XML parser. To avoid this issue we are copying into the frontend project
the sources of the classes needed by the GWT RPC mechanism and not
included in gwt-servlet.jar, currently only
com.google.gwt.core.client.GWTBridge. This way we can set the scope of
the gwt-dev dependency to provided so that it won't be included in the
WEB-INF/lib directories.
Change-Id: I0555b185ea8c52469ebe0779f5287b5bd824a569
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M frontend/webadmin/modules/frontend/pom.xml
A frontend/webadmin/modules/frontend/src/main/java/com/google/gwt/core/client/GWTBridge.java
M pom.xml
3 files changed, 38 insertions(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17264
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0555b185ea8c52469ebe0779f5287b5bd824a569
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
Change in ovirt-engine[master]: packaging: Set otopi based setup utilities as defult
by oschreib@redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: Set otopi based setup utilities as defult
......................................................................
packaging: Set otopi based setup utilities as defult
Set the defult engine-setup/cleanup/upgrade to be the otopi based
scripts, instead of legacy
Change-Id: I3e6f3c0ad938ece35ae2144e21fbd60775a1e910
Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com>
---
M Makefile
M ovirt-engine.spec.in
2 files changed, 3 insertions(+), 9 deletions(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17260
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3e6f3c0ad938ece35ae2144e21fbd60775a1e910
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years, 5 months
Change in ovirt-engine[master]: packaging: setup: remove release preview warning
by oschreib@redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: setup: remove release preview warning
......................................................................
packaging: setup: remove release preview warning
Change-Id: I15a161f148613d754df2760b13c0ba8bc488db2e
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
D packaging/setup/plugins/ovirt-engine-setup/releasepreview/__init__.py
D packaging/setup/plugins/ovirt-engine-setup/releasepreview/misc.py
2 files changed, 0 insertions(+), 85 deletions(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17059
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I15a161f148613d754df2760b13c0ba8bc488db2e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years, 5 months