Change in ovirt-engine[master]: webadmin: LocalStorageModel - remove commented out code
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: LocalStorageModel - remove commented out code
......................................................................
webadmin: LocalStorageModel - remove commented out code
Removed commented out code in ConfigureLocalStorageModel
Change-Id: I63c6b565b56c9cafcf6c50a1066e031825b24fee
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ConfigureLocalStorageModel.java
1 file changed, 0 insertions(+), 182 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17134
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I63c6b565b56c9cafcf6c50a1066e031825b24fee
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
Change in ovirt-engine[master]: webadmin: AddDataCenter - remove commented out code
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: AddDataCenter - remove commented out code
......................................................................
webadmin: AddDataCenter - remove commented out code
Removed commented out code in AddDataCenterRM
Change-Id: I328e46ead1b72a5f5475278a560d1e95b6c163e4
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddDataCenterRM.java
1 file changed, 0 insertions(+), 95 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17133
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I328e46ead1b72a5f5475278a560d1e95b6c163e4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
Change in ovirt-engine[master]: webadmin: prevent NPE in ClusterModel
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: prevent NPE in ClusterModel
......................................................................
webadmin: prevent NPE in ClusterModel
CustomPropertySheet should be validated only when it's available.
Hence, disable validation on ConfigureLocalStorage.
Change-Id: I1267a43408e2580e7f301ae6bed5dfe8735aed14
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ConfigureLocalStorageModel.java
2 files changed, 8 insertions(+), 4 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17132
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1267a43408e2580e7f301ae6bed5dfe8735aed14
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
Change in ovirt-engine[master]: engine: add role and action to AttachUserToVmFromPoolAndRunC...
by dfediuck@redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: engine: add role and action to AttachUserToVmFromPoolAndRunCommand
......................................................................
engine: add role and action to AttachUserToVmFromPoolAndRunCommand
setActionMessageParameters wasn't called from AttachUserToVmFromPoolAndRunCommand
Change-Id: I840a6546b52bd26a6dd1b5c51470db9d48abb968
Bug-Url: https://bugzilla.redhat.com/966059
Signed-off-by: Noam Slomianko <nslomian(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java
1 file changed, 7 insertions(+), 2 deletions(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16335
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I840a6546b52bd26a6dd1b5c51470db9d48abb968
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
11 years, 5 months
Change in ovirt-engine[master]: restapi: fix lack of errorTranslator mock
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: fix lack of errorTranslator mock
......................................................................
restapi: fix lack of errorTranslator mock
Fix in REST test infrastucture the lack of mocking for
error translator in setupCreationExpectations method.
Before the fix, passing to this method cando=false
or execute=false caused NullPointerException during
the test execution because the error translator was not mocked.
Change-Id: Ibc315c1baf2e85005bde7b637e9fff870ef66aa4
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResourceTest.java
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17003
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc315c1baf2e85005bde7b637e9fff870ef66aa4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
Change in ovirt-host-deploy[master]: vdsm: packages: relax log level of vdsm-tool error
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: vdsm: packages: relax log level of vdsm-tool error
......................................................................
vdsm: packages: relax log level of vdsm-tool error
Change-Id: I97e8dc6670c1e8ad8b050875dd5ada15981807e6
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/plugins/ovirt-host-deploy/vdsm/packages.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17149
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I97e8dc6670c1e8ad8b050875dd5ada15981807e6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
11 years, 5 months
Change in ovirt-engine[master]: packaging: build: add missing DESTDIR in artifacts target
by oschreib@redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: build: add missing DESTDIR in artifacts target
......................................................................
packaging: build: add missing DESTDIR in artifacts target
Change-Id: I4ae987362f9930a9fab89519f86e6081379ccf39
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M Makefile
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17139
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4ae987362f9930a9fab89519f86e6081379ccf39
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
11 years, 5 months
Change in ovirt-engine[master]: packaging: services: do not require syslog available
by oschreib@redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: services: do not require syslog available
......................................................................
packaging: services: do not require syslog available
in case that syslog or replacement does not listen to /dev/log service
should not fail.
Change-Id: Id7bb66835211ff91530834891cb97d91d37f4592
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/services/service.py
1 file changed, 20 insertions(+), 16 deletions(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17094
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id7bb66835211ff91530834891cb97d91d37f4592
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years, 5 months
Change in ovirt-engine[master]: package: fix call to Insertstorage_domain_static
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: package: fix call to Insertstorage_domain_static
......................................................................
package: fix call to Insertstorage_domain_static
This patch updates inst_add_iso_storage_domain to call
Insertstorage_domain_static with a free text argument which was
introduced in 5367a779fa78c811637350aaba895f54b425d85d
Change-Id: I2bc8ca849ef1e65285993b9c5f4cee3de0deea74
Signed-off-by: Doron Fediuck <dfediuck(a)redhat.com>
---
M packaging/dbscripts/inst_sp.sql
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17087
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2bc8ca849ef1e65285993b9c5f4cee3de0deea74
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years, 5 months
Change in ovirt-engine[master]: packaging: spec: move ovirt-host-deploy dependency to backen...
by oschreib@redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: spec: move ovirt-host-deploy dependency to backend
......................................................................
packaging: spec: move ovirt-host-deploy dependency to backend
and update minimum version.
Change-Id: Ica0c98a26d6fc8d2235b91e8e936fefcb888216e
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M ovirt-engine.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17126
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ica0c98a26d6fc8d2235b91e8e936fefcb888216e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years, 5 months