July 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: rv GetEntityPermissionsi[ForUserAndGroups]
by amureini＠redhat.com 04 Jul '13

04 Jul '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: rv GetEntityPermissionsi[ForUserAndGroups] ...................................................................... core: rv GetEntityPermissionsi[ForUserAndGroups] Change get_entity_permissions and get_entity_permissions_for_user_and_groups to use a return value instead of an output parameter. Although the main reasoning behind this is standardisation and code cleanliness, there is an added performance bonus as this change removes an explicit conversion of the returned uuid to a varchar. Change-Id: I26d94fc765c927763af6bb0fa6775b4aaced6a28 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/PermissionDAODbFacadeImpl.java M packaging/dbscripts/multi_level_administration_sp.sql 2 files changed, 15 insertions(+), 25 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26d94fc765c927763af6bb0fa6775b4aaced6a28 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: OpenstackNetworkProviderProperties#equals
by yzaslavs＠redhat.com 04 Jul '13

04 Jul '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: OpenstackNetworkProviderProperties#equals ...................................................................... core: OpenstackNetworkProviderProperties#equals OpenstackNetworkProviderProperties.equals(Object) was broken in patch Ib12a76a069d1d4b5c6cac642bfe6a3da1338a4c5 when pluginType was changed from OpenstackNetworkPluginType which can use "!=" since it's an enum to a String. This patch fixes the equals(Object) method by using !equals instead of !=. Change-Id: Idac272b69c9460a9d56192fc9ddc1ae81de3a331 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/OpenstackNetworkProviderProperties.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16428 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idac272b69c9460a9d56192fc9ddc1ae81de3a331 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: change how async tasks are persisted using TaskHandler...
by ofrenkel＠redhat.com 04 Jul '13

04 Jul '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: change how async tasks are persisted using TaskHandlerCommand ...................................................................... core: change how async tasks are persisted using TaskHandlerCommand Add a way to specify the taskKey of the to-be-persisted task, by introducing new method that gets the key as a String. The previous way that was exist for adding async tasks by the TaskHandlerCommand send the action-type of the enclosing command as the parent command. this behaviour is now being generalized - the enclosing command itself will determine whether it should be the parent or other by override the persist* methods in TaskHandlerCommand interface. Change-Id: Iee869f68724e67e256e7342f3a5201b7e6d3a30c Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractSPMAsyncTaskHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/LiveSnapshotMemoryImageBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/TaskHandlerCommand.java 7 files changed, 29 insertions(+), 15 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16398 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee869f68724e67e256e7342f3a5201b7e6d3a30c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fixing JSON derialization of VM
by yzaslavs＠redhat.com 04 Jul '13

04 Jul '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fixing JSON derialization of VM ...................................................................... core: Fixing JSON derialization of VM Adding another JsonIgnore to JsonVmMixIn. Apararently @JsonIgnore annotation directly on the getter at Vm class does not work. This still needs to be investigated, but for now we should not block this fix, as the exception causes tasks to remain in DB after creating a snapshot. Change-Id: I1cb86a047d8516fba7c45177bebb83490389e9da Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonVmMixIn.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16405 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1cb86a047d8516fba7c45177bebb83490389e9da Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Allow custom OpenStack Network plugin type
by mkolesni＠redhat.com 04 Jul '13

04 Jul '13

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Allow custom OpenStack Network plugin type ...................................................................... core: Allow custom OpenStack Network plugin type The plugin type should be specifiable by the user, as it will allow installation of custom hooks that will support this specific plugin type (it's up to the admin to make sure he puts in the correct value). The old plugin types can still be sent from the UI, which would cause the corresponding hook to be triggered. Change-Id: Ib12a76a069d1d4b5c6cac642bfe6a3da1338a4c5 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/OpenstackNetworkProviderProxy.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/OpenstackNetworkProviderProperties.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/provider/ProviderDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/provider/ProviderDaoTest.java 4 files changed, 7 insertions(+), 8 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16407 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib12a76a069d1d4b5c6cac642bfe6a3da1338a4c5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix async tasks insertion to include time zone info
by emesika＠redhat.com 03 Jul '13

03 Jul '13

Eli Mesika has submitted this change and it was merged. Change subject: core: Fix async tasks insertion to include time zone info ...................................................................... core: Fix async tasks insertion to include time zone info Similar to other places (i.e - audit log insertion - log_time field) We should insert the "started_at" time with time zone information Change-Id: I06d2daaf5647d850c1c3a86f0610bf12a60c4ffd Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M packaging/dbscripts/async_tasks_sp.sql 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16365 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06d2daaf5647d850c1c3a86f0610bf12a60c4ffd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: Make adding (virtio-)console to virtual machines o...
by tjelinek＠redhat.com 03 Jul '13

03 Jul '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Make adding (virtio-)console to virtual machines optional ...................................................................... frontend: Make adding (virtio-)console to virtual machines optional This patch makes it possible to control attaching virtio-console for VMs/templates/VMs in pool. The console is a managed device, therefore corresponding device type was added. Also a command for querying DB for console devices was added. Affected frontend behavior: - New checkbox in new/edit vm/template/pool dialog for controlling attaching of the console device. - For new vm/tepmlates entities if the operating system listbox changes, the console device checkbox is changed accordingly (if the selected OS is linux type, it is checked, otherwise it is unchecked). Change-Id: Idf5f82b56940dbb43fe40f45a2a90eb004f29f4d Bug-Url: https://bugzilla.redhat.com/878459 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 15 files changed, 68 insertions(+), 9 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/15613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf5f82b56940dbb43fe40f45a2a90eb004f29f4d Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Backend.java: Adding RPM version on initialization
by yzaslavs＠redhat.com 03 Jul '13

03 Jul '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: Backend.java: Adding RPM version on initialization ...................................................................... Backend.java: Adding RPM version on initialization This patch will print the oVirt Engine version on initialization. Change-Id: I517ffcc548f84e3ca55614266f944bf87ecd5fb0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=969819 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16363 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I517ffcc548f84e3ca55614266f944bf87ecd5fb0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Dafna Ron <dron(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix log event of proxy host
by yzaslavs＠redhat.com 03 Jul '13

03 Jul '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fix log event of proxy host ...................................................................... core: Fix log event of proxy host Adds logging of datacenter or cluster name when one host acts as a proxy for another one. Change-Id: Ieb071150cd9da75a8e5025862b650f3eddfaf10a Bug-Url: https://bugzilla.redhat.com/949469 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java 1 file changed, 32 insertions(+), 3 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15318 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb071150cd9da75a8e5025862b650f3eddfaf10a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove auto suspend audit log.
by mlipchuk＠redhat.com 03 Jul '13

03 Jul '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove auto suspend audit log. ...................................................................... core: Remove auto suspend audit log. 1. Remove audit log of auto suspend 2. Removing hibernateVM parameter class after auto suspend has been removed. Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: I7d9eb34264ab64c54bc12225cc0820b30c40667a --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HibernateVmParameters.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/VmItemBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 11 files changed, 15 insertions(+), 65 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16275 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d9eb34264ab64c54bc12225cc0820b30c40667a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0