July 2013 - Engine-commits - Ovirt List Archives

Change in ovirt-engine-sdk-java[master]: sdk: the last character of an error message is truncated #98...

by mpastern＠redhat.com

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: the last character of an error message is truncated #988058 ...................................................................... sdk: the last character of an error message is truncated #988058 Change-Id: I206ac300243d9514bad34dbcbb5a931397056e06 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=988058 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/utils/StringUtils.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Moti Asayag: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/17464 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I206ac300243d9514bad34dbcbb5a931397056e06 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

10 years, 9 months

1
0
0 / 0

Change in ovirt-scheduler-proxy[master]: Implement seperate process logic

by lhornyak＠redhat.com

Laszlo Hornyak has submitted this change and it was merged. Change subject: Implement seperate process logic ...................................................................... Implement seperate process logic Created PythonMethodRunner to run python methods in diffrent process Created loader.py to safely check what user modules contain Used loader.py for safe discovery of user modules at executor init Implamented function logic Change-Id: I0fd8a1b83ed330c945025f13abf565fd999563e7 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- A plugins/dummy.py D plugins/filters/dummy.py A src/API.py R src/__init__.py A src/loader.py A src/oschedproxyd.py D src/ovirtsched/executor.py D src/ovirtsched/main.py D src/ovirtsched/runner.py A src/request_handler.py R src/request_handler_test.py A src/runner.py R src/runner_test.py A src/utils.py 14 files changed, 585 insertions(+), 213 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0fd8a1b83ed330c945025f13abf565fd999563e7 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-scheduler-proxy Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com>

10 years, 9 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Changed QPID port type from int to Integer

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: core: Changed QPID port type from int to Integer ...................................................................... core: Changed QPID port type from int to Integer Previous implementation was NPE-prone due to the getter/setter relating to the field as Integer, while it was actually defined as int. Change-Id: Iaadefc98dcd34a7158f1d93fa3ca5f60a26728f3 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/OpenstackNetworkProviderProperties.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17397 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaadefc98dcd34a7158f1d93fa3ca5f60a26728f3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 9 months

1
0
0 / 0

Change in ovirt-engine[master]: userportal, webadmin: WelcomeServletTest improvement

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: userportal,webadmin: WelcomeServletTest improvement ...................................................................... userportal,webadmin: WelcomeServletTest improvement This patch applies common pattern for testing servlet classes: public class MyServlet extends HttpServlet { ... private ServletDependency dep; @Override // Called by servlet container at runtime public void init() { init(new ServletDependencyImpl()); } // Package-private visibility, method used by MyServletTest void init(ServletDependency dep) { this.dep = dep; } ... } In this patch, WelcomeServletTest uses BrandingManager mock instead of real BrandingManager implementation to ensure WelcomeServlet is tested properly in isolation, i.e. using mocked dependencies. Change-Id: I2d654ce7ca57f8bd8962ab668a0c13e1e09d80f3 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M backend/manager/modules/root/src/main/java/org/ovirt/engine/core/WelcomeServlet.java M backend/manager/modules/root/src/test/java/org/ovirt/engine/core/WelcomeServletTest.java 2 files changed, 21 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17433 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d654ce7ca57f8bd8962ab668a0c13e1e09d80f3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 9 months

1
0
0 / 0

Change in ovirt-engine[master]: frontend: Add paging in SubTabPoolVmView

by tjelinek＠redhat.com

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Add paging in SubTabPoolVmView ...................................................................... frontend: Add paging in SubTabPoolVmView This patch adds support for paging in SubTabPoolVmView. For this a separate attribute, which holds the state of paging, was introduced in SearchableListModel. Change-Id: I358183c42e15a97bec65dbbe1823b611f1c49692 Bug-Url: https://bugzilla.redhat.com/989041 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/pool/SubTabPoolVmView.java 2 files changed, 7 insertions(+), 13 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/17450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I358183c42e15a97bec65dbbe1823b611f1c49692 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 9 months

1
0
0 / 0

Change in ovirt-node-plugin-vdsm[master]: engine_page: fix pep8 for effective_model

by mburns＠redhat.com

Michael Burns has submitted this change and it was merged. Change subject: engine_page: fix pep8 for effective_model ...................................................................... engine_page: fix pep8 for effective_model Make pep8 happy for effective_model["vdsm_cfg.address"] Change-Id: I8d95cd1a228793270a580c8b093dcec66398264d Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/engine_page.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified Michael Burns: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17446 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d95cd1a228793270a580c8b093dcec66398264d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 9 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: use internal query for watchdog

by lhornyak＠redhat.com

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: use internal query for watchdog ...................................................................... engine: use internal query for watchdog Uses internal query to avoid permission problems Change-Id: Id1c26dda8843cad3882e1ca8a2ce81eaff576e12 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17089 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1c26dda8843cad3882e1ca8a2ce81eaff576e12 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

10 years, 9 months

1
0
0 / 0

Change in ovirt-host-deploy[master]: packaging: Fixed building RPMs on non-x86_64 architectures

by Alon Bar-Lev

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: Fixed building RPMs on non-x86_64 architectures ...................................................................... packaging: Fixed building RPMs on non-x86_64 architectures The DMI decode is available only on the x86_64 architecture, the spec file was changed to reflect this. Change-Id: I691544be6630ed2e88acbf8f1828b7995f582ffa Signed-off-by: Vitor de Lima <vitor.lima(a)eldorado.org.br> --- M ovirt-host-deploy.spec.in 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Vitor de Lima: Verified; Looks good to me, but someone else must approve Alon Bar-Lev: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17280 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I691544be6630ed2e88acbf8f1828b7995f582ffa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br>

10 years, 9 months

1
0
0 / 0

Change in ovirt-host-deploy[master]: vdsm: hardware: Remove null character from the id on IBM POW...

by Alon Bar-Lev

Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: hardware: Remove null character from the id on IBM POWER ...................................................................... vdsm: hardware: Remove null character from the id on IBM POWER The hardware id for IBM POWER machines had a trailing null character that caused errors in the oVirt engine. Change-Id: Ia74ac58d334c944c6042f033d622a09b86c8325d Signed-off-by: Vitor de Lima <vitor.lima(a)eldorado.org.br> --- M src/plugins/ovirt-host-deploy/vdsm/vdsmid.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Vitor de Lima: Verified; Looks good to me, but someone else must approve Alon Bar-Lev: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia74ac58d334c944c6042f033d622a09b86c8325d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br>

10 years, 9 months

1
0
0 / 0

Change in ovirt-engine[master]: Revert "frontend: Add custom field serializer for RepoImage"

by vszocs＠redhat.com

Vojtech Szocs has submitted this change and it was merged. Change subject: Revert "frontend: Add custom field serializer for RepoImage" ...................................................................... Revert "frontend: Add custom field serializer for RepoImage" This reverts commit 30a941a4b3ed8e46053880a5fd6de325907a9b52, as it was a temporary solution for GWT RPC serialization issues that have been now solved in other patches. Change-Id: I1619f4b1d3b651cdb1a6173d536e5b8ab01e66ca Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- D frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/common/businessentities/RepoImage_CustomFieldSerializer.java 1 file changed, 0 insertions(+), 51 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17349 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1619f4b1d3b651cdb1a6173d536e5b8ab01e66ca Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 9 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits July 2013