August 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Consider case-sensitivity for mac-address uniqueness
by mkolesni＠redhat.com 28 Aug '13

28 Aug '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Consider case-sensitivity for mac-address uniqueness ...................................................................... engine: Consider case-sensitivity for mac-address uniqueness The patch modifies the type of the map which holds the MAC Address to be case-insensitive to prevent adding the same MAC address with a different capitalization. Change-Id: I57516cc710648b37a9cebcdfce592c2418a7e192 Bug-Url: https://bugzilla.redhat.com/973911 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/18490 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57516cc710648b37a9cebcdfce592c2418a7e192 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: packaging: setup: configure pghba for use as postgres
by ydary＠redhat.com 27 Aug '13

27 Aug '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: configure pghba for use as postgres ...................................................................... packaging: setup: configure pghba for use as postgres The new implementaion brings setting postgres server to temporarily accept local socket connections from postgres user. It is required so that all the work with local postgres server is done with 'su'-ing to postgres in all flows. Change-Id: I7244d9ec7a6b2dc4dbc2c3965b1f26e4b51b66ca Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M data-warehouse/historydbscripts_postgres/create_db.sh M packaging/common_utils.py M packaging/ovirt-engine-dwh-setup.py 3 files changed, 80 insertions(+), 25 deletions(-) Approvals: Alex Lourie: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18036 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7244d9ec7a6b2dc4dbc2c3965b1f26e4b51b66ca Gerrit-PatchSet: 5 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: node upgrade detection improvement
by yzaslavs＠redhat.com 27 Aug '13

27 Aug '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: frontend: node upgrade detection improvement ...................................................................... frontend: node upgrade detection improvement In commit 5233548 the comparison failed because revision strings from the node's OS might contain extra digits in the date like 20130212.0. This patch parses the string from vds.getHostOs() as shown below and splits it into major, minor, build and revision. However, in the revision field it compares each segment delimited by dots and makes a comparison between the node's OS and the ISO until it reaches a letter, like "fc18" or "el6", which is derived from the rpm. oVirt Node - 2.6.0 - 20130212.0.fc18 oVirt Node - 2.6.0 - 20130212.fc18 oVirt Node - 3.0.0 - 5.0.5.vdsm.fc19 RHEV Hypervisor - 6.4 - 20130709.0.el6_4 RHEV Hypervisor - 6.4 - 20130709.0.el6_4 Change-Id: I76bd2948524110ec80923e855bd1f49e09e17046 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java 1 file changed, 40 insertions(+), 14 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17987 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76bd2948524110ec80923e855bd1f49e09e17046 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)gmail.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: backend: GetoVirtISOsQuery use RpmVersionUtils
by yzaslavs＠redhat.com 27 Aug '13

27 Aug '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: backend: GetoVirtISOsQuery use RpmVersionUtils ...................................................................... backend: GetoVirtISOsQuery use RpmVersionUtils - Replace parseIsoFileVersion() by direct RpmVersion call - Use RpmVersionUtils for isIsoVersionSupported() Change-Id: I17cae0eed9e6109fa0c7efb460e02ab7073fe21d Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetoVirtISOsQuery.java 1 file changed, 7 insertions(+), 20 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18435 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17cae0eed9e6109fa0c7efb460e02ab7073fe21d Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Adding RpmVersion utils
by yzaslavs＠redhat.com 27 Aug '13

27 Aug '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Adding RpmVersion utils ...................................................................... core: Adding RpmVersion utils Adding a utility class to serve RpmVersion issues to be used both by backend and frontend Change-Id: Ia82d09e755b767f254224c84abd16516592715ac Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/RpmVersionUtils.java A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/RpmVersionUtilsTest.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 3 files changed, 234 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18370 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia82d09e755b767f254224c84abd16516592715ac Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Change rpmRevision field to be called rpmRelease
by yzaslavs＠redhat.com 27 Aug '13

27 Aug '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Change rpmRevision field to be called rpmRelease ...................................................................... core: Change rpmRevision field to be called rpmRelease Change-Id: I98153d1770bf4d5b83b4bda12bf80169d65fe7c0 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/RpmVersion.java M backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/RpmVersionTest.java M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/RpmVersion.java 3 files changed, 24 insertions(+), 23 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18369 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98153d1770bf4d5b83b4bda12bf80169d65fe7c0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: NPE fix in CommonModel
by ecohen＠redhat.com 27 Aug '13

27 Aug '13

Einav Cohen has submitted this change and it was merged. Change subject: webadmin: NPE fix in CommonModel ...................................................................... webadmin: NPE fix in CommonModel Fixed an NPE that prevented the VMs from loading when Gluster was configured in engine and the VMs item was selected in the left-pane tree. Change-Id: I7768bf29a3068a05af624dce1e95f9f2f14f792a Bug-Url: https://bugzilla.redhat.com/987907 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Kanagaraj M: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/18615 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7768bf29a3068a05af624dce1e95f9f2f14f792a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: build: Fix gwt-debug target in Makefile
by ecohen＠redhat.com 27 Aug '13

27 Aug '13

Einav Cohen has submitted this change and it was merged. Change subject: build: Fix gwt-debug target in Makefile ...................................................................... build: Fix gwt-debug target in Makefile Currently, gwt-debug target executes following command: mvn $(DEV_BUILD_FLAGS) ... This means DEV_BUILD_FLAGS can apply parameters that aren't relevant and/or shouldn't even be specified when launching GWT Developer Mode, such as: -Pgwtdraft [via DEV_BUILD_GWT_DRAFT] -Dgwt.userAgent [via DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS] Since DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS defaults to using Firefox (-Dgwt.userAgent=gecko1_8), if someone wants to debug GWT application in Chrome (or any other browser), he must override DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS with empty string, for example: make gwt-debug webadmin \ DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS="" In other words, gwt-debug target shouldn't apply GWT-compile time parameters, such as -Dgwt.userAgent=... Change-Id: I333c3552807e76c722056231a9dedb039c81bdbb Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I333c3552807e76c722056231a9dedb039c81bdbb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: Prevent cleanup without setup
by oschreib＠redhat.com 27 Aug '13

27 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: Prevent cleanup without setup ...................................................................... packaging: setup: Prevent cleanup without setup Change-Id: Ib1dc356976ada9029895b237bd6a0b4771dea64b Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-remove/core/misc.py 1 file changed, 24 insertions(+), 0 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1dc356976ada9029895b237bd6a0b4771dea64b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: do not delete iptables on cleanup
by oschreib＠redhat.com 27 Aug '13

27 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: do not delete iptables on cleanup ...................................................................... packaging: setup: do not delete iptables on cleanup Prevent /etc/sysconfig/iptables from being deleted by cleanup after it was updated by setup using otopi. Change-Id: I03f6ea7050aa6dd27809738c588c9778aaa03bce Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager.py 2 files changed, 16 insertions(+), 0 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18594 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03f6ea7050aa6dd27809738c588c9778aaa03bce Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0