August 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Fix CreateAllSnapshotsFromVmCommandTest
by oourfali＠redhat.com 20 Aug '13

20 Aug '13

Oved Ourfali has submitted this change and it was merged. Change subject: core: Fix CreateAllSnapshotsFromVmCommandTest ...................................................................... core: Fix CreateAllSnapshotsFromVmCommandTest Fix test-break caused by commit 665c1c9e243eaa6ff16cbcdc88828b3645009f8a. The aforementioned patch moves the verification if a VM is (not) external from VmHandler to the VM entity itself, and was thus no longer mocked by the test, causing the failure. This patch adds such mocking, to allow the test to pass. Change-Id: I298d3bd0c05f3175371806dec60c7dccb798d165 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommandTest.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Allon Mureinik: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18302 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I298d3bd0c05f3175371806dec60c7dccb798d165 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: scheduler: handle external scheduler parameters
by gchaplik＠redhat.com 20 Aug '13

20 Aug '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: scheduler: handle external scheduler parameters ...................................................................... core: scheduler: handle external scheduler parameters For loaded external scheduling plugin fixing saving description and custom properties. Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> Change-Id: Ibaa3e1396ba0ec61ebce33d08a1174b93b97c56d --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscoveryResult.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscoveryThread.java 2 files changed, 30 insertions(+), 21 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18263 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibaa3e1396ba0ec61ebce33d08a1174b93b97c56d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix for scheduling cluster custom properties
by gchaplik＠redhat.com 20 Aug '13

20 Aug '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: fix for scheduling cluster custom properties ...................................................................... core: fix for scheduling cluster custom properties problem: when adding scheduling custom property to a cluster and the cluster policy doesn't have this custom policy set, it will not be save. fix: should compare the cluster's custom properties with avialable custom properties and not with cluster policy custom properties. Change-Id: I8d1a79b3406b577cd94e9f2e46defe7e3554d5a9 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsGroupOperationCommandBase.java 1 file changed, 9 insertions(+), 6 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18289 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d1a79b3406b577cd94e9f2e46defe7e3554d5a9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: scheduling: remove migration domain filter
by gchaplik＠redhat.com 20 Aug '13

20 Aug '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: scheduling: remove migration domain filter ...................................................................... core: scheduling: remove migration domain filter Currently there is on way to migrate a vm between clusters, therefore migration domain filter is causing a problem when it's not enabled. This patch removes the filter, and added it's logic (up state and same cluster) to the initial host list provided to the filters. This patch also includes that balancing initial hosts list to be hosts without migrating vms to allow backward compatability. Change-Id: I5aea1d3d1e5e63f03ab0d012d4d3fe9356f26e48 Bug-Url: https://bugzilla.redhat.com/988306 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionBalancePolicyUnit.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/MigrationDomainPolicyUnit.java A packaging/dbscripts/upgrade/03_03_0790_remove_migration_domain_filter.sql 5 files changed, 17 insertions(+), 55 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18069 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5aea1d3d1e5e63f03ab0d012d4d3fe9356f26e48 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: moving isManagedVm and related methods to the VM entity
by oourfali＠redhat.com 20 Aug '13

20 Aug '13

Oved Ourfali has submitted this change and it was merged. Change subject: core: moving isManagedVm and related methods to the VM entity ...................................................................... core: moving isManagedVm and related methods to the VM entity Change-Id: Ia1ed04ea8a6430860fadc616c7c017ee1e2680ee Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java 2 files changed, 13 insertions(+), 14 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18283 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1ed04ea8a6430860fadc616c7c017ee1e2680ee Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Remove LUNs unused ctor
by amureini＠redhat.com 20 Aug '13

20 Aug '13

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Remove LUNs unused ctor ...................................................................... engine: Remove LUNs unused ctor Removed a constructor for LUNs only used by tests. Change-Id: I7ccdf1cc5fef4f4fc3977b274090604c1da42398 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LUNs.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostStorageResourceTest.java 2 files changed, 4 insertions(+), 8 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ccdf1cc5fef4f4fc3977b274090604c1da42398 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove unused query parameters classes
by amureini＠redhat.com 20 Aug '13

20 Aug '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused query parameters classes ...................................................................... core: Remove unused query parameters classes These class are no longer used anywhere in the codebase, and should thus be removed. Change-Id: Iadf482116e5b38a3b936ce84ba55fbed75725558 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmPoolsAttachedToAdGroupParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/StorageDomainQueryTopSizeVmsParameters.java 2 files changed, 0 insertions(+), 53 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18105 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iadf482116e5b38a3b936ce84ba55fbed75725558 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove VDS ctor only used in clone()
by amureini＠redhat.com 20 Aug '13

20 Aug '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove VDS ctor only used in clone() ...................................................................... core: Remove VDS ctor only used in clone() Removed the ctor that isn't used anywhere except in the clone() method. Removing this ctor makes the clone() method easier to understand, and the entire class easier to maintain. Change-Id: Id7094d3fc96676de6dc95a90614ac9f865fc1022 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java 1 file changed, 62 insertions(+), 158 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18111 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7094d3fc96676de6dc95a90614ac9f865fc1022 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove VdsDynamic ctor only used in tests
by amureini＠redhat.com 20 Aug '13

20 Aug '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove VdsDynamic ctor only used in tests ...................................................................... core: Remove VdsDynamic ctor only used in tests Removed the ctor that isn't used anywhere in production code. Change-Id: I22f4244e5c6cedcf2f36be7d10d078254b0a4bb3 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializationEntitiesTest.java 2 files changed, 38 insertions(+), 75 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18112 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22f4244e5c6cedcf2f36be7d10d078254b0a4bb3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove unused VDSGroup ctor
by amureini＠redhat.com 20 Aug '13

20 Aug '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused VDSGroup ctor ...................................................................... core: Remove unused VDSGroup ctor Removed the ctor that isn't used anywhere in the codebase. Change-Id: I8ec91916d482a45a42f13292814d876d37b28aef Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18118 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ec91916d482a45a42f13292814d876d37b28aef Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0