August 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Add support for vnic profiles
by masayag＠redhat.com 12 Aug '13

12 Aug '13

Moti Asayag has submitted this change and it was merged. Change subject: restapi: Add support for vnic profiles ...................................................................... restapi: Add support for vnic profiles The patch adds support for the vnic profiles model. The vnic profiles is added as a top collection and also as a sub collection of the network resource: /api/vnicprofiles/ /api/networks/{network:id}/vnicprofiles The POST'ed element should look like: <vnic_profile> <name>profile1</name> <network id="00000000-0000-0000-0000-000000000009"/> <port_mirroring>true</port_mirroring> </vnic_profile> Since the vnic profile is created for a network and it is not supported to switch an existing vnic profile between networks, the update action of the vnic profile is not supported under the networks collection, only under the top collection of the vnic profile. Adding or updating vms or templates nics will utilize the vnic profiles to define the connectivity of the vnic. For VMs via: POST: /api/vms/{vm:id}/nics/ PUT: /api/vms/{vm:id}/nics/{nic:id}/ For tempales via: POST: /api/templates/{template:id}/nics/ PUT: /api/templates/{template:id}/nics/{nic:id}/ The vnic profile will replace the deprecated network name and port mirroring. The former api for add or update a nic: <nic> ... <network name="ovirtmgmt"/> </nic> It is replaced by providing the vnic profile id: <nic> ... <vnic_profile id="fa5d0471-f83b-44ec-8715-7fe1a53ab7a6"/> </nic> See: http://www.ovirt.org/Features/Vnic_Profiles Change-Id: I7a0d472215ec1b0c359c0e2012e142ae8a627ce9 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/AssignedVnicProfileResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/AssignedVnicProfilesResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/NetworkResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VnicProfileResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VnicProfilesResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/BackendApplication.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendVnicProfileResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendVnicProfilesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedVnicProfileResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedVnicProfilesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendNetworkResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendNetworksResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVnicProfileResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVnicProfilesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendVnicProfilesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendAssignedVnicProfileResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendAssignedVnicProfilesResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVnicProfileResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVnicProfilesResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NicMapper.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VnicProfileMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/NicMapperTest.java A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VnicProfileMapperTest.java 29 files changed, 1,370 insertions(+), 3 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17587 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a0d472215ec1b0c359c0e2012e142ae8a627ce9 Gerrit-PatchSet: 28 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add external event error messages need to be improved
by emesika＠redhat.com 12 Aug '13

12 Aug '13

Eli Mesika has submitted this change and it was merged. Change subject: core: Add external event error messages need to be improved ...................................................................... core: Add external event error messages need to be improved Add external event error messages need to be improved Adding EventValidator class to validate severity enum values. The flood_rate can be omitted and the default is set to 30 (this was working prior to this patch) Change-Id: I743ff20bd3d4317bc054ba314ada6bd918a7502f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=949551 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendEventsResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/EventValidator.java 2 files changed, 18 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17929 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I743ff20bd3d4317bc054ba314ada6bd918a7502f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix wrong audit log on stop vm with hibernation vols
by ofrenkel＠redhat.com 12 Aug '13

12 Aug '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix wrong audit log on stop vm with hibernation vols ...................................................................... core: fix wrong audit log on stop vm with hibernation vols While stopping VM which is not suspended but has hibernation volumes (it could happen if we didn't manage to remove them when the VM reached UP state), the audit log described the operation as stopping suspended VM which is incorrect. This patch change this audit log such that the VM won't be described as suspended VM. Change-Id: If4ee5275477e989930a4c284a211755ebff76e33 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17693 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4ee5275477e989930a4c284a211755ebff76e33 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: handle 'image does not exists' error on remove hiberna...
by ofrenkel＠redhat.com 12 Aug '13

12 Aug '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: handle 'image does not exists' error on remove hibernation vols ...................................................................... core: handle 'image does not exists' error on remove hibernation vols Introducing HibernationVolumesRemover class which removes hibernation volumes with proper handling of 'image does not exists' error. This error is not treated as an error, because the result is that the images don't exists, as we wanted. HibernationVolumesRemover class is being used by RemoveVmHibernationVolumesCommand which is used by stop VM commands (stop and shutdown) and run VM command (in resume from hibernation flow in particular), eliminating the race described in bz 952603. Change-Id: Ief52a20315b29660c7038eab1cc8dbbb4c4ded3e Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmHibernationVolumesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/HibernationVolumesRemover.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemover.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemoverFromExportDomain.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/TaskHandlerCommand.java 6 files changed, 161 insertions(+), 73 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17474 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief52a20315b29660c7038eab1cc8dbbb4c4ded3e Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Locking in ExportRepoImageCommand
by derez＠redhat.com 12 Aug '13

12 Aug '13

Daniel Erez has submitted this change and it was merged. Change subject: core: Locking in ExportRepoImageCommand ...................................................................... core: Locking in ExportRepoImageCommand Added @LockIdNameAttribute to the command's locks will function properly. Change-Id: Ib8d15ef74b3cc40f6cdeacb3e838b9a496c1be26 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportRepoImageCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/17946 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8d15ef74b3cc40f6cdeacb3e838b9a496c1be26 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: RSDL - add 'deprecated' option
by oliel＠redhat.com 11 Aug '13

11 Aug '13

Ori Liel has submitted this change and it was merged. Change subject: restapi: RSDL - add 'deprecated' option ...................................................................... restapi: RSDL - add 'deprecated' option Mark parameter as deprecated in rsdl_metadata.yaml file this way: example for signature parameter: vm.display.type--DEPRECATED: xs:string example for url-param: max: {context: matrix, type: 'xs:int', value: 'max results', required: false, deprecated: true} example for header param: Filter: {value: true|false, required: false, deprecated: true} Change-Id: I5537c9065c13d9a68c88ab40ebf523bfe71e2a7b Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/ParamData.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/RsdlBuilder.java 3 files changed, 40 insertions(+), 12 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17624 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5537c9065c13d9a68c88ab40ebf523bfe71e2a7b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: host-deploy: lock vds when installing
by yzaslavs＠redhat.com 11 Aug '13

11 Aug '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: host-deploy: lock vds when installing ...................................................................... host-deploy: lock vds when installing Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=995501 Change-Id: I6bbd1102e85d30176c123ebb1999522a667c4e47 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17892 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6bbd1102e85d30176c123ebb1999522a667c4e47 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core, webadmin: allow edit unattached storage conn
by amureini＠redhat.com 11 Aug '13

11 Aug '13

Allon Mureinik has submitted this change and it was merged. Change subject: core, webadmin: allow edit unattached storage conn ...................................................................... core, webadmin: allow edit unattached storage conn Allow editing (updating) the path (connection) of an unattached storage domain. Before this change, it was allowed only for domains in maintenance state. Fix error messages accordingly to reflect this change as well. Change-Id: I42185d9306f5242b2258adbf8072288184393b63 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 88 insertions(+), 28 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42185d9306f5242b2258adbf8072288184393b63 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in otopi[master]: dialog: cli: handle tuple as multi-string
by Alon Bar-Lev 11 Aug '13

11 Aug '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: dialog: cli: handle tuple as multi-string ...................................................................... dialog: cli: handle tuple as multi-string Change-Id: I05fe007495ce40a8a685cefa930fb7f3607b422c Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/plugins/otopi/dialog/cli.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17927 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05fe007495ce40a8a685cefa930fb7f3607b422c Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: disable add profile in Net->Profiles subtab for no...
by alkaplan＠redhat.com 11 Aug '13

11 Aug '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: disable add profile in Net->Profiles subtab for non-vm networks ...................................................................... webadmin: disable add profile in Net->Profiles subtab for non-vm networks On the 'Network' main-tab --> 'Vnic Profiles' sub tab - the 'New vnic profile' action should be disabled if the selected network is non-vm. Change-Id: I7fcb31873285999a6fe05790fc9d62a250b5b4e3 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkProfileListModel.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17860 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7fcb31873285999a6fe05790fc9d62a250b5b4e3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0