August 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: set floppy path after vds is set on run vm
by ofrenkel＠redhat.com 12 Aug '13

12 Aug '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: set floppy path after vds is set on run vm ...................................................................... core: set floppy path after vds is set on run vm As a preliminary step in making IsoPrefixVDSCommand a VdsBrokerCommand instead of IrsBrokerCommand, the floppy path setting on run VM is moved to be made after the destination host on which the VM will be run on is set, so that we'll be able to query the iso prefix (which is needed for floppy path setting) from that host instead of from the SPM. Change-Id: I4737a3bc19e4810489eaf13a3ae98c07bfdd033e Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 5 insertions(+), 6 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17745 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4737a3bc19e4810489eaf13a3ae98c07bfdd033e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: minor cleanup in IrsBrokerCommand
by ofrenkel＠redhat.com 12 Aug '13

12 Aug '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: minor cleanup in IrsBrokerCommand ...................................................................... core: minor cleanup in IrsBrokerCommand 1. use StringUtils#isEmpty instead of duplicating its logic 2. simplified getCurrentIrsProxyData method Change-Id: I8ca113d5848c3b5cf2a9ec8b3e640eeeb3ebb393 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 1 file changed, 4 insertions(+), 7 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17744 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ca113d5848c3b5cf2a9ec8b3e640eeeb3ebb393 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: improve active iso domain lookup
by ofrenkel＠redhat.com 12 Aug '13

12 Aug '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: improve active iso domain lookup ...................................................................... core: improve active iso domain lookup The lookup for active iso domain at IsoDomainListSyncronizer#findActiveISODomain access the DB twice: at first to fetch all the domains in the given storage pool and then it access the DB again to fetch a given domain within the same storate pool. the second access seems to be redundant since the fetched domain already exists in the list that was return from the first query, thus the second query is removed. Change-Id: I8859a85107f8c2e658c23d6a04b69d0201d086d5 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java 1 file changed, 4 insertions(+), 9 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17578 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8859a85107f8c2e658c23d6a04b69d0201d086d5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: cleanup in RunVmCommand
by ofrenkel＠redhat.com 12 Aug '13

12 Aug '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: cleanup in RunVmCommand ...................................................................... core: cleanup in RunVmCommand 1. remove '_' prefix from class fields 2. define a static field that stores "iso://" string 3. use #cdPathWindowsToLinux method instead of calling ImagesHandler.cdPathWindowsToLinux explicitly in some places. 4. reference RunVmCommand#ISO_PREFIX from the test class, instead of defining the iso prefix string again in the test class 5. use IsoDomainListSyncronizer#findActiveISODomain to find active iso domain instead of having duplicated code 6. inline fields in canDoAction method 7. separate network interfaces validations in canDoAction method from the validator checks to make it more clear Change-Id: Ia37a78eacd6c415a9bf10920362140736c7d70fc Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java 2 files changed, 45 insertions(+), 60 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17577 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia37a78eacd6c415a9bf10920362140736c7d70fc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: LocalAdminPassword exception after engine restart
by yzaslavs＠redhat.com 12 Aug '13

12 Aug '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: LocalAdminPassword exception after engine restart ...................................................................... core: LocalAdminPassword exception after engine restart After oVirt host comes up from reboot, we see javax.crypto.BadPaddingException: Data must start with zero exception in engine.log: Change-Id: I3eb388c1cc806bdf190ceea7da222e1aa1843c52 Bug-Url: https://bugzilla.redhat.com/994454 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17934 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3eb388c1cc806bdf190ceea7da222e1aa1843c52 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: copy vm/template permissions fixes
by tjelinek＠redhat.com 12 Aug '13

12 Aug '13

Tomas Jelinek has submitted this change and it was merged. Change subject: engine: copy vm/template permissions fixes ...................................................................... engine: copy vm/template permissions fixes Changes: - set the copyVmPermissions on all required places on FE - the new permission is not assigned to the user creating the vm/template but to the user it has been assigned before - made sure that the same permission is not added twice (to not violate the unique constraint on the permissions table Change-Id: Ibe9d1b305c1275f695b954d52b8f49f4f775f119 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UniquePermissionsSet.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/permissions.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 6 files changed, 111 insertions(+), 38 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17869 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe9d1b305c1275f695b954d52b8f49f4f775f119 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Allowed creation of bonds in SetupNetworksHelper
by masayag＠redhat.com 12 Aug '13

12 Aug '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Allowed creation of bonds in SetupNetworksHelper ...................................................................... engine: Allowed creation of bonds in SetupNetworksHelper The validation used to check that any NIC to which VLAN-tagged networks were attached existed on the host; this no longer must be true since we've enabled adding new bonds that hadn't before existed on the host. Change-Id: I167758e86b32bd90f09203321f89bf1a5adc7bf6 Bug-Url: https://bugzilla.redhat.com/968190 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java 2 files changed, 31 insertions(+), 10 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17665 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I167758e86b32bd90f09203321f89bf1a5adc7bf6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: searchbackend: search host by id
by gchaplik＠redhat.com 12 Aug '13

12 Aug '13

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: searchbackend: search host by id ...................................................................... engine: searchbackend: search host by id 'id' isn't propmpt in the ui search bar, but is acceptable. Change-Id: I070a9eb4dece9973456f0233bf4dde2dbf7846ac Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VdsConditionFieldAutoCompleter.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17948 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I070a9eb4dece9973456f0233bf4dde2dbf7846ac Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fix cpu-pinning info icon message
by gchaplik＠redhat.com 12 Aug '13

12 Aug '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: fix cpu-pinning info icon message ...................................................................... webadmin: fix cpu-pinning info icon message To allow '\n' in SafeHtml. Change-Id: I5f4187c27f375911ada646c6f3d7ee59ec2dbeeb Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java 2 files changed, 12 insertions(+), 9 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17765 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f4187c27f375911ada646c6f3d7ee59ec2dbeeb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Create (or not) a vnic profile when adding network
by masayag＠redhat.com 12 Aug '13

12 Aug '13

Moti Asayag has submitted this change and it was merged. Change subject: restapi: Create (or not) a vnic profile when adding network ...................................................................... restapi: Create (or not) a vnic profile when adding network The patch allows the user to override the default behavior which is creating a default vnic profile for each network added to the system. The user will be able to create a network without a default vnic profile by providing the following element in the network POSTed element: <network> ... <profile_required>false</profile_required> </network> See: http://www.ovirt.org/Features/Vnic_Profiles Change-Id: I7f21fe627935a940db1a53da68ec8d55b2fb0973 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendNetworksResource.java 3 files changed, 10 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17610 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f21fe627935a940db1a53da68ec8d55b2fb0973 Gerrit-PatchSet: 25 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0