August 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: adding profile column to import vm/template and sn...
by alkaplan＠redhat.com 11 Aug '13

11 Aug '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: adding profile column to import vm/template and snapshot tables ...................................................................... webadmin: adding profile column to import vm/template and snapshot tables This patch adds the profile column to vm interface tab in import vm/template and snapshot tables after the network name column. Change-Id: I7f7e5800058942ebc97446ed9b953ec6108df322 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/PoolInterfaceListModelTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotInfoPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmPopupView.java 3 files changed, 25 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17859 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f7e5800058942ebc97446ed9b953ec6108df322 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: add network- create deafult profile just if no pro...
by alkaplan＠redhat.com 11 Aug '13

11 Aug '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: add network- create deafult profile just if no profiles provided ...................................................................... webadmin: add network- create deafult profile just if no profiles provided New Network dialog- if the user added profiles to the network the default profile shouldn't be created. Change-Id: Ib003d34ffbf044224eeb2cc055b20e21a38ca89b Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java 1 file changed, 15 insertions(+), 4 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib003d34ffbf044224eeb2cc055b20e21a38ca89b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: cluster policy: adding description and info icons
by gchaplik＠redhat.com 11 Aug '13

11 Aug '13

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: cluster policy: adding description and info icons ...................................................................... engine: cluster policy: adding description and info icons * A description field is added to each pre-defined policy unit. * A description will be shown in a tool-tip foreach policy unit in cluster policy dialog, as well as info icon explaining the various section in the dialog. Change-Id: Ib51cf7f15b7d73c87e0c728953171584216e1d00 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/PolicyUnit.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/scheduling/PolicyUnitDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/PolicyUnitDaoTest.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ClusterPolicyPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ClusterPolicyPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/panels/PolicyUnitPanel.java M packaging/dbscripts/policy_unit_sp.sql A packaging/dbscripts/upgrade/03_03_0740_add_description_to_policy_unit.sql 11 files changed, 169 insertions(+), 9 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17629 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib51cf7f15b7d73c87e0c728953171584216e1d00 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: scheduler: separate policy unit per class
by gchaplik＠redhat.com 11 Aug '13

11 Aug '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: scheduler: separate policy unit per class ...................................................................... core: scheduler: separate policy unit per class Each policy unit should implement a single file so None, EvenDistribution and PowerSaving policy units will be divided into two policy units, weight and balance. Change-Id: Id25cd653246e14a109b08d91adfb12ceccc505b4 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionBalancePolicyUnit.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionWeightPolicyUnit.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NoneBalancePolicyUnit.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NoneWeightPolicyUnit.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingBalancePolicyUnit.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingWeightPolicyUnit.java 7 files changed, 158 insertions(+), 79 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17781 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id25cd653246e14a109b08d91adfb12ceccc505b4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: pre-defined weight modules
by gchaplik＠redhat.com 11 Aug '13

11 Aug '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: pre-defined weight modules ...................................................................... core: pre-defined weight modules To be compatible with former scheduler. * none -> should use evenly distributed * even distribution -> weight will be calculated according to cpuLoad, is_spm (config), avg vm consumtions (config), vm's cpu count and host core count. * power saving -> host with no vm will be less likely to be selected, other hosts will be sorted (desc) by even distribution logic. Change-Id: I55cf5014bc472bf1e126a9737829e7fcf7e21853 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SlaValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionPolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NonePolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingPolicyUnit.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 8 files changed, 61 insertions(+), 12 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17750 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55cf5014bc472bf1e126a9737829e7fcf7e21853 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in otopi[master]: core: filetransaction: handle tuple as content
by Alon Bar-Lev 11 Aug '13

11 Aug '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: filetransaction: handle tuple as content ...................................................................... core: filetransaction: handle tuple as content Change-Id: I81bfce1c77d73f771daed5ef310fddf171f0fbbd Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/otopi/filetransaction.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17920 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81bfce1c77d73f771daed5ef310fddf171f0fbbd Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Removed ValueObjects
by amureini＠redhat.com 11 Aug '13

11 Aug '13

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Removed ValueObjects ...................................................................... engine: Removed ValueObjects The ValueObjects are a hierarchy of classes used a value containers. Since no business logic that still requires them exists, they can safely be removed along with the various utilities that make them usable (e.g., identity checking, custom [de]serialization, MixIn, etc.). Change-Id: If803494f7c10646c106058bdbb77d104d7d106fc Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ValueObject.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ValueObjectList.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ValueObjectMap.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ValueObjectPair.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ValueObjectSingle.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectDeserializer.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializer.java D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonValueObjectMapMixIn.java D frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/common/queries/ValueObjectMap_CustomFieldSerializer.java 10 files changed, 1 insertion(+), 305 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16820 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If803494f7c10646c106058bdbb77d104d7d106fc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove Unused methods from VdsFenceOptions
by amureini＠redhat.com 11 Aug '13

11 Aug '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove Unused methods from VdsFenceOptions ...................................................................... core: Remove Unused methods from VdsFenceOptions Removed the unused methods getFencingAgentInstanceOptionsMap(), setFencingAgentInstanceOptionsMap(ValueObjectMap), getFencingOptionTypesMap() and setFencingOptionTypesMap(ValueOptionMap) from VdsFenceOptions. Change-Id: I7f25ace235c3022a8b1299b08bf65250b4bce3f9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/pm/VdsFenceOptions.java 1 file changed, 0 insertions(+), 19 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16818 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f25ace235c3022a8b1299b08bf65250b4bce3f9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove unused method from VdcQueryRetunValue
by amureini＠redhat.com 11 Aug '13

11 Aug '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused method from VdcQueryRetunValue ...................................................................... core: Remove unused method from VdcQueryRetunValue Removed the unused method VdcQueryReturnValue.getSerializaedReturnValue(). Change-Id: If5ccfd595f002c96f9971c5ca607f40f1ee8498d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryReturnValue.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16819 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5ccfd595f002c96f9971c5ca607f40f1ee8498d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix HooksParser javadoc
by amureini＠redhat.com 11 Aug '13

11 Aug '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix HooksParser javadoc ...................................................................... core: Fix HooksParser javadoc Fixed HookParser's javadoc to reference Maps instead of ValueObjectMaps, which are not used by it. Change-Id: Icdd8c46a83aba4bd4386cb0c0a7288c0df6f0a9c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/vdshooks/VdsHooksParser.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16816 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icdd8c46a83aba4bd4386cb0c0a7288c0df6f0a9c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0