Change in ovirt-engine[ovirt-engine-3.3]: engine: handle unavailable external scheduler
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: engine: handle unavailable external scheduler
......................................................................
engine: handle unavailable external scheduler
handle the case when the external scheduler is not available when
calculating scores for the hosts
Change-Id: Ib5e60b4be166da95c1d46449b222e14220963784
Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
1 file changed, 12 insertions(+), 6 deletions(-)
Approvals:
Doron Fediuck: Looks good to me, approved
Gilad Chaplik: Verified
--
To view, visit http://gerrit.ovirt.org/18558
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5e60b4be166da95c1d46449b222e14220963784
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[ovirt-engine-3.3]: engine: start discovery thread only if enabled
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: engine: start discovery thread only if enabled
......................................................................
engine: start discovery thread only if enabled
Checks the external scheduler configuration before starting the external
scheduler discovery thread. Added logging for better tracing.
Change-Id: Ibac067131d3725d39afaf2f4941165eccdb60372
Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
1 file changed, 7 insertions(+), 2 deletions(-)
Approvals:
Doron Fediuck: Looks good to me, approved
Gilad Chaplik: Verified
--
To view, visit http://gerrit.ovirt.org/18557
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibac067131d3725d39afaf2f4941165eccdb60372
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[ovirt-engine-3.3]: engine: initialize scheduling manager from InitBackendServic...
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: engine: initialize scheduling manager from InitBackendServicesOnStartupBean
......................................................................
engine: initialize scheduling manager from InitBackendServicesOnStartupBean
Schedling manager initialize made public, call removed from constructor
and added to InitBackendServicesOnStartupBean. Additional logging for
better tracing.
Change-Id: Ic74d28c2aa9700527f6217f4de2a2b4527286317
Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
2 files changed, 5 insertions(+), 3 deletions(-)
Approvals:
Doron Fediuck: Looks good to me, approved
Gilad Chaplik: Verified
--
To view, visit http://gerrit.ovirt.org/18556
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic74d28c2aa9700527f6217f4de2a2b4527286317
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[ovirt-engine-3.3]: engine: external scheduler integration
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: engine: external scheduler integration
......................................................................
engine: external scheduler integration
This patch adds a new ExternalSchedulingManager class to handle
communication with the external scheduler proxy. Other changes:
- added configuration values (scheduler proxy url, enable/disable)
- added external scheduler invocation to vds filtering
- error messages
Change-Id: I95b6660beb319df0afe569f31c16033bf6192df9
Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com>
---
M backend/manager/modules/bll/pom.xml
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBroker.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerImpl.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscoveryResult.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscoveryThread.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscoveryUnit.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerFactory.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
M packaging/etc/engine-config/engine-config.properties
12 files changed, 759 insertions(+), 21 deletions(-)
Approvals:
Doron Fediuck: Looks good to me, approved
Gilad Chaplik: Verified
--
To view, visit http://gerrit.ovirt.org/18555
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I95b6660beb319df0afe569f31c16033bf6192df9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[ovirt-engine-3.3]: core: scheduler: change parameter map type
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: core: scheduler: change parameter map type
......................................................................
core: scheduler: change parameter map type
The external scheduler is now expecting a string map with vm id instead
of vm entity, therefore, changing the parameter map to hold strings (instead of objects),
and passing the vm entity as a seperate parameter.
Change-Id: Ie0475218e2b66fcd48faf0b92ac2873c4b448c0e
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CPUPolicyUnit.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionPolicyUnit.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/MemoryPolicyUnit.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/MigrationDomainPolicyUnit.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/MigrationPolicyUnit.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NetworkPolicyUnit.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NonePolicyUnit.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PinToHostPolicyUnit.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingPolicyUnit.java
11 files changed, 29 insertions(+), 32 deletions(-)
Approvals:
Doron Fediuck: Looks good to me, approved
Gilad Chaplik: Verified
--
To view, visit http://gerrit.ovirt.org/18554
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0475218e2b66fcd48faf0b92ac2873c4b448c0e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[ovirt-engine-3.3]: engine: add enabled column to policy_units
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: engine: add enabled column to policy_units
......................................................................
engine: add enabled column to policy_units
As part of the External scheduler integration:
- Added "enabled" field to policy unit object, dao, and db
This patch is meant to decrease the size and simplify
the External Scheduler integration patch
Change-Id: I6be407297c259aedf17283d2f674021cf0e4a135
Signed-off-by: Noam Slomianko <nslomian(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/PolicyUnit.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/scheduling/PolicyUnitDaoImpl.java
M packaging/dbscripts/policy_unit_sp.sql
A packaging/dbscripts/upgrade/03_03_0660_add_enabled_column_to_policy_unit.sql
5 files changed, 40 insertions(+), 7 deletions(-)
Approvals:
Doron Fediuck: Looks good to me, approved
Gilad Chaplik: Verified
--
To view, visit http://gerrit.ovirt.org/18553
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6be407297c259aedf17283d2f674021cf0e4a135
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[ovirt-engine-3.3]: webadmin: custom properties sheet: tooltip for key
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: webadmin: custom properties sheet: tooltip for key
......................................................................
webadmin: custom properties sheet: tooltip for key
Show tool-tip for selected key, when hovering on keys drop-down.
Since keys are user defined it can overflow the widget width, therefore
a tooltip is needed.
Change-Id: I2118f78e340923e89e0008c2c8b8bb9c9a19466b
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueLineWidget.java
1 file changed, 22 insertions(+), 1 deletion(-)
Approvals:
Doron Fediuck: Looks good to me, approved
Gilad Chaplik: Verified
--
To view, visit http://gerrit.ovirt.org/18552
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2118f78e340923e89e0008c2c8b8bb9c9a19466b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[ovirt-engine-3.3]: core: policy unit crud store proc
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: core: policy unit crud store proc
......................................................................
core: policy unit crud store proc
Insert and Update policy unit db store procedures with tests
Change-Id: I8838ae56c2ed927428c54e0319865425c54f51d7
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/scheduling/PolicyUnitDaoImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/PolicyUnitDaoTest.java
M packaging/dbscripts/policy_unit_sp.sql
4 files changed, 69 insertions(+), 2 deletions(-)
Approvals:
Doron Fediuck: Looks good to me, approved
Gilad Chaplik: Verified
--
To view, visit http://gerrit.ovirt.org/18551
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8838ae56c2ed927428c54e0319865425c54f51d7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[ovirt-engine-3.3]: core: fixing findbugs errors
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: core: fixing findbugs errors
......................................................................
core: fixing findbugs errors
* fixing wrong caching
* no refernce to field
Change-Id: Iad6f990d93bfdc5bfbd7179cffee4893ef40ccc5
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/scheduling/ClusterPolicyDaoImpl.java
1 file changed, 4 insertions(+), 7 deletions(-)
Approvals:
Doron Fediuck: Looks good to me, approved
Gilad Chaplik: Verified
--
To view, visit http://gerrit.ovirt.org/18550
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iad6f990d93bfdc5bfbd7179cffee4893ef40ccc5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[ovirt-engine-3.3]: engine: policy unit should contain single logic
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: engine: policy unit should contain single logic
......................................................................
engine: policy unit should contain single logic
Utill now policy unit could hold logic for filtering, weighing or
balancing (one or more). in this patch each policy unit could hold a
single logic, according to a type field (enum) added to the entity.
Change-Id: Ia6f1d88c7c9bbc600dba0199a7cab27d914c68f4
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/ClusterPolicyCRUDCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/PolicyUnit.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/PolicyUnitType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/scheduling/ClusterPolicyDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/scheduling/PolicyUnitDaoImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/PolicyUnitDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/scheduling/ClusterPolicyListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/scheduling/NewClusterPolicyModel.java
M packaging/dbscripts/cluster_policy_sp.sql
A packaging/dbscripts/upgrade/03_03_0650_allow_single_logic_for_policy_unit.sql
12 files changed, 112 insertions(+), 148 deletions(-)
Approvals:
Doron Fediuck: Looks good to me, approved
Gilad Chaplik: Verified
--
To view, visit http://gerrit.ovirt.org/18549
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6f1d88c7c9bbc600dba0199a7cab27d914c68f4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
11 years, 4 months