Change in mom[master]: mom: communicate with qemu-guest-agent using hypervisor_ifac...
by agl＠us.ibm.com
Adam Litke has submitted this change and it was merged.
Change subject: mom: communicate with qemu-guest-agent using hypervisor_iface via libvirt
......................................................................
mom: communicate with qemu-guest-agent using hypervisor_iface via libvirt
When the unix socket is defined for the qemu-guest-agent, libvirt connects
to the socket for its internal usage, and so the other client cannot use it.
Instead, libvirt_qemu provides an interface to communicate with the guest
agent. With this patch, GuestQemuAgent will firstly try to communicate with
the guest agent using libvirt via hypervisor_iface. When hypervisor_iface
cannot provide access to the agent, it falls back to the socket interface.
Change-Id: I8ba8d3cda466ca5212f4365ff3ee9ff2864524d6
Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama(a)hds.com>
Reviewed-on: http://gerrit.ovirt.org/18888
Reviewed-by: Adam Litke <agl(a)us.ibm.com>
Tested-by: Adam Litke <agl(a)us.ibm.com>
---
M mom/Collectors/GuestQemuAgent.py
M mom/Collectors/QemuGuestAgentClient.py
M mom/HypervisorInterfaces/libvirtInterface.py
3 files changed, 62 insertions(+), 8 deletions(-)
Approvals:
Adam Litke: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18888
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8ba8d3cda466ca5212f4365ff3ee9ff2864524d6
Gerrit-PatchSet: 3
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Tomoki Sekiyama <tomoki.sekiyama(a)hds.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Tomoki Sekiyama <tomoki.sekiyama(a)hds.com>
10 years, 8 months
Change in mom[master]: mom: Fix KeyError exception while qemu-guest-agent error han...
by agl＠us.ibm.com
Adam Litke has submitted this change and it was merged.
Change subject: mom: Fix KeyError exception while qemu-guest-agent error handling
......................................................................
mom: Fix KeyError exception while qemu-guest-agent error handling
Current version of qemu-guest-agent reports error messages in the format:
{"error":{"class":"GenericError","desc":"..."}}
GuestQemuAgent tries to get "data" member on the error response, and results
in KeyError exception as the response doesn't have it. Catch the exception,
and also reference "desc" member for the error message.
Change-Id: Ibfb84eac189716513f686d5b035056a0c1bc36d3
Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama(a)hds.com>
Reviewed-on: http://gerrit.ovirt.org/18887
Reviewed-by: Adam Litke <agl(a)us.ibm.com>
Tested-by: Adam Litke <agl(a)us.ibm.com>
---
M mom/Collectors/GuestQemuAgent.py
1 file changed, 12 insertions(+), 3 deletions(-)
Approvals:
Adam Litke: Verified; Looks good to me, approved
Tomoki Sekiyama: Verified
--
To view, visit http://gerrit.ovirt.org/18887
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibfb84eac189716513f686d5b035056a0c1bc36d3
Gerrit-PatchSet: 2
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Tomoki Sekiyama <tomoki.sekiyama(a)hds.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Tomoki Sekiyama <tomoki.sekiyama(a)hds.com>
10 years, 8 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: vdsm: add console device to the VM
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: vdsm: add console device to the VM
......................................................................
vdsm: add console device to the VM
Add console device to the Hosted Engine VM definition.
Allows to connect to the VM without X.
Change-Id: Ieabe9538571a6e4e18217a728c71677225b1fddb
Bug-Url: https://bugzilla.redhat.com/1001706
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/ovirt_hosted_engine_setup/constants.py
M src/plugins/ovirt-hosted-engine-setup/vm/configurevm.py
M src/plugins/ovirt-hosted-engine-setup/vm/runvm.py
M templates/vm.conf.in
4 files changed, 36 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19394
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieabe9538571a6e4e18217a728c71677225b1fddb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.0
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: vdsm: use devices instead of drives in vm.conf
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: vdsm: use devices instead of drives in vm.conf
......................................................................
vdsm: use devices instead of drives in vm.conf
Previously the setup used the keywords drives, cdrom,
nicModel, bridge and macAddr for configuring the VM
devices.
Such keywords seem to be obsolete and lead to having
the share:exclusive option not working correctly on drives.
Now it uses the keyword devices for configuring all the devices
and drives in order to have share:exclusive support.
Change-Id: Idbe61b2ef899320f304cd30b5b365e2a523acd49
Bug-Url: https://bugzilla.redhat.com/1008391
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/ovirt_hosted_engine_setup/constants.py
M src/plugins/ovirt-hosted-engine-setup/vm/configurevm.py
M templates/vm.conf.in
3 files changed, 34 insertions(+), 11 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19393
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idbe61b2ef899320f304cd30b5b365e2a523acd49
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.0
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-hosted-engine-setup[master]: vdsm: add console device to the VM
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: vdsm: add console device to the VM
......................................................................
vdsm: add console device to the VM
Add console device to the Hosted Engine VM definition.
Allows to connect to the VM without X.
Change-Id: Ieabe9538571a6e4e18217a728c71677225b1fddb
Bug-Url: https://bugzilla.redhat.com/1001706
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/ovirt_hosted_engine_setup/constants.py
M src/plugins/ovirt-hosted-engine-setup/vm/configurevm.py
M src/plugins/ovirt-hosted-engine-setup/vm/runvm.py
M templates/vm.conf.in
4 files changed, 36 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19369
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieabe9538571a6e4e18217a728c71677225b1fddb
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Leonid Natapov <leonidnatapov(a)gmail.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Timothy Hildred <thildred(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-hosted-engine-setup[master]: vdsm: use devices instead of drives in vm.conf
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: vdsm: use devices instead of drives in vm.conf
......................................................................
vdsm: use devices instead of drives in vm.conf
Previously the setup used the keywords drives, cdrom,
nicModel, bridge and macAddr for configuring the VM
devices.
Such keywords seem to be obsolete and lead to having
the share:exclusive option not working correctly on drives.
Now it uses the keyword devices for configuring all the devices
and drives in order to have share:exclusive support.
Change-Id: Idbe61b2ef899320f304cd30b5b365e2a523acd49
Bug-Url: https://bugzilla.redhat.com/1008391
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/ovirt_hosted_engine_setup/constants.py
M src/plugins/ovirt-hosted-engine-setup/vm/configurevm.py
M templates/vm.conf.in
3 files changed, 34 insertions(+), 11 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19289
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idbe61b2ef899320f304cd30b5b365e2a523acd49
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Leonid Natapov <leonidnatapov(a)gmail.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: webadmin: gluster volume rebalance status popup
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: webadmin: gluster volume rebalance status popup
......................................................................
webadmin: gluster volume rebalance status popup
Added a new action 'Status' under the 'Rebalance' actions group.
On clicking the 'Status' action 'Rebalance Status' popup for
the selected gluster volume will be shown.
Change-Id: I0d1f63b21dfbed88fa2b4e8c077e3e5e54ba7b09
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
Signed-off-by: Anmol Babu <anbabu(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/SizeConverter.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeRebalanceStatusModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationMessages.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VolumeModule.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/gluster/VolumeRebalanceStatusPopupPresenterWidget.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeRebalanceStatusPopupView.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeRebalanceStatusPopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/RebalanceFileSizeRenderer.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/RebalanceFileSizeColumn.java
16 files changed, 711 insertions(+), 7 deletions(-)
Approvals:
Kanagaraj M: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18328
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0d1f63b21dfbed88fa2b4e8c077e3e5e54ba7b09
Gerrit-PatchSet: 45
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: webadmin: set 100% width for NfsStorageView->overrideEditor
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: set 100% width for NfsStorageView->overrideEditor
......................................................................
webadmin: set 100% width for NfsStorageView->overrideEditor
Change-Id: I305b278a8af8eb2da85899c513847bc7f342cf36
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19388
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I305b278a8af8eb2da85899c513847bc7f342cf36
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
10 years, 8 months
Change in ovirt-engine[master]: frontend: fix broken layout in new/edit vm -> console tab
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: fix broken layout in new/edit vm -> console tab
......................................................................
frontend: fix broken layout in new/edit vm -> console tab
This regression has been introduced by
09d246450ad7b7fbda1dcf54c806fdb8d181a201
This patch adds the possibility to turn off the feature
introduced in the mentioned patch.
Change-Id: If4f8ec3b9426059803a3331c47bffc7cad9ac6c5
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseEntityModelCheckboxEditor.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCheckBoxEditor.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
4 files changed, 15 insertions(+), 5 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19383
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If4f8ec3b9426059803a3331c47bffc7cad9ac6c5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: engine: enrich TimeZoneValidator
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: engine: enrich TimeZoneValidator
......................................................................
engine: enrich TimeZoneValidator
TimeZoneValidator expected that the empty time zone has to be
null - but it actually can also be an empty string.
Change-Id: I78e6e8feb3a17bbc906e27a47f61f60bd24ed994
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/TimeZoneValidator.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19380
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I78e6e8feb3a17bbc906e27a47f61f60bd24ed994
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months