September 2013 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-setup[master]: packaging: setup: fix defaults initializations on additional...
by sbonazzo＠redhat.com 30 Sep '13

30 Sep '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: fix defaults initializations on additional host ...................................................................... packaging: setup: fix defaults initializations on additional host Fixed initialization of ohostedcons.VDSMEnv.VDSM_CPU using setdefault instead of direct assignment. Fixed initializatoin of variables set by remote answer file Change-Id: I959ad89b10c4cf34902d353bc6778a598eed670a Bug-Url: https://bugzilla.redhat.com/1013557 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/core/remote_answerfile.py M src/plugins/ovirt-hosted-engine-setup/vdsmd/cpu.py 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I959ad89b10c4cf34902d353bc6778a598eed670a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Leonid Natapov <leonidnatapov(a)gmail.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: verify VirtIO-SCSI enabled on DiskValidator
by derez＠redhat.com 30 Sep '13

30 Sep '13

Daniel Erez has submitted this change and it was merged. Change subject: core: verify VirtIO-SCSI enabled on DiskValidator ...................................................................... core: verify VirtIO-SCSI enabled on DiskValidator * DiskValidator -> isVirtIoScsiValid: VirtIO-SCSI interface is valid only when VirtIO-SCSI is enabled for the VM (i.e. a controller is attached to the VM). * Altered relevant commands/tests accordingly. Change-Id: Iff20860a8462df49afbc21a66faf2614904a7a72 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 12 files changed, 73 insertions(+), 7 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff20860a8462df49afbc21a66faf2614904a7a72 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Cheryn Tan <cheryntan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: improve logging on memory volumes removal failure
by ofrenkel＠redhat.com 30 Sep '13

30 Sep '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: improve logging on memory volumes removal failure ...................................................................... core: improve logging on memory volumes removal failure Change the logging that is printed when failing to remove memory volumes to provide more information. This patch also contains some refactoring which should make the 'endVmCommand' method in create-all-snapshots command more simple and readable. Change-Id: I67897b5cd07033aff624242cdaa67d517eb14bf9 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemover.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Snapshot.java 3 files changed, 29 insertions(+), 36 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19639 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67897b5cd07033aff624242cdaa67d517eb14bf9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Host interface manual refresh
by ecohen＠redhat.com 30 Sep '13

30 Sep '13

Einav Cohen has submitted this change and it was merged. Change subject: webadmin: Host interface manual refresh ...................................................................... webadmin: Host interface manual refresh - Fixed issue where the refresh would cause a scrollbar to appear when manually refreshing the HostInterface - Added manual refresh event being fired when the user clicks the refresh button on the top right of the grid. Change-Id: I3e38c077a6eeef335fe1f8e8f468c70a5ca8ad92 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=967546 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/AbstractRefreshManager.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/ManualRefresh.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/SimpleActionTable.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostInterfacePresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostInterfaceView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/HostInterfaceForm.java 6 files changed, 48 insertions(+), 6 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19143 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e38c077a6eeef335fe1f8e8f468c70a5ca8ad92 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: UX: better explanation of graphical support
by sbonazzo＠redhat.com 30 Sep '13

30 Sep '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: UX: better explanation of graphical support ...................................................................... UX: better explanation of graphical support Explain what it means to be able to run graphical applications. Change-Id: I4c8bcf66fd4e1ff1044c948264c0b40644915474 Bug-Url: https://bugzilla.redhat.com/1001706 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/vm/runvm.py 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19687 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c8bcf66fd4e1ff1044c948264c0b40644915474 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: UX: notify download of answer file status
by sbonazzo＠redhat.com 30 Sep '13

30 Sep '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: UX: notify download of answer file status ...................................................................... UX: notify download of answer file status Notify successfull download of answer file. Better handling of the notify of failure when the password is provided by the answer file. Bug-Url: https://bugzilla.redhat.com/1007422 Change-Id: I2ed7fae0ee808b9d7e59409fae0f7e4edbb9bf92 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/core/remote_answerfile.py 1 file changed, 18 insertions(+), 7 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19686 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ed7fae0ee808b9d7e59409fae0f7e4edbb9bf92 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-hosted-engine-setup[master]: UX: better explanation of graphical support
by sbonazzo＠redhat.com 30 Sep '13

30 Sep '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: UX: better explanation of graphical support ...................................................................... UX: better explanation of graphical support Explain what it means to be able to run graphical applications. Change-Id: I4c8bcf66fd4e1ff1044c948264c0b40644915474 Bug-Url: https://bugzilla.redhat.com/1001706 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/vm/runvm.py 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve Greg Padgett: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/19680 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c8bcf66fd4e1ff1044c948264c0b40644915474 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Leonid Natapov <leonidnatapov(a)gmail.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Timothy Hildred <thildred(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: UX: notify download of answer file status
by sbonazzo＠redhat.com 30 Sep '13

30 Sep '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: UX: notify download of answer file status ...................................................................... UX: notify download of answer file status Notify successfull download of answer file. Better handling of the notify of failure when the password is provided by the answer file. Bug-Url: https://bugzilla.redhat.com/1007422 Change-Id: I2ed7fae0ee808b9d7e59409fae0f7e4edbb9bf92 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/core/remote_answerfile.py 1 file changed, 18 insertions(+), 7 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve Greg Padgett: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/19678 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ed7fae0ee808b9d7e59409fae0f7e4edbb9bf92 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Leonid Natapov <leonidnatapov(a)gmail.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: ExtendSANDomain - setActionMessageParameters
by derez＠redhat.com 30 Sep '13

30 Sep '13

Daniel Erez has submitted this change and it was merged. Change subject: core: ExtendSANDomain - setActionMessageParameters ...................................................................... core: ExtendSANDomain - setActionMessageParameters ExtendSANStorageDomainCommand: moved CanDoActionMessage to setActionMessageParameters method. Change-Id: I4acd5becd4a8c600f2b2297ff1babb57dab3f89c Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ExtendSANStorageDomainCommand.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19635 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4acd5becd4a8c600f2b2297ff1babb57dab3f89c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: removed redundant commented out code
by derez＠redhat.com 30 Sep '13

30 Sep '13

Daniel Erez has submitted this change and it was merged. Change subject: core: removed redundant commented out code ...................................................................... core: removed redundant commented out code AddSANStorageDomainCommand - removed redundant commented out code. Change-Id: I2068b8e0a58d46c891d45cd25a10c74708f01448 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddSANStorageDomainCommand.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19634 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2068b8e0a58d46c891d45cd25a10c74708f01448 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0