Change in ovirt-engine[master]: core: remove memory volumes without tasks on snapshot creati...
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: remove memory volumes without tasks on snapshot creation failure
......................................................................
core: remove memory volumes without tasks on snapshot creation failure
On the end-action phase of snapshot creation command, we check if the VM
is runningto see whether we should take live snapshot or not. If the VM
is not running and we created images that will be used to store the
memory, we try to remove those images. There was a problem that the
remove image operations created tasks that were not polled (they are not
polled automatically since we're in the end-action phase, and we didn't
explicitly asked to poll them).
Since we have nothing to do in case of failure (if the file deletion
didn't work, it most probably won't work on retry), we now don't create
tasks on those delete image operations.
New command RemoveMemoryVolumesCommand is added to do so, to achieve
better separation of concerns, which will also make it possible to reuse
it on other cases.
Change-Id: I3830992f46b2c3fbea47e69f21a6711718408e95
Bug-Url: https://bugzilla.redhat.com/1011474
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveMemoryVolumesCommand.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveMemoryVolumesParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
4 files changed, 160 insertions(+), 1 deletion(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19568
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3830992f46b2c3fbea47e69f21a6711718408e95
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[master]: core: LUNs validation on storage creation
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: LUNs validation on storage creation
......................................................................
core: LUNs validation on storage creation
On create/extend storage domain, validate that the specified
LUNs aren't already part of another storage domain
or used by DirectLUN disks.
Change-Id: Ia39a19374169fce20850b187a6d4201ff34ef0d8
Bug-Url: https://bugzilla.redhat.com/955661
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddSANStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ExtendSANStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBaseTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
9 files changed, 105 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19633
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia39a19374169fce20850b187a6d4201ff34ef0d8
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Cheryn Tan <cheryntan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: hostname: correct interfaces RE
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: packaging: setup: hostname: correct interfaces RE
......................................................................
packaging: setup: hostname: correct interfaces RE
There was a tiny bug in http://gerrit.ovirt.org/18962 - it caused
some interface names to not be recognized. Fixed.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1009990
Change-Id: Id19851ac46307f413ddd7cb56c3f6d1d6c5627bf
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/config/hostname.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19671
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id19851ac46307f413ddd7cb56c3f6d1d6c5627bf
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[ovirt-engine-3.3]: engine: Remove GetTimeZonesQuery usages
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: engine: Remove GetTimeZonesQuery usages
......................................................................
engine: Remove GetTimeZonesQuery usages
Removed last usages of the no loger existing GetTimeZonesQuery in
fronted and replaced with usage of the new TimeZoneType enum.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1011547
Change-Id: I575460833def554cfe5c8b6e4ec4a08c09167bb8
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/CloudInitModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
4 files changed, 10 insertions(+), 37 deletions(-)
Approvals:
Martin Betak: Verified
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19617
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I575460833def554cfe5c8b6e4ec4a08c09167bb8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[master]: engine: updated out-of-date README.branding
by ecohen＠redhat.com
Einav Cohen has submitted this change and it was merged.
Change subject: engine: updated out-of-date README.branding
......................................................................
engine: updated out-of-date README.branding
Added info to README.branding about some recent additions such as
external_resources.properties and BrandingCascadingResourceServlet.
Change-Id: Idf5b4e3c1f47adefe0ee37f580a7aa6954f2d3d5
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M README.branding
1 file changed, 47 insertions(+), 4 deletions(-)
Approvals:
Einav Cohen: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19340
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idf5b4e3c1f47adefe0ee37f580a7aa6954f2d3d5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[master]: core: ignore findbugs error for not overriding hashCode()
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: ignore findbugs error for not overriding hashCode()
......................................................................
core: ignore findbugs error for not overriding hashCode()
Findbugs complains that recently added classes which override equals()
method don't override hashCode() method, thus violating the invariant
that equal objects must have equal hashcodes.
This error is irrelevant because the hash code of those classes will not
be used for sure.
Change-Id: I34b5932eddb3a54391eeab4b203d8f68ca5fe546
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/exclude-filters.xml
1 file changed, 28 insertions(+), 0 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19168
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I34b5932eddb3a54391eeab4b203d8f68ca5fe546
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[master]: engine: Engine has to delete image from DB after VDSM remove...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: Engine has to delete image from DB after VDSM removed it
......................................................................
engine: Engine has to delete image from DB after VDSM removed it
Engine has to delete image from DB after VDSM removed it from storage,
but thrown an error in the process. What is really matter in this case
is whether the image still exists on the storage or not.
VDSM renames the image as a first step to removal. After renaming the
image doesn't exist, so if the error is thrown at this point the garbage
will stay on the storage, but its safe to remove image from DB.
Change-Id: If6e6922b153145de6d4515812c1cfede687544bc
Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java
1 file changed, 32 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19161
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If6e6922b153145de6d4515812c1cfede687544bc
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Force uniform capitalization of "vNIC"
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Force uniform capitalization of "vNIC"
......................................................................
webadmin: Force uniform capitalization of "vNIC"
There were several variations of capitalization, made them all the
same.
Change-Id: I4c8dd1c43f7d3e9fe38fa3c1b1b2592488e0090b
Bug-Url: https://bugzilla.redhat.com/970900
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
2 files changed, 8 insertions(+), 8 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19649
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4c8dd1c43f7d3e9fe38fa3c1b1b2592488e0090b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[ovirt-engine-3.3]: core: failing to assign disk quota
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: failing to assign disk quota
......................................................................
core: failing to assign disk quota
missing default c'tor in parameter class caused some of
the parameters to be null.
Change-Id: Id39828bf3116b26e85609488267b128a2dd5bab9
Bug-Url: https://bugzilla.redhat.com/1000399
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ChangeQuotaParameters.java
1 file changed, 25 insertions(+), 6 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19655
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id39828bf3116b26e85609488267b128a2dd5bab9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[ovirt-engine-3.3]: webadmin: policy: fields reset when changing options
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: policy: fields reset when changing options
......................................................................
webadmin: policy: fields reset when changing options
Problem: When changing the cluster policy properties (filters/weight/balance)
the custom properties sheet was reset.
Solution: refresh the custom propeties sheet inculding the
values that already set.
Change-Id: Ibb3092953f3ff387625cf00c146f63ea41f58de2
Bug-Url: https://bugzilla.redhat.com/1002171
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/scheduling/NewClusterPolicyModel.java
1 file changed, 13 insertions(+), 9 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19654
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb3092953f3ff387625cf00c146f63ea41f58de2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months