Change in ovirt-engine[ovirt-engine-3.3]: core: scheduling: remove migration filter
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: scheduling: remove migration filter
......................................................................
core: scheduling: remove migration filter
it seems that without migration filter (filters out the
'migration from' host), the scheduler can select the same source host.
solution: remove the migration filter, and in migrate
vm add the source host to the scheduler host black list.
Change-Id: Ibd1007bbc5be01043203cd4eff1aa52c6fb03a13
Bug-Url: https://bugzilla.redhat.com/1008153
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java
A packaging/dbscripts/upgrade/03_03_0910_remove_migration_filter.sql
3 files changed, 12 insertions(+), 5 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19653
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd1007bbc5be01043203cd4eff1aa52c6fb03a13
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Fixed provider name validation
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Fixed provider name validation
......................................................................
webadmin: Fixed provider name validation
Frontend only made sure that the name was non-empty, while the backend
enforced ASCII characters; now they're the same.
Change-Id: I552ab44967789c9ffbbd4b05758a36223da17d43
Bug-Url: https://bugzilla.redhat.com/987294
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19651
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I552ab44967789c9ffbbd4b05758a36223da17d43
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Changed arrow sign from text to image
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Changed arrow sign from text to image
......................................................................
webadmin: Changed arrow sign from text to image
Used to have the Unicode characters for triangles as the label of a
button, but would come out garbled in non-English locales. Now using
an image instead, with the help of ShapedButton.
Also took the chance to give HorizontalSplitTable and
ImportNetworksPopupView a tighter look with the help of a designer.
Change-Id: I55f73d3edc261e4e16c19a7e345dbb1dc105c9b2
Bug-Url: https://bugzilla.redhat.com/1000285
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationResources.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/HorizontalSplitTable.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/HorizontalSplitTable.ui.xml
A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/arrows/tri_down_click.png
A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/arrows/tri_down_disabled.png
A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/arrows/tri_down_normal.png
A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/arrows/tri_down_over.png
A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/arrows/tri_up_click.png
A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/arrows/tri_up_disabled.png
A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/arrows/tri_up_normal.png
A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/arrows/tri_up_over.png
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ImportNetworksPopupView.ui.xml
13 files changed, 60 insertions(+), 29 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19457
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I55f73d3edc261e4e16c19a7e345dbb1dc105c9b2
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Added ShapedButton class
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Added ShapedButton class
......................................................................
webadmin: Added ShapedButton class
It represents a custom-shaped button whose faces change according to
supplied image files.
Change-Id: I83eafafa7ca480b350d4b1b96aa560fd184acbad
Bug-Url: https://bugzilla.redhat.com/1000285
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/ShapedButton.java
1 file changed, 48 insertions(+), 0 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19456
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I83eafafa7ca480b350d4b1b96aa560fd184acbad
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Removed image resources no longer in use
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Removed image resources no longer in use
......................................................................
webadmin: Removed image resources no longer in use
The arrow images were removed from the VM boot sequence buttons, but
their ImageResource fetch methods were forgotten.
Change-Id: I34ee07c7cc0b9f10e08d2b59038bc7020f614f20
Bug-Url: https://bugzilla.redhat.com/1000285
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationResources.java
1 file changed, 0 insertions(+), 6 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19455
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I34ee07c7cc0b9f10e08d2b59038bc7020f614f20
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[ovirt-engine-3.3]: core: add foreign key to quota_id
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: add foreign key to quota_id
......................................................................
core: add foreign key to quota_id
problem: quota_id field (in vm_static and images) isn't linked
to quota table, therefore when removing a quota, it doesn't clear
the quota_id ref.
solution: set quota_id fields as foreign keys and use
set NULL on delete.
Currently there is extensive usage of Guid.Empty to indicate
null, removed that in relevant DAOs.
Upgrade:
- set NULL instead of Guid.Empty
- set NULL instead of non-existing quota ids
- add the foreign key constraint
Change-Id: I5092a3070937719009fa1fb4fb9ecb792f03b969
Bug-Url: https://bugzilla.redhat.com/1003839
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java
A packaging/dbscripts/upgrade/03_03_0900_quota_id_foreign_key.sql
6 files changed, 16 insertions(+), 5 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19652
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5092a3070937719009fa1fb4fb9ecb792f03b969
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
11 years, 2 months
Change in ovirt-engine[master]: core: fix sound device check when adding devices from ovf (#...
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: fix sound device check when adding devices from ovf (#1004066)
......................................................................
core: fix sound device check when adding devices from ovf (#1004066)
When creating vm from ovf, there is a check to add sound device to the
vm if it doesn't exist and needed.
the existence check was wrong as it used 'device' compared with 'type'.
this patch fix the check to use the correct fields (type).
Change-Id: I117c18f95db1ed672f6d0a8c4ff5c003d3fb6d4a
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1004066
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java
2 files changed, 5 insertions(+), 1 deletion(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I117c18f95db1ed672f6d0a8c4ff5c003d3fb6d4a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: gluster: Return UNKNOWN status for GlusterTaskStatus
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: gluster: Return UNKNOWN status for GlusterTaskStatus
......................................................................
gluster: Return UNKNOWN status for GlusterTaskStatus
If the string value passed to GlusterTaskStatus is not
one of the enum options return UNKNOWN as the option
value.
Fixes 2 issues reported by coverity scan when converting
vdsm return value
GlusterAsyncTaskStatus.from((String)map.get(STATUS)).getJobExecutionStatus()
-- possible NPE
Change-Id: If8cd725af21639827ba19c5589fe2889e1c98c19
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/gluster/GlusterAsyncTaskStatus.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Kanagaraj M: Looks good to me, approved
Sahina Bose: Verified
--
To view, visit http://gerrit.ovirt.org/19308
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If8cd725af21639827ba19c5589fe2889e1c98c19
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[ovirt-engine-3.3]: engine: Disable Gluster Swift services feature
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: engine: Disable Gluster Swift services feature
......................................................................
engine: Disable Gluster Swift services feature
Disabling the Gluster services management feature
as the services are currently managed per server
and this is not needed for managing Gluster for
Swift services
This feature is going to change in the next release
and so disabling to avoid confusion
Change-Id: Icc5b5795a13b3d3c1e9b574c445e63a844669d5b
Bug-Url: https://bugzilla.redhat.com/1006708
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterFeaturesUtil.java
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19496
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc5b5795a13b3d3c1e9b574c445e63a844669d5b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[ovirt-engine-3.3]: engine: Do not fail on upgrade from 3.2 to 3.3
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: engine: Do not fail on upgrade from 3.2 to 3.3
......................................................................
engine: Do not fail on upgrade from 3.2 to 3.3
In case there are more than one VM or template configured
for port mirroring, the inner stored procedure used to
fail. The patch modifies the STP to support network with
several VMs or Templates using port mirroring.
Change-Id: I1b995dcde32ddf99b841bbddb19edf67d7061731
Bug-Url: https://bugzilla.redhat.com/1013341
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M packaging/dbscripts/upgrade/03_03_0710_add_profile_to_network_interface.sql
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Mike Kolesnik: Looks good to me, approved
Eli Mesika: Looks good to me, approved
Moti Asayag: Verified
--
To view, visit http://gerrit.ovirt.org/19656
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1b995dcde32ddf99b841bbddb19edf67d7061731
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months