Change in ovirt-engine[master]: engine: Removes unused image groups after snapshot removal
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: engine: Removes unused image groups after snapshot removal
......................................................................
engine: Removes unused image groups after snapshot removal
Currently snapshot removal process keeps leftovers in the storage
domain. For example let's take the following scenario:
1 VM with 1 Disk
Now we creating the first snapshot
Add another disk to VM
Now let's go back preview and commit the first snapshot
At this point second disk is non reachable and not used any more, but
its left on the storage domain.
This patch initializes removal of these leftovers.
Change-Id: I07928bc8ff4225055586b96e47d3787d741a95b4
Bug-Url: https://bugzilla.redhat.com/987994
Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java
1 file changed, 31 insertions(+), 0 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18647
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I07928bc8ff4225055586b96e47d3787d741a95b4
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 3 months
Change in ovirt-engine-sdk-java[master]: sdk: session_timeout parameter doesnt exists in API construc...
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: session_timeout parameter doesnt exists in API constructor #1007231
......................................................................
sdk: session_timeout parameter doesnt exists in API constructor #1007231
Change-Id: I7c0f950d4177fcf707379d8c2726b39c28de0493
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1007231
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
---
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/ApiTemplate
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/Api.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/ConnectionsPool.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/ConnectionsPoolBuilder.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/HttpProxy.java
5 files changed, 251 insertions(+), 76 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19257
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7c0f950d4177fcf707379d8c2726b39c28de0493
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: core: Use StoragePoolValidator
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Use StoragePoolValidator
......................................................................
core: Use StoragePoolValidator
Moved validations on UP status to use the validator.
Change-Id: Ib178d9a6397552953becabb4e3f6a0b3133bbabf
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageDomainCommand.java
3 files changed, 7 insertions(+), 10 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19178
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib178d9a6397552953becabb4e3f6a0b3133bbabf
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 3 months
Change in ovirt-engine[master]: webadmin: Update Tx/Rx in Host Interfaces subtab
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Update Tx/Rx in Host Interfaces subtab
......................................................................
webadmin: Update Tx/Rx in Host Interfaces subtab
Was formerly disabled due to exceptions being thrown; at the moment
the values seem to be updated well and without causing any trouble.
Change-Id: I68e37c6c37480eca3512c84b06690a18aabea2eb
Bug-Url: https://bugzilla.redhat.com/746458
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19235
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I68e37c6c37480eca3512c84b06690a18aabea2eb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 3 months
Change in ovirt-dwh[master]: history: added missing user login column to 3.3 views
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: history: added missing user login column to 3.3 views
......................................................................
history: added missing user login column to 3.3 views
Change-Id: I4d2fe12931a584bedbf7f82b02712b135da4f8a3
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
---
M data-warehouse/historydbscripts_postgres/create_views_3_3.sql
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19251
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4d2fe12931a584bedbf7f82b02712b135da4f8a3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[ovirt-engine-3.3]: restapi: invalidate session only when it expires
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: invalidate session only when it expires
......................................................................
restapi: invalidate session only when it expires
Change-Id: Ib85c38dea961b252853bcae48912aa40a4ff7e77
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
---
M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/Challenger.java
1 file changed, 6 insertions(+), 4 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19249
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib85c38dea961b252853bcae48912aa40a4ff7e77
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: API: editing host add and update fields - exposing all store...
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: API: editing host add and update fields - exposing all stored ssh fields
......................................................................
API: editing host add and update fields - exposing all stored ssh fields
Change-Id: I640cfca4057ffd65d37afc10bc5ac2e12f1aafd5
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=999640
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18754
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I640cfca4057ffd65d37afc10bc5ac2e12f1aafd5
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 3 months
Change in ovirt-engine[ovirt-engine-3.3.0]: restapi: invalidate session only when it expires
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: invalidate session only when it expires
......................................................................
restapi: invalidate session only when it expires
Change-Id: Ib85c38dea961b252853bcae48912aa40a4ff7e77
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
---
M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/Challenger.java
1 file changed, 6 insertions(+), 4 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19245
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib85c38dea961b252853bcae48912aa40a4ff7e77
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3.0
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: restapi: invalidate session only when it expires
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: invalidate session only when it expires
......................................................................
restapi: invalidate session only when it expires
Change-Id: Ib85c38dea961b252853bcae48912aa40a4ff7e77
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
---
M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/Challenger.java
1 file changed, 6 insertions(+), 4 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19244
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib85c38dea961b252853bcae48912aa40a4ff7e77
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 3 months
Change in ovirt-engine[master]: restapi : Update of power management via cli ignored(#959879)
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi : Update of power management via cli ignored(#959879)
......................................................................
restapi : Update of power management via cli ignored(#959879)
Unable update power management fields via cli, but the
same works from web admin portal
This patch fixes all fields common between agents and the
power management model
Change-Id: Ifece398fd70a5928665c6f0c96a80450a6866f59
Bug-Url: https://bugzilla.redhat.com/959879
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java
1 file changed, 76 insertions(+), 24 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19023
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifece398fd70a5928665c6f0c96a80450a6866f59
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 3 months