Change in ovirt-engine[master]: engine: Network interface name is mandatory
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Network interface name is mandatory
......................................................................
engine: Network interface name is mandatory
The network interface name is used to identify the nic,
therefore it cannot be omitted. The patch adds a NotNull
constraint for the interface name.
Change-Id: I26f33bf12e9b53c3e31719b93a689e11e974acca
Bug-Url: https://bugzilla.redhat.com/979751
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksParametersTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java
2 files changed, 3 insertions(+), 0 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19056
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I26f33bf12e9b53c3e31719b93a689e11e974acca
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 3 months
Change in ovirt-hosted-engine-setup[master]: packaging: setup: correctly parse stroage domain info
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: correctly parse stroage domain info
......................................................................
packaging: setup: correctly parse stroage domain info
previously the getStorageDomainInfo parser assumed that
remotePath was always defined in the dictionary returned
by the call to getStorageDomainInfo.
The key is not defined for iSCSI domains so now the
parser check for remotePath availability before
trying to use its value.
Change-Id: I7e8db0f31dadd7072680fb1564514be065ea5431
Bug-Url: https://bugzilla.redhat.com/1005767
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/storage/storage.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19115
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e8db0f31dadd7072680fb1564514be065ea5431
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Leonid Natapov <leonidnatapov(a)gmail.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 3 months
Change in ovirt-engine[master]: core: rename TemplateUser role
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: rename TemplateUser role
......................................................................
core: rename TemplateUser role
Renaming UserTemplate role to UserTemplateBaseVm
This was committed by mistake from commit :9cf86bf core: squash
03_00_0150_update_roles.sql
Change-Id: I06b67f49f4995f43b886494f6567e1a7cef29ae7
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1007280
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
A packaging/dbscripts/upgrade/03_03_0850_rename_template_user_role.sql
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18779
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I06b67f49f4995f43b886494f6567e1a7cef29ae7
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 3 months
Change in ovirt-hosted-engine-setup[master]: ux: describe better how to reboot VM
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ux: describe better how to reboot VM
......................................................................
ux: describe better how to reboot VM
Describe better how to reboot the VM during
setup.
Change-Id: Id63867e1f43dec3b2ef0c4a179f21ba1ac5876d1
Bug-Url: https://bugzilla.redhat.com/1001726
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/vm/runvm.py
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18909
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id63867e1f43dec3b2ef0c4a179f21ba1ac5876d1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Leonid Natapov <leonidnatapov(a)gmail.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 3 months
Change in ovirt-engine-cli[master]: cli: Update power management agent type via CLI failed
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: Update power management agent type via CLI failed
......................................................................
cli: Update power management agent type via CLI failed
Updating power management agent type fails from cli
Change-Id: I6211c636ee35a6b46723c747a67c77ea2176e808
Bug-Url: https://bugzilla.redhat.com/1005751
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M src/ovirtcli/command/command.py
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
Michael Pasternak: Looks good to me, approved
Ravi Nori: Verified
--
To view, visit http://gerrit.ovirt.org/19104
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6211c636ee35a6b46723c747a67c77ea2176e808
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: core: PM options for secondary agent are not saved
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: PM options for secondary agent are not saved
......................................................................
core: PM options for secondary agent are not saved
Adding needed code to save the secondary PM options in VDS and VdsStatic
code.
Change-Id: Ic4ff49f7991d06140a8d7d01778b7731b0458736
Changoe-Id: I8df59ff12faa5a710905b6b2188d5cab446d0c85
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1001572
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java
2 files changed, 2 insertions(+), 0 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19119
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic4ff49f7991d06140a8d7d01778b7731b0458736
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 3 months
Change in ovirt-engine[engine_3.2]: core: Avoid XSS in RedirectServlet
by oschreib@redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: core: Avoid XSS in RedirectServlet
......................................................................
core: Avoid XSS in RedirectServlet
Currently the RedirectServlet composes JavaScript code to show error
messages using text provided by the user in a request parameter. This
text isn't sanitized and thus can be used by maliciuous users to execute
arbitrary JavaScript code. To avoid this situation this patch changes
the servlet so that it doesn't receive any parameter, thus the problem
is completely avoided.
Change-Id: Ie77e6a063e1522b2e108076a240939ca1dae272e
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/root/src/main/webapp/index.html
D frontend/wars/rmw-war/src/main/java/org/ovirt/engine/core/redirect/RedirectServlet.java
A frontend/wars/rmw-war/src/main/java/org/ovirt/engine/core/redirect/ReportsRedirectServlet.java
M frontend/wars/rmw-war/src/main/webapp/WEB-INF/web.xml
4 files changed, 47 insertions(+), 115 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, but someone else must approve
Alexander Wels: Verified
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19153
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie77e6a063e1522b2e108076a240939ca1dae272e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: engine_3.2
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[ovirt-engine-3.3.0]: core: Avoid XSS in RedirectServlet
by oschreib@redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: core: Avoid XSS in RedirectServlet
......................................................................
core: Avoid XSS in RedirectServlet
Currently the RedirectServlet composes JavaScript code to show error
messages using text provided by the user in a request parameter. This
text isn't sanitized and thus can be used by maliciuous users to execute
arbitrary JavaScript code. To avoid this situation this patch changes
the servlet so that it doesn't receive any parameter, thus the problem
is completely avoided.
Signed-off-by: Alexander Wels <awels(a)redhat.com>
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
Change-Id: Ie77e6a063e1522b2e108076a240939ca1dae272e
---
D backend/manager/modules/root/src/main/java/org/ovirt/engine/core/redirect/RedirectServlet.java
A backend/manager/modules/root/src/main/java/org/ovirt/engine/core/redirect/ReportsRedirectServlet.java
M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml
M packaging/branding/ovirt.brand/welcome_page.template
4 files changed, 48 insertions(+), 112 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, but someone else must approve
Alexander Wels: Verified
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19156
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie77e6a063e1522b2e108076a240939ca1dae272e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3.0
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: core: Disallow force select SPM when Data Center is not up
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Disallow force select SPM when Data Center is not up
......................................................................
core: Disallow force select SPM when Data Center is not up
Change-Id: I9f59f891d392fbc7c80cc21df3672d328221c007
Bug-Url: https://bugzilla.redhat.com/987875
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ForceSelectSPMCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ForceSelectSPMCommandTest.java
2 files changed, 14 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19123
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9f59f891d392fbc7c80cc21df3672d328221c007
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 3 months
Change in ovirt-engine[ovirt-engine-3.3]: core: Avoid XSS in RedirectServlet
by oschreib@redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: core: Avoid XSS in RedirectServlet
......................................................................
core: Avoid XSS in RedirectServlet
Currently the RedirectServlet composes JavaScript code to show error
messages using text provided by the user in a request parameter. This
text isn't sanitized and thus can be used by maliciuous users to execute
arbitrary JavaScript code. To avoid this situation this patch changes
the servlet so that it doesn't receive any parameter, thus the problem
is completely avoided.
Signed-off-by: Alexander Wels <awels(a)redhat.com>
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
Change-Id: Ie77e6a063e1522b2e108076a240939ca1dae272e
---
D backend/manager/modules/root/src/main/java/org/ovirt/engine/core/redirect/RedirectServlet.java
A backend/manager/modules/root/src/main/java/org/ovirt/engine/core/redirect/ReportsRedirectServlet.java
M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml
M packaging/branding/ovirt.brand/welcome_page.template
4 files changed, 48 insertions(+), 112 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, but someone else must approve
Alexander Wels: Verified
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19155
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie77e6a063e1522b2e108076a240939ca1dae272e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
11 years, 3 months