January 2014 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: packaging: spec: pull -setup package as our procedures inclu...

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: packaging: spec: pull -setup package as our procedures includes upgrade it ...................................................................... packaging: spec: pull -setup package as our procedures includes upgrade it must follow the legacy of: yum install ovirt-engine yum update ovirt-engine-setup Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1058013 Change-Id: I5f384108bb0446d85b1f1efb4bfb2ea9d7be2bd6 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23744 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f384108bb0446d85b1f1efb4bfb2ea9d7be2bd6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 11 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: core: fix virtio-scsi validation on update VM

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: core: fix virtio-scsi validation on update VM ...................................................................... core: fix virtio-scsi validation on update VM Fix VirtIO-SCSI validation when updating a running VM: * Added a new signature for vmDeviceChanged method which gets also a specific VmDeviceType. ** Needed for using getVmDeviceByVmIdTypeAndDevice method from VmDeviceDao. I.e. instead of fetching all devices of VmDeviceGeneralType.CONTROLLER, filter also by VmDeviceType.VIRTIOSCSI specifically. * Added new test-cases for updating a running VM. Change-Id: I6f2247319b014f59d5c19c0054ee9e63d1dfe204 Bug-Url: https://bugzilla.redhat.com/1058295 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java 2 files changed, 64 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23719 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f2247319b014f59d5c19c0054ee9e63d1dfe204 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 11 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: services: extend important limits to their hard l...

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: packaging: services: extend important limits to their hard limit ...................................................................... packaging: services: extend important limits to their hard limit Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1057654 Change-Id: Ib9f89a1519cf895e0e1504b3e344c9d0fc1481d6 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/pythonlib/ovirt_engine/service.py 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23743 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9f89a1519cf895e0e1504b3e344c9d0fc1481d6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 11 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: setup: restart apache if ssl config changed

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: restart apache if ssl config changed ...................................................................... packaging: setup: restart apache if ssl config changed we restart it anyway as we overwrite the proxy configuration, but for consistency this should be added. Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1058013 Change-Id: I5aabb084ce5fd9629bfe8a2c086760a6568e6308 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/apache/ssl.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23742 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5aabb084ce5fd9629bfe8a2c086760a6568e6308 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 11 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: setup: database: support create language

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: database: support create language ...................................................................... packaging: setup: database: support create language Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1058013 Change-Id: Ia28c1d3498fba4f5417be82820171ae1018c7520 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/database.py 1 file changed, 34 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified Itamar Heim: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia28c1d3498fba4f5417be82820171ae1018c7520 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 11 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: setup: disable osinfo upgrade in devenv

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: disable osinfo upgrade in devenv ...................................................................... packaging: setup: disable osinfo upgrade in devenv paths within database are absolute, we should not touch these in devenv. Change-Id: I0a64d80c42bf52185600d8557802d9fc0dd405dd Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/legacy/osinfo.py 1 file changed, 8 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a64d80c42bf52185600d8557802d9fc0dd405dd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 11 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: core: Allow to fence host manually in reboot state

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: core: Allow to fence host manually in reboot state ...................................................................... core: Allow to fence host manually in reboot state In the event of a full host power outage (including fence devices) we are waiting for the network attempts to reconnect while the Host is in "Connecting" state in which manual fence is forbidden since this is considered as a INTERMITTENT state. After that, the Host non-responding treatment is taking place and trying to manually fence the Host during the fencing retries will fail since manual fence calls ClearNonResponsiveVdsVmsCommand which currently allows only Hosts that are non-responding to execute this command. That means that VMs can be freed only after the network reconnect attempts plus all fencing handling took place which is quite a long time (19 min according to the BZ description) The fencing flow moves the Host to "Reboot" state at the time the Restart command is issued. This patch modifies the ClearNonResponsiveVdsVmsCommand canDoAction method to allow execution of this command while Host is in "Reboot" state in order to shorten the above time (in the flow described in the BZ this patch allows freeing the VMs at 2013-12-13 12:40:33 instead of at 12-13 12:52:39 which will save us more than 12 min) Since when the Host is manually fenced the user approves that the Host was rebooted we have no problem to allow the user freeing the VMs earlier if he knows the real state. Change-Id: I4f5f45ca122d841cc411cc6d9541d0903aeb955a Bug-Url : https://bugzilla.redhat.com/show_bug.cgi?id=1052082 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClearNonResponsiveVdsVmsCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23186 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f5f45ca122d841cc411cc6d9541d0903aeb955a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 11 months

1
0
0 / 0

Change in ovirt-engine[master]: core: fix possible NPE on migration failure

by ofrenkel＠redhat.com

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix possible NPE on migration failure ...................................................................... core: fix possible NPE on migration failure We recently added a call to decrease pending memory from the destination VDS when migration ends. This code was added to the MigrateVmCommand#reportCompleted method and we assume that the destination VDS is not null when we reach that method, but in some cases where the migration fails we might reach the reportCompleted method after the destination VDS is set to null (see MigrateVmCommand#rerun). This patch solves this issue by adding null-check which ensures that the destination VDS is valid before calling to decrease its pending memory. Change-Id: If5c975ba5a0824c80be36cb997b3b040b5191192 Bug-Url: https://bugzilla.redhat.com/1048790 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/23705 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5c975ba5a0824c80be36cb997b3b040b5191192 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 11 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Cancel button to not do anything

by lvernia＠redhat.com

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Cancel button to not do anything ...................................................................... webadmin: Cancel button to not do anything Previously it acted pretty much as if OK was pressed. Change-Id: I25a872b301d6ea8a050355a4f828580eea062101 Bug-Url: https://bugzilla.redhat.com/1058017 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java 1 file changed, 12 insertions(+), 4 deletions(-) Approvals: Gilad Chaplik: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/23750 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25a872b301d6ea8a050355a4f828580eea062101 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 11 months

1
0
0 / 0

Change in ovirt-engine[master]: dbscripts: fix password field length

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: dbscripts: fix password field length ...................................................................... dbscripts: fix password field length the password column in the 'storage_server_connections' table has a different type with respect to the corresponding parameter of the Insertstorage_server_connection function. This trigger SQL exception doing the following: - configure an ISCSI data domain (bug triggered on the first one, but it should behave the same with the others too). - in the 'New domain' window, issue fill all the fields, most notably username and password, and do a manual discovery. - try to add the target which shows up as result of the discovery. This patch fixes this problem by enlarging the password field on the table, in order to let it hold the encrypted password. Bug-Url: https://bugzilla.redhat.com/1052839 Change-Id: Ibe5dcb58dd445216b43bbce63b342b96d5e225e6 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M packaging/dbscripts/storages_san_sp.sql A packaging/dbscripts/upgrade/03_04_0590_change_storage_server_connections_password_length.sql 2 files changed, 7 insertions(+), 1 deletion(-) Approvals: Francesco Romani: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23133 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe5dcb58dd445216b43bbce63b342b96d5e225e6 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Liran Zelkha <liran.zelkha(a)gmail.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 11 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits January 2014