Change in ovirt-engine[master]: packaging: services: ovirt-engine: cleanup database default ...
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: services: ovirt-engine: cleanup database default config
......................................................................
packaging: services: ovirt-engine: cleanup database default config
Change-Id: I029fe2b7535f988a82290ab51a7a66752d1a1a51
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/services/ovirt-engine/ovirt-engine.conf.in
1 file changed, 9 insertions(+), 6 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22834
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I029fe2b7535f988a82290ab51a7a66752d1a1a51
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 11 months
Change in ovirt-engine[master]: packaging: setup: do not attempt to get websocket proxy stat...
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: do not attempt to get websocket proxy status in devenv
......................................................................
packaging: setup: do not attempt to get websocket proxy status in devenv
Change-Id: I0454e3f136ad1181bc01c55411b33b1e2fc20e4c
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/config.py
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22864
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0454e3f136ad1181bc01c55411b33b1e2fc20e4c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 11 months
Change in ovirt-engine-cli[master]: cli: Accept intermixed arguments and options
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: cli: Accept intermixed arguments and options
......................................................................
cli: Accept intermixed arguments and options
Currently the syntax of a command requires all the arguments to appear
before all the options. This complicates things when the value of an
option is required by the autocompletion mechanism in order to decide
which are the acceptable arguments. This patch changes the parsing rules
so that arguments and options can be freely intermixed.
Change-Id: I8c1f6982e7beddb17a4668f5719294a8aaae3c2e
Bug-Url: https://bugzilla.redhat.com/1047513
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M src/cli/context.py
M src/cli/parser.py
2 files changed, 35 insertions(+), 31 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22866
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c1f6982e7beddb17a4668f5719294a8aaae3c2e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
10 years, 11 months
Change in ovirt-engine-cli[master]: Revert "cli: mismatch between restore snapshot syntax and au...
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Revert "cli: mismatch between restore snapshot syntax and auto completion #1027298"
......................................................................
Revert "cli: mismatch between restore snapshot syntax and auto completion #1027298"
This reverts commit 870b0c as it introduces a regression: moving the
options to the end of the command moves them past the redirections and
pipes, and this causes a syntax error. This is the bug that the change
intended to fix:
https://bugzilla.redhat.com/1047513
A later patch introduces changes in the syntax of commands allowing
mixing arguments and options. That fixes the above bug as well as the
regression.
Change-Id: I7b85120e6479c4be3dd2357ef8731cd1388b8885
Bug-Url: https://bugzilla.redhat.com/1047513
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M src/ovirtcli/infrastructure/historymanager.py
M src/ovirtcli/shell/actioncmdshell.py
M src/ovirtcli/shell/engineshell.py
3 files changed, 4 insertions(+), 86 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22865
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7b85120e6479c4be3dd2357ef8731cd1388b8885
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
10 years, 11 months
Change in ovirt-engine[master]: core: Fix coverity warnings
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: Fix coverity warnings
......................................................................
core: Fix coverity warnings
Fixed the following:
1. Inner class should be static
2. The labels field was never accessed
Change-Id: I656ff0e494ed90403a1abe0fb8de8b241e5ffb04
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/NetworkLabelFormatValidatorTest.java
1 file changed, 8 insertions(+), 4 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22883
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I656ff0e494ed90403a1abe0fb8de8b241e5ffb04
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
10 years, 11 months
Change in ovirt-engine[master]: core: SKIPPED_CLASS_TOO_BIG in ApplicatioConstants
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: SKIPPED_CLASS_TOO_BIG in ApplicatioConstants
......................................................................
core: SKIPPED_CLASS_TOO_BIG in ApplicatioConstants
Re-added the exclusion of SKIPPED_CLASS_TOO_BIG on
org.ovirt.engine.ui.webadmin.ApplicationConstants which was mistakenly
removed by efd0d3ba39b6061d67626966eda983637c205f9e.
Change-Id: I47904dbd3add87f90e23d06b91161014fc322421
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/exclude-filters.xml
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Allon Mureinik: Verified
Alissa Bonas: Looks good to me, but someone else must approve
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22881
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I47904dbd3add87f90e23d06b91161014fc322421
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
10 years, 11 months
Change in ovirt-engine[master]: webadmin: Ignore FindBugs unconfirmed cast warning
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: webadmin: Ignore FindBugs unconfirmed cast warning
......................................................................
webadmin: Ignore FindBugs unconfirmed cast warning
Ignore all the unconfirmed casts in the gwt-common, uicommonweb and
webadmin modules.
Unfortunately, these warnings are currently inherit to the design,
and handling them on an individual basis just adds noise to the
process.
Change-Id: I142db2592a9fe7b38a6751bcc362546ef46cc857
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/exclude-filters.xml
M frontend/webadmin/modules/uicommonweb/exclude-filters.xml
M frontend/webadmin/modules/webadmin/exclude-filters.xml
3 files changed, 23 insertions(+), 371 deletions(-)
Approvals:
Allon Mureinik: Verified
Alissa Bonas: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22879
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I142db2592a9fe7b38a6751bcc362546ef46cc857
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
10 years, 11 months