Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: bin: instruct answer file at --config-appe...
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: packaging: setup: bin: instruct answer file at --config-append usage
......................................................................
packaging: setup: bin: instruct answer file at --config-append usage
Change-Id: I715a4d3f2037a147a0442e81b73029807651483b
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/setup/bin/ovirt-engine-remove
M packaging/setup/bin/ovirt-engine-rename
M packaging/setup/bin/ovirt-engine-setup
3 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23945
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I715a4d3f2037a147a0442e81b73029807651483b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: tools: Adds more validations to MAIL_PORT in notifier
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: tools: Adds more validations to MAIL_PORT in notifier
......................................................................
tools: Adds more validations to MAIL_PORT in notifier
Adds more validations to MAIL_PORT option in notifier's configuration.
MAIL_PORT has to be an integer from 1 to 65535 inclusively.
Change-Id: I770d1636dc25c0c9b0076a92dcac20ddec551acf
Bug-Url: https://bugzilla.redhat.com/1051061
Bug-Url: https://bugzilla.redhat.com/1051048
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java
1 file changed, 15 insertions(+), 0 deletions(-)
Approvals:
Martin Peřina: Verified
Eli Mesika: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23504
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I770d1636dc25c0c9b0076a92dcac20ddec551acf
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: packaging: spec: move branding.jar to javalib
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: packaging: spec: move branding.jar to javalib
......................................................................
packaging: spec: move branding.jar to javalib
this will enable reuse by other packages, branding especially.
Change-Id: Ie44e9483eb39d4c0fa9a398adbb050bc33ddeee4
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M ovirt-engine.spec.in
1 file changed, 11 insertions(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23917
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie44e9483eb39d4c0fa9a398adbb050bc33ddeee4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: restapi: Validate unsigned short integers correctly
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Validate unsigned short integers correctly
......................................................................
restapi: Validate unsigned short integers correctly
Recently, in commit 14e9da, we introduced a validation of integer values
provided to the RESTAPI in order to avoid overflows of Java integer
types. This validation doesn't work correctly for unsigned short
integers, as it compares them to the maximum signed short integer. This
has the side effect of rejecting requests that include port numbers
greater than 32767. A notable example is the VDSM port number 54321.
This patch changes the validation so that it will validate unsigned
short integers correctly, comparing them to 65535.
Change-Id: I49e64d5f55c32463950e648aa1cd8c3084017da6
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/IntegerParser.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
2 files changed, 54 insertions(+), 18 deletions(-)
Approvals:
Ravi Nori: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23934
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I49e64d5f55c32463950e648aa1cd8c3084017da6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-live[ovirt-live_3.3]: ovirt-live : update answer file for 3.3.3
by obasan@redhat.com
Ohad Basan has submitted this change and it was merged.
Change subject: ovirt-live : update answer file for 3.3.3
......................................................................
ovirt-live : update answer file for 3.3.3
Change-Id: I0627dc854babf316b2016c6d04f558914a529d65
Signed-off-by: Ohad Basan <obasan(a)redhat.com>
---
M centos/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/ovirt-answer
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Ohad Basan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23937
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0627dc854babf316b2016c6d04f558914a529d65
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: ovirt-live_3.3
Gerrit-Owner: Ohad Basan <obasan(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>
10 years, 8 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: Allow user to reboot VM from within the installer
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Allow user to reboot VM from within the installer
......................................................................
Allow user to reboot VM from within the installer
During setup, the engine VM is created twice: once to install the base
operating system and once to install the engine. During either of these
phases it may sometimes be necessary to reboot the VM additional times
(ie. to correct PXE boot configuration or restart the installer).
Provide an interactive means of rebooting the VM without forcing the
user to resort to external invocations of hosted-engine --vm-start, etc.
Signed-off-by: Adam Litke <alitke(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1055497
Change-Id: I176eb58b6b5400df7f98a4fa3e4ae55c2959fb93
---
M src/ovirt_hosted_engine_setup/mixins.py
M src/plugins/ovirt-hosted-engine-setup/engine/health.py
M src/plugins/ovirt-hosted-engine-setup/vm/runvm.py
3 files changed, 71 insertions(+), 79 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Adam Litke: Verified
--
To view, visit http://gerrit.ovirt.org/23927
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I176eb58b6b5400df7f98a4fa3e4ae55c2959fb93
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.0
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: Move VM operations into a mixin for reusability
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Move VM operations into a mixin for reusability
......................................................................
Move VM operations into a mixin for reusability
The plugin in runvm.py has lots of useful logic for manipulating the
hosted engine VM. This logic can be very useful to other plugins (eg.
health.py) that may want to offer the user assistance with managing the
VM. This patch moves the VM logic into a separate class that can be
mixed in with any other plugin which may want the functionality.
Signed-off-by: Adam Litke <alitke(a)redhat.com>
Related-To: https://bugzilla.redhat.com/1055497
Change-Id: I811f6712cb5c9324c6a3acca0bfc5bc9195b25ef
---
M src/ovirt_hosted_engine_setup/Makefile.am
A src/ovirt_hosted_engine_setup/mixins.py
M src/plugins/ovirt-hosted-engine-setup/vm/runvm.py
3 files changed, 218 insertions(+), 185 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Adam Litke: Verified
--
To view, visit http://gerrit.ovirt.org/23926
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I811f6712cb5c9324c6a3acca0bfc5bc9195b25ef
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.0
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: tools: Removes debug info to stdout when editing domain
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: tools: Removes debug info to stdout when editing domain
......................................................................
tools: Removes debug info to stdout when editing domain
Removes debug info printed to stdout when editing domain. It was added
by mistake in commit 22b5e93b4442ab1e63319c34f414762a7a027a06
Change-Id: Ib4d50cae72bbb51a473a54338ea0e902721acf86
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
0 files changed, 0 insertions(+), 0 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23656
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4d50cae72bbb51a473a54338ea0e902721acf86
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: Adding SP to update management network name
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: Adding SP to update management network name
......................................................................
Adding SP to update management network name
Adding a new SP RenameManagementNetwork(v_name varchar(50) that updates
the management network name in both vdc_options & network tables.
Change-Id: I29b73e8fa1986610c931abdd2fea5b3536a3037d
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1059430
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M packaging/dbscripts/network_sp.sql
1 file changed, 14 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23928
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I29b73e8fa1986610c931abdd2fea5b3536a3037d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: utils: pki resources: return engine alias based on ConfigValues
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: utils: pki resources: return engine alias based on ConfigValues
......................................................................
utils: pki resources: return engine alias based on ConfigValues
Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=961677
Change-Id: Ie87ece2025245c9afdb6fbe084c04f4bfac468b9
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/PKIResources.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23931
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie87ece2025245c9afdb6fbe084c04f4bfac468b9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months