Change in ovirt-engine[master]: webadmin: Allow editing host network when part of label
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Allow editing host network when part of label
......................................................................
webadmin: Allow editing host network when part of label
Previously the edit button was invisible, now it is shown. Note that
when a network is unmanaged, the "action button" in that case would
remove the network from the interface, which would then "break" the
label, therefore it is not displayed.
Change-Id: I933eb0900f5a1663a5ae4f52eb05208e6db2c868
Bug-Url: https://bugzilla.redhat.com/1055952
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Daniel Erez: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/23508
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I933eb0900f5a1663a5ae4f52eb05208e6db2c868
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
10 years, 11 months
Change in ovirt-engine[master]: Removing initialized keyword from cluster search
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: Removing initialized keyword from cluster search
......................................................................
Removing initialized keyword from cluster search
The "initialized" keyword for Cluster search is no longer supported and
therefor was removed from the available search keywords for Cluster.
Change-Id: Ic3b1e7898ac488571162eeea24f1d45509099d9f
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1048735
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/ClusterConditionFieldAutoCompleter.java
1 file changed, 1 insertion(+), 6 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
Ravi Nori: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/23041
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic3b1e7898ac488571162eeea24f1d45509099d9f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 11 months
Change in ovirt-engine[master]: [RFE] Maintenance mode shall persist after reboot
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: [RFE] Maintenance mode shall persist after reboot
......................................................................
[RFE] Maintenance mode shall persist after reboot
Fencing operations can occur as a result of manual operation or
automatically after Host was in non-responsive state and has been
restarted after waiting the grace-time for it to reconnect.
In the case that Host was in Maintenance
1) If it was manually started , it should stay in maintenance
2) If it was manually restarted it should change first to reboot and move back to
Maintenance when the Host is ON again.
In the case that Host is restarted from the non-responsive treatment, it
should go to reboot -> non responding -> up as before
This patch address 1) and 2) above by
1) Setting the parent command in VdsNotRespondingTreatmentComman
parameters so the Restart command can distinguish between manual Restart and
automatic restart
2) Add a flag to FenceVdsActionParameters to mark if Host should be
moved again to Maintenance after it was restarted
3) Use The Host last status to skip changing the status in case of 1)
4) Use the flag described in 2) to set Host again to Maintenance in
case that Host was manually rebooted while in the Maintenance status.
Change-Id: I3dcb06b18c4af13876d1fb3043fb5b6cc5c6a74a
https://bugzilla.redhat.com/show_bug.cgi?id=917039
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StartVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/FenceVdsActionParameters.java
5 files changed, 24 insertions(+), 3 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23428
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3dcb06b18c4af13876d1fb3043fb5b6cc5c6a74a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 11 months
Change in ovirt-engine[master]: Set default proxy preferences for existing Hosts
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: Set default proxy preferences for existing Hosts
......................................................................
Set default proxy preferences for existing Hosts
Currently when upgrading from 3.1 to 3.2 the pm_proxy_preferences value
in vds_static remains empty for installed Hosts.
Only new Hosts will get pm_proxy_preferences = 'cluster,dc' and this
will appear in the Host Edit popup in the Source field when the user can
change the sort of those values.
Actually, installed Hosts will still use the 'cluster,dc' value under
the hoods since this is the default when the Host has no value for
pm_proxy_preferences field.
This patch updates all Hosts that have empty pm_proxy_preferences to set
the pm_proxy_preferences value to 'cluster,dc' such that editing an
installed Host will show those values in the Edit popup Source field.
Change-Id: Ibe41451cf140c17f036e5c1ac95b3402460e7725
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1048356
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
A packaging/dbscripts/upgrade/03_04_0510_set_proxy_preferences_default.sql
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23430
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe41451cf140c17f036e5c1ac95b3402460e7725
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 11 months
Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Hide content widget of boot protocol label
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Hide content widget of boot protocol label
......................................................................
webadmin: Hide content widget of boot protocol label
Took a lot of space when visible, and when the label grew longer in
foreign languages, this would cause other widgets in the dialog to
rearrange.
Change-Id: I9c2de4ba2ad14235e8e59f13c5ccdf9b106a257c
Bug-Url: https://bugzilla.redhat.com/1051524
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Gilad Chaplik: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/23506
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9c2de4ba2ad14235e8e59f13c5ccdf9b106a257c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 11 months
Change in ovirt-release[master]: dropping dist suffix
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: dropping dist suffix
......................................................................
dropping dist suffix
Change-Id: If8443a2336b2267feae11cddcbbd5e9e9ea2a1a0
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M ovirt-release.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Kiril Nesenko: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/23549
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If8443a2336b2267feae11cddcbbd5e9e9ea2a1a0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
10 years, 11 months
Change in ovirt-release[master]: adding 3.4.0_pre to repo files
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: adding 3.4.0_pre to repo files
......................................................................
adding 3.4.0_pre to repo files
bumping version to 10.0.1
Change-Id: Ib5dc2e13149aa2f670e800d03c8954b583e70755
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M configure.ac
M el6-ovirt.repo
M fedora-ovirt.repo
M ovirt-release.spec.in
4 files changed, 19 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Kiril Nesenko: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/23548
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5dc2e13149aa2f670e800d03c8954b583e70755
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
10 years, 11 months
Change in ovirt-release[master]: packaging: build: rewrite
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: build: rewrite
......................................................................
packaging: build: rewrite
* Changed the versions style to be same
as other oVirt packages
* Changed the license to ASL 2.0
Change-Id: I6b8dad0614300948cdc6fcc3ad2766ddff0caff1
Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com>
---
A AUTHORS
R COPYING
M Makefile.am
M autogen.sh
M configure.ac
M ovirt-release.spec.in
6 files changed, 108 insertions(+), 126 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23523
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b8dad0614300948cdc6fcc3ad2766ddff0caff1
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
10 years, 11 months
Change in ovirt-engine[master]: frontend: exclude class is too big error for AppErrors
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: exclude class is too big error for AppErrors
......................................................................
frontend: exclude class is too big error for AppErrors
Findbugs complains that AppErrors class is too big for analysis. We
want this class to contain all the errors, and there are lots of them -
so for now we should ignore that error for this class.
Change-Id: I1e7e2d1f39513112ccf6131db609d39839bdcb8d
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M frontend/webadmin/modules/frontend/exclude-filters.xml
1 file changed, 9 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23547
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1e7e2d1f39513112ccf6131db609d39839bdcb8d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
10 years, 11 months
Change in ovirt-engine[master]: tools: Explicit message for bad minssf
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: tools: Explicit message for bad minssf
......................................................................
tools: Explicit message for bad minssf
Currently when the engine-manage-domains tool tries to connect to an
OpenLDAP server configured with the default minimum security strength
factor (minssf=0) the Kerberos implementation of the virtual machine
generates an exception that is directly printed to the output, without
any friendly explanation, something like this:
java.lang.NegativeArraySizeException
at sun.security.jgss.krb5.CipherHelper.aes256Encrypt(CipherHelper.java:1367)
sun.security.jgss.krb5.CipherHelper.encryptData(CipherHelper.java:722)
...
This patch changes the engine-manage-domains tool so that when this
exception is detected it will print the following message:
Failure while testing domain example.com. Details: An internal
error has ocurred in the Kerberos implementation of the Java virtual
machine. This usually means that the LDAP server is configured with a
minium security strength factor (minssf) of 0. Change it to 1 and try
again.
The way to change the minssf parameter in OpenLDAP is this:
# cat > fixssf.ldif <<'.'
dn: cn=config
replace: olcSaslSecProps
olcSaslSecProps: noanonymous,noplain,minssf=1
-
.
# ldapmodify -H ldapi:/// -Y EXTERNAL -f fixssf.ldif
This OpenLDAP configuration has been tested and works correctly.
The 389 directory server also has this parameter, and can be changed in
the /etc/dirsrv/slapd-YOUR-REALM/dse.ldif file, something like this:
dn: cn=config
nsslapd-minssf: 1
This 389 directory server configuration hasn't been tested.
Change-Id: I2f1abaa8a6dbde146786326d62c185e8414595e1
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/AuthenticationResult.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/JndiAction.java
2 files changed, 12 insertions(+), 4 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Juan Hernandez: Verified
Yedidyah Bar David: Looks good to me, but someone else must approve
Yair Zaslavsky: Looks good to me, approved
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21505
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f1abaa8a6dbde146786326d62c185e8414595e1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 11 months