Change in ovirt-engine[master]: engine: Block sync of network with QoS when not supported
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: engine: Block sync of network with QoS when not supported
......................................................................
engine: Block sync of network with QoS when not supported
When a QoS entity is attached to network, the network is supposed to
appear as out-of-sync on a host, no matter the cluster compatibility
version of the host. However, when the host's cluster doesn't support
Host Network QoS, it shouldn't be possible to then synchronize the
network (which whould also apply QoS to it).
Change-Id: Ie79c6463676b82f1743fb162fc6c660dd88756f8
Bug-Url: https://bugzilla.redhat.com/1054320
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java
2 files changed, 54 insertions(+), 21 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23330
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie79c6463676b82f1743fb162fc6c660dd88756f8
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 11 months
Change in ovirt-engine[master]: core: [Fix] NPE in update vm/template (via rest)
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: [Fix] NPE in update vm/template (via rest)
......................................................................
core: [Fix] NPE in update vm/template (via rest)
Boolean null is casted to boolean.
Change-Id: I1ef9490664a663db1aaf2fa14da239df01d78bab
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa(a)eldorado.org.br>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
2 files changed, 14 insertions(+), 2 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23067
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1ef9490664a663db1aaf2fa14da239df01d78bab
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 11 months
Change in jasperreports-server-rpm[master]: Fix bogus date in %changelog
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: Fix bogus date in %changelog
......................................................................
Fix bogus date in %changelog
Change-Id: Ib52e7fa295f643d8df312a2c351d827c75bb29f4
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jasperreports-server.spec
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23377
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib52e7fa295f643d8df312a2c351d827c75bb29f4
Gerrit-PatchSet: 1
Gerrit-Project: jasperreports-server-rpm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
10 years, 11 months
Change in ovirt-engine[master]: engine: Enable per-VM configuration of migration downtime
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Enable per-VM configuration of migration downtime
......................................................................
engine: Enable per-VM configuration of migration downtime
Added migration_downtime field to vm_static table and
Integer migrationDowntime property to VmBase representing
maximum number of milliseconds for downtime during live migration.
In case this value is null the new ConfigValue
DefaultMaximumMigrationDowntime value is used.
In case either the vm field or the aforementioned default value is "0"
(integer zero) no value will be sent to VDSM and effectively the default
VDSM behavior will be enacted.
Change-Id: Ia16f66540497d20178efae6989710000110a81d6
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MigrateVDSCommandParameters.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/AbstractVmRowMapper.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/MigrateBrokerVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
M packaging/dbscripts/create_views.sql
A packaging/dbscripts/upgrade/03_04_0480_add_vm_migration_downtime.sql
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
M packaging/dbscripts/vm_templates_sp.sql
M packaging/dbscripts/vms_sp.sql
M packaging/etc/engine-config/engine-config.properties
24 files changed, 143 insertions(+), 27 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22272
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia16f66540497d20178efae6989710000110a81d6
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 11 months
Change in ovirt-engine[ovirt-engine-3.4]: packaging: services: ovirt-engine: move deployments to tmpdir
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: packaging: services: ovirt-engine: move deployments to tmpdir
......................................................................
packaging: services: ovirt-engine: move deployments to tmpdir
the deployments' content is controlled by ENGINE_APPS, we should run
these applications and only these.
much easier to re-create on every startup than syncing with existing.
this removes the need to remove markers, sync symlinks and other tasks.
I failed to make jboss substitute system property within the
configuration and within the paths configuration, so I use template
substitution.
Change-Id: I17e7bc91229e9b05e6fb719a9c15c1036a3ba19b
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M Makefile
M ovirt-engine.spec.in
M packaging/services/ovirt-engine/ovirt-engine.py
M packaging/services/ovirt-engine/ovirt-engine.xml.in
4 files changed, 30 insertions(+), 69 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23347
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I17e7bc91229e9b05e6fb719a9c15c1036a3ba19b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
10 years, 11 months
Change in ovirt-engine[ovirt-engine-3.4]: restapi: Allow enabling/disabling SSO
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: restapi: Allow enabling/disabling SSO
......................................................................
restapi: Allow enabling/disabling SSO
This small feature allows controlling SSO per VM via REST API.
Change-Id: I25bf94646ea89684152e48f25ad604db6e59e86c
Bug-Url: https://bugzilla.redhat.com/1035279
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/SsoMethod.java
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/SsoMethod.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/SsoMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/TemplateMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/SsoMapperTest.java
8 files changed, 208 insertions(+), 2 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23383
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I25bf94646ea89684152e48f25ad604db6e59e86c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
10 years, 11 months
Change in ovirt-engine[ovirt-engine-3.4]: utils: osinfo: do not use absolute paths
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: utils: osinfo: do not use absolute paths
......................................................................
utils: osinfo: do not use absolute paths
Project should always used build time customization for all paths. This
enables working at devenv mode and at different distributions and
settings.
Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1043206
Change-Id: I51be14104b73214602c491383fde6b34ef4f094c
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java
M packaging/conf/osinfo-defaults.properties
2 files changed, 11 insertions(+), 11 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23338
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I51be14104b73214602c491383fde6b34ef4f094c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
10 years, 11 months
Change in ovirt-engine[ovirt-engine-3.4]: packaging: osinfo: move sysprep defaults out of /etc
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: packaging: osinfo: move sysprep defaults out of /etc
......................................................................
packaging: osinfo: move sysprep defaults out of /etc
when moved to using conf.d structure, there is no reason why storing
sysprep files in /etc as user can install his own osinfo config and
overwrite product defaults reference with his own.
this simplifies pushing product changes without the rpmsave/rpmnew hell
and enables support to understand site customization.
upgrade is comparing current install sysprep files and keep these that
are different from product default at existing location, creating osinfo
configuration for these.
the move to osinfo neglected the ability of user to specify different
setting for sysprep in database, we also fix that.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1043206
Change-Id: I26a853c12ca091f340d6ebed2c10726462ec576a
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M ovirt-engine.spec.in
M packaging/conf/osinfo-defaults.properties
R packaging/conf/sysprep/sysprep.2k12x64
R packaging/conf/sysprep/sysprep.2k3
R packaging/conf/sysprep/sysprep.2k8
R packaging/conf/sysprep/sysprep.2k8x64
R packaging/conf/sysprep/sysprep.w7
R packaging/conf/sysprep/sysprep.w7x64
R packaging/conf/sysprep/sysprep.w8
R packaging/conf/sysprep/sysprep.w8x64
R packaging/conf/sysprep/sysprep.xp
M packaging/setup/ovirt_engine_setup/constants.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/options.py
A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/legacy/__init__.py
A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/legacy/osinfo.py
15 files changed, 223 insertions(+), 82 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, approved
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23339
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I26a853c12ca091f340d6ebed2c10726462ec576a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
10 years, 11 months
Change in ovirt-hosted-engine-setup[master]: build: post ovirt-hosted-engine-setup-1.1 branching
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: build: post ovirt-hosted-engine-setup-1.1 branching
......................................................................
build: post ovirt-hosted-engine-setup-1.1 branching
Change-Id: Idbe5e6919d49e7e76e0ffc0b7ceb31c7f8e7e157
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M configure.ac
M ovirt-hosted-engine-setup.spec.in
2 files changed, 4 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23390
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idbe5e6919d49e7e76e0ffc0b7ceb31c7f8e7e157
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 11 months
Change in ovirt-hosted-engine-setup[master]: packaging: spec: update deps
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: spec: update deps
......................................................................
packaging: spec: update deps
updated SDK for URI rework and VDSM for hosted engine support.
Change-Id: I86ad58dd0c34dfcb9d2d630646820d41234c5ca8
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M ovirt-hosted-engine-setup.spec.in
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/23388
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I86ad58dd0c34dfcb9d2d630646820d41234c5ca8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 11 months
