January 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Remove root exclude-filters.xml
by amureini＠redhat.com 12 Jan '14

12 Jan '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove root exclude-filters.xml ...................................................................... core: Remove root exclude-filters.xml Removed the exclude-filters.xml file placed in the root directory. This file is not referenced in any pom.xml file and the exclusion filter it contains is stated in the correct module, frontend/webadmin/modules/uicompat/exclude-filters.xml. Change-Id: I489b4974dbe35af76a59c44fe034476912339450 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D exclude-filters.xml 1 file changed, 0 insertions(+), 14 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23172 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I489b4974dbe35af76a59c44fe034476912339450 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: No param dependency in AsyncTasks' equals
by amureini＠redhat.com 12 Jan '14

12 Jan '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: No param dependency in AsyncTasks' equals ...................................................................... core: No param dependency in AsyncTasks' equals AsyncTasks' equals(Object) and hashCode() rely on VdcActionParametersBase's equals(Object) and hashCode() (respectively), which are known to be broken (as the inheriting classes do not override them). These methods were removed from VdcActionParametersBase in patch 2d884006f356ca95c6b43a509aa809cc3647552c, which neglected to remove the dependency from AsyncTasks, breaking the DAO test suite. This patch remedies that mistake. Change-Id: Ib3b8ce8f32442732b9a529b2d354803ece1b55f4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AsyncTasks.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23181 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3b8ce8f32442732b9a529b2d354803ece1b55f4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: history: added vm creator user name and id to collection
by ydary＠redhat.com 12 Jan '14

12 Jan '14

Yaniv Dary has submitted this change and it was merged. Change subject: history: added vm creator user name and id to collection ...................................................................... history: added vm creator user name and id to collection Change-Id: Ifc3bfcc82870119716d4afa0ec13d42879cc6bd8 Bug-Url: https://bugzilla.redhat.com/896139 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M etl_export/src/ovirt_engine_dwh/configurationsync_3_4/ConfigurationSync.java M packaging/dbscripts/create_views_3_4.sql A packaging/dbscripts/upgrade/03_04_0020_add_vm_created_by.sql M tos_project/process/ConfigurationSync_3.4.item M tos_project/process/ConfigurationSync_3.4.properties M tos_project/talend.project 6 files changed, 557 insertions(+), 35 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23064 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc3bfcc82870119716d4afa0ec13d42879cc6bd8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Set password auth field as default for reinstall a...
by derez＠redhat.com 12 Jan '14

12 Jan '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Set password auth field as default for reinstall after installFailed ...................................................................... webadmin: Set password auth field as default for reinstall after installFailed Change-Id: I458e99a6351cd38d71a9949fb3044af5cfafd673 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/InstallModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInstallPopupView.java 3 files changed, 21 insertions(+), 6 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22919 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I458e99a6351cd38d71a9949fb3044af5cfafd673 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: enhanced event message to provide gluster volume name
by ofrenkel＠redhat.com 12 Jan '14

12 Jan '14

Omer Frenkel has submitted this change and it was merged. Change subject: gluster: enhanced event message to provide gluster volume name ...................................................................... gluster: enhanced event message to provide gluster volume name Add gluster volume name for remove brick commit messages and replace brick failed message Change-Id: Ia31b581e13386bb4f02385bbd1a9433d508e49ec Signed-off-by: Timothy Asir <tjeyasin(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia31b581e13386bb4f02385bbd1a9433d508e49ec Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: Enhanced events log message for add or remove hosts
by ofrenkel＠redhat.com 12 Jan '14

12 Jan '14

Omer Frenkel has submitted this change and it was merged. Change subject: gluster: Enhanced events log message for add or remove hosts ...................................................................... gluster: Enhanced events log message for add or remove hosts Change "gluster server" into "host" Change-Id: I318bf387c700e1049340131aa043fc97241ffdae Signed-off-by: Timothy Asir <tjeyasin(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22668 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I318bf387c700e1049340131aa043fc97241ffdae Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: introduce customized snapshot preview support
by derez＠redhat.com 12 Jan '14

12 Jan '14

Daniel Erez has submitted this change and it was merged. Change subject: core: introduce customized snapshot preview support ...................................................................... core: introduce customized snapshot preview support * Updated the commands used for preview/commit/undo snapshots to support customized snapshots (by identifying and handling a custom disks list) * SnapshotManager: ** generateVmConfiguration method now also accepts an argument for specified disks list (needed for custom preview). Feature: http://www.ovirt.org/Features/Single_Disk_Snapshot Change-Id: I89332a1538c7259dd3ea62d693ac062f47e52cd0 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreStatelessVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RestoreAllSnapshotCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RestoreAllSnapshotsParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/TryBackToAllSnapshotsOfVmParameters.java 7 files changed, 139 insertions(+), 26 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22776 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89332a1538c7259dd3ea62d693ac062f47e52cd0 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: support for partial snapshot creation
by derez＠redhat.com 12 Jan '14

12 Jan '14

Daniel Erez has submitted this change and it was merged. Change subject: core: support for partial snapshot creation ...................................................................... core: support for partial snapshot creation Introducing support for creating a snapshot using a specified disks list, i.e. taking a snapshot only on the selected disks. * CreateAllSnapshotsFromVmParameters: ** Added an optional disks list member. * CreateAllSnapshotsFromVmCommand: ** Updated accordingly to handle the specified disks list. * SnapshotManager: ** Added addActiveSnapshot method signature that accepts disks list argument. ** Modified addSnaphot methods accordingly. Feature: http://www.ovirt.org/Features/Single_Disk_Snapshot Change-Id: Ieb7cb389229219bbb0212e3ee58cc45c39727c75 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImagesHandlerTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateAllSnapshotsFromVmParameters.java 5 files changed, 227 insertions(+), 14 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22775 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb7cb389229219bbb0212e3ee58cc45c39727c75 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: history: added vm creator user name and id to collection
by emesika＠redhat.com 12 Jan '14

12 Jan '14

Eli Mesika has submitted this change and it was merged. Change subject: history: added vm creator user name and id to collection ...................................................................... history: added vm creator user name and id to collection Change-Id: Ie14fe5cb6aca11085f67302877b127739313b272 Bug-Url: https://bugzilla.redhat.com/896139 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/dbscripts/create_dwh_views.sql 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23065 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie14fe5cb6aca11085f67302877b127739313b272 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-cli[master]: cli: implement StateMachine.rollback()
by mishka8520＠yahoo.com 12 Jan '14

12 Jan '14

Michael Pasternak has submitted this change and it was merged. Change subject: cli: implement StateMachine.rollback() ...................................................................... cli: implement StateMachine.rollback() StateMachine.rollback() is triggered when an error occurred during logical state transition, such as connection failure in 'connect' command, calling rollback() will return StateMachine to the origin state whatever it was before the failure. Change-Id: Ideaf855e2475bd39cf15454b09aa8add0fc08726 Signed-off-by: Michael Pasternak <mishka8520(a)yahoo.com> --- M src/ovirtcli/command/connect.py M src/ovirtcli/command/disconnect.py M src/ovirtcli/state/dfsaevent.py M src/ovirtcli/state/finitestatemachine.py M src/ovirtcli/state/statemachine.py 5 files changed, 51 insertions(+), 5 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/23076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ideaf855e2475bd39cf15454b09aa8add0fc08726 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com>

1 0