January 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-java[master]: codegen: Remove explicit dependency on httpclient
by juan.hernandez＠redhat.com 02 Jan '14

02 Jan '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Remove explicit dependency on httpclient ...................................................................... codegen: Remove explicit dependency on httpclient Currently the code generator depends explictly on the httpclient because many methods declare org.apache.http.client.ClientProtocolException as one of the exceptions that they may throw. But all these methods already declare that they may throw the more generic java.io.IOException, so the former is redundant. This patch removes the dependency from the POM and the exception from the throws declarations. Change-Id: I8f5fdbb0d82d9606763ef16786438e30ac53a8fc Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M ovirt-engine-sdk-java-codegen/pom.xml M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/Main.java M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/common/AbstractCodegen.java M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/common/ICodegen.java M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/rsdl/ApiCodegen.java M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/rsdl/RsdlCodegen.java M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/xsd/XsdCodegen.java 7 files changed, 9 insertions(+), 34 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22893 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f5fdbb0d82d9606763ef16786438e30ac53a8fc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: do not attempt to get websocket proxy stat...
by iheim＠redhat.com 02 Jan '14

02 Jan '14

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: do not attempt to get websocket proxy status in devenv ...................................................................... packaging: setup: do not attempt to get websocket proxy status in devenv Change-Id: I0454e3f136ad1181bc01c55411b33b1e2fc20e4c Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/config/websocket_proxy.py 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22863 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0454e3f136ad1181bc01c55411b33b1e2fc20e4c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: support 3.4
by sbonazzo＠redhat.com 02 Jan '14

02 Jan '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: support 3.4 ...................................................................... packaging: setup: support 3.4 Change-Id: I24ce1e510075c3c090d84522f2414c1e99a22bf9 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-common/base/core/misc.py 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22894 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24ce1e510075c3c090d84522f2414c1e99a22bf9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: Fix /etc/sysconfig/nfs quotes
by sbonazzo＠redhat.com 02 Jan '14

02 Jan '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Fix /etc/sysconfig/nfs quotes ...................................................................... packaging: setup: Fix /etc/sysconfig/nfs quotes Put the params/values as python code and not semi-configfile, as ConfigFile strips quotes. Change-Id: Iaca3c6eb7195e3e3ffafa456bbd1732edad02a56 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- D packaging/conf/nfs.sysconfig.in M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py 3 files changed, 11 insertions(+), 22 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22622 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaca3c6eb7195e3e3ffafa456bbd1732edad02a56 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: customize NFS export ACL
by sbonazzo＠redhat.com 02 Jan '14

02 Jan '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: customize NFS export ACL ...................................................................... packaging: setup: customize NFS export ACL ACL is always input and no attempt is done to preserve previous values. Export line is always regenerated. If there is /etc/exports.d, the file there is always regenerated and contains a suitable comment. If path is exported in /etc/exports and there is /etc/exports.d, we delete the line from /etc/exports. Change-Id: Ia35aaf42cb46247a2a02df1c2418f4613ad6b965 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/iso_domain.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/exportfs.py 3 files changed, 67 insertions(+), 70 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22570 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia35aaf42cb46247a2a02df1c2418f4613ad6b965 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[ovirt-3.3]: packaging: on upgrade first backup
by ydary＠redhat.com 02 Jan '14

02 Jan '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: on upgrade first backup ...................................................................... packaging: on upgrade first backup Backup before doing any changes to the database Dump only schema for changing ownership Run all ownership changes in a single psql command Bug-Url: https://bugzilla.redhat.com/1046679 Bug-Url: https://bugzilla.redhat.com/1046676 Change-Id: I1b85a6aee99e94856b233f1c2285fd69e31e053f Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/common_utils.py M packaging/ovirt-engine-dwh-setup.py 2 files changed, 155 insertions(+), 81 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22906 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b85a6aee99e94856b233f1c2285fd69e31e053f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix build break
by mkolesni＠redhat.com 02 Jan '14

02 Jan '14

Mike Kolesnik has submitted this change and it was merged. Change subject: webadmin: Fix build break ...................................................................... webadmin: Fix build break Missed a change from upper case to lower case in a field, now fixed. Change-Id: I25e9368cf08bd4dfe06c39f3c1bd807468d84888 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/RemoveConfirmationPopupView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Mike Kolesnik: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25e9368cf08bd4dfe06c39f3c1bd807468d84888 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Add "remove from provider" checkbox
by mkolesni＠redhat.com 02 Jan '14

02 Jan '14

Mike Kolesnik has submitted this change and it was merged. Change subject: webadmin: Add "remove from provider" checkbox ...................................................................... webadmin: Add "remove from provider" checkbox Added checkbox allowing removal of an external network from the provider as well when removing the network from oVirt. Change-Id: Ic39d7d2424159dd354aae3610d86b78fb8ab309e Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/RemoveNetworksModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 2 files changed, 16 insertions(+), 6 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22615 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic39d7d2424159dd354aae3610d86b78fb8ab309e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Add ability to set the "force" label
by mkolesni＠redhat.com 02 Jan '14

02 Jan '14

Mike Kolesnik has submitted this change and it was merged. Change subject: webadmin: Add ability to set the "force" label ...................................................................... webadmin: Add ability to set the "force" label Added ability to set the "Force remove" check box label to be able to use it to specify a more detailed message. The force default value will be taken from the field force in the model. Change-Id: If200c35cf36cf6f0fd7aa3d8ad0b0b59ce3ac1f8 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/RemoveConfirmationPopupView.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ConfirmationModel.java 2 files changed, 32 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22614 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If200c35cf36cf6f0fd7aa3d8ad0b0b59ce3ac1f8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Support removing external networks
by mkolesni＠redhat.com 02 Jan '14

02 Jan '14

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Support removing external networks ...................................................................... core: Support removing external networks Add ability to remove an external network from an external networks provider when removing a network from the system. Change-Id: I123076564188945753f62c445e684d9f1901e1df Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/AddNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/NetworkCommon.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/NetworkModification.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/RemoveNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/NetworkProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/OpenstackNetworkProviderProxy.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveNetworkParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/RemoveNetworksModel.java 9 files changed, 147 insertions(+), 15 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I123076564188945753f62c445e684d9f1901e1df Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0